diff mbox series

[1/5] dt-bindings: hwlock: Document STM32 hwspinlock bindings

Message ID 20181031093032.20386-2-benjamin.gaignard@st.com
State New
Headers show
Series Add support of STM32 hwspinlock | expand

Commit Message

Benjamin Gaignard Oct. 31, 2018, 9:30 a.m. UTC
Add bindings for STM32 hardware spinlock device

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>

---
 .../bindings/hwlock/st,stm32-hwspinlock.txt        | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt

-- 
2.15.0

Comments

Bjorn Andersson Nov. 8, 2018, 6:49 a.m. UTC | #1
On Wed 31 Oct 02:30 PDT 2018, Benjamin Gaignard wrote:

> Add bindings for STM32 hardware spinlock device

> 

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>

> ---

>  .../bindings/hwlock/st,stm32-hwspinlock.txt        | 23 ++++++++++++++++++++++

>  1 file changed, 23 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt

> 

> diff --git a/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt

> new file mode 100644

> index 000000000000..7a999479d802

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt

> @@ -0,0 +1,23 @@

> +STM32 Hardware Spinlock Device Binding

> +-------------------------------------

> +

> +Required properties :

> +- compatible : should be "st,stm32-hwspinlock".

> +- reg : the register address of hwspinlock.

> +- #hwlock-cells : hwlock users only use the hwlock id to represent a specific

> +	hwlock, so the number of cells should be <1> here.

> +- clock-names : Must contain "hwspinlock".


This is supposed to be the name of the clock signal of this hardware
block, is it really named "hwspinlock"? Note that you can probably omit
the clock-names property, as you only have a single clock...

Apart from that, I think the binding looks good.

Regards,
Bjorn

> +- clocks : Must contain a phandle entry for the clock in clock-names, see the

> +	common clock bindings.

> +

> +Please look at the generic hwlock binding for usage information for consumers,

> +"Documentation/devicetree/bindings/hwlock/hwlock.txt"

> +

> +Example of hwlock provider:

> +	hwspinlock@4c000000 {

> +		compatible = "st,stm32-hwspinlock";

> +		#hwlock-cells = <1>;

> +		reg = <0x4c000000 0x400>;

> +		clocks = <&rcc HSEM>;

> +		clock-names = "hwspinlock";

> +	};

> -- 

> 2.15.0

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt
new file mode 100644
index 000000000000..7a999479d802
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt
@@ -0,0 +1,23 @@ 
+STM32 Hardware Spinlock Device Binding
+-------------------------------------
+
+Required properties :
+- compatible : should be "st,stm32-hwspinlock".
+- reg : the register address of hwspinlock.
+- #hwlock-cells : hwlock users only use the hwlock id to represent a specific
+	hwlock, so the number of cells should be <1> here.
+- clock-names : Must contain "hwspinlock".
+- clocks : Must contain a phandle entry for the clock in clock-names, see the
+	common clock bindings.
+
+Please look at the generic hwlock binding for usage information for consumers,
+"Documentation/devicetree/bindings/hwlock/hwlock.txt"
+
+Example of hwlock provider:
+	hwspinlock@4c000000 {
+		compatible = "st,stm32-hwspinlock";
+		#hwlock-cells = <1>;
+		reg = <0x4c000000 0x400>;
+		clocks = <&rcc HSEM>;
+		clock-names = "hwspinlock";
+	};