From patchwork Wed Aug 28 07:19:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tero Kristo X-Patchwork-Id: 172338 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp366607ily; Wed, 28 Aug 2019 00:22:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyl2NtGDIJKPFy8/LsswzHoXW4dwQ0qISSX2kOUdXGbuUitWcXPRjcRXKDcSJcd8jj6C39y X-Received: by 2002:a17:902:5a08:: with SMTP id q8mr2918880pli.234.1566976807514; Wed, 28 Aug 2019 00:20:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566976807; cv=none; d=google.com; s=arc-20160816; b=aX18QLXW1s+5yuFcAnRPpKnTGIN44rI+uIaZKa0GuxmT8UxvFKbJGI8EFMj025zu8I ZKDmGdpRxIrKQPOTPorr8qVfbo6e02lbRmoSZbDWtQdVZluL5XN6oxG8FGFvEPu/yCSn sDpvWFG/54kRKLSHRqA8FfKZiCUKtfLVXOxJ7cvFuw/okB0JpwP01dV5ueadLWol0NBe cIchd+R2doWv8NtHNtze5w1h/H5rE4uaQ3vhh8EIq/u1teQM4/p2Ek6lpFF62yl04e8V CLxlZPqLT+BMPSrqP6lYurjCdAIi2KN2HyoBpwQsP4Ng/37/RczIAOovJhmqxosp2S8N u7AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=lun/IihhVZD0SSuBuE72idtwD4SSrSW8blVhgZgqk2U=; b=XeXHZFF03Sk7yCgr8S0rD02Kl5BhCu9gPbmPbyvjiEw+U1TuFXFheU4enWPmYSC+LD JA8rUF/J1tdch6Cd63OhbBYP4kFYFyaWWjgFtJb3G+x9DrBozvz6IBh4Q62rsZwohxm0 NDBtey/rSvixAircR3kUKZXeL4BHNmkulEJ92Dlc9GMFto+j79tMPmAlxIfyI4iIrXSc gYOgyeI6QK/T79i4pOHxt5ZO4RwHSfDADSAw/o57TB9yS/C9YLCPntLQ1SpzbSh6RwsI EbBZ3+2juyzrYL5WWreaPsfJ6gO1uTy4WgDm44JFOrU8dYl6pe9izDPT1f4tPcJuYXOA DniA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=sE5yNRtk; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9si1222986plo.306.2019.08.28.00.20.07; Wed, 28 Aug 2019 00:20:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=sE5yNRtk; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726397AbfH1HUG (ORCPT + 8 others); Wed, 28 Aug 2019 03:20:06 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:59396 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfH1HUG (ORCPT ); Wed, 28 Aug 2019 03:20:06 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7S7JxAl116149; Wed, 28 Aug 2019 02:19:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1566976799; bh=lun/IihhVZD0SSuBuE72idtwD4SSrSW8blVhgZgqk2U=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=sE5yNRtkvGyAPqmNv20ep8YkcF+5JLPMY4UC7vGG9gyEVOtYrxe3ZN0AU5DmyGY6/ jqSEMF1M0TASDP6kp4ALgZV6Ov++akIxnWCuuC/MoHaIBbxQ1iqskeaJUYqHoHP9VC XtWuhxZg1vfdeNP0W+tjXKfRDMKSUHBgzvKNoTRg= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7S7Jxsw078153 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 28 Aug 2019 02:19:59 -0500 Received: from DLEE113.ent.ti.com (157.170.170.24) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 28 Aug 2019 02:19:57 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 28 Aug 2019 02:19:57 -0500 Received: from sokoban.bb.dnainternet.fi (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7S7JmfF052201; Wed, 28 Aug 2019 02:19:55 -0500 From: Tero Kristo To: , , , , CC: , , Subject: [PATCHv2 03/11] soc: ti: omap-prm: poll for reset complete during de-assert Date: Wed, 28 Aug 2019 10:19:33 +0300 Message-ID: <20190828071941.32378-4-t-kristo@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190828071941.32378-1-t-kristo@ti.com> References: <20190828071941.32378-1-t-kristo@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Poll for reset completion status during de-assertion of reset, otherwise the IP in question might be accessed before it has left reset properly. Signed-off-by: Tero Kristo --- drivers/soc/ti/omap_prm.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c index fd5c431f8736..afeb70761b27 100644 --- a/drivers/soc/ti/omap_prm.c +++ b/drivers/soc/ti/omap_prm.c @@ -127,6 +127,7 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, u32 v; int st_bit; bool has_rstst; + int timeout = 0; if (!_is_valid_reset(reset, id)) return -EINVAL; @@ -153,6 +154,25 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, v &= ~(1 << id); writel_relaxed(v, reset->prm->base + reset->prm->data->rstctrl); + if (!has_rstst) + return 0; + + /* wait for the status to be set */ + while (1) { + v = readl_relaxed(reset->prm->base + reset->prm->data->rstst); + v &= 1 << st_bit; + if (v) + break; + timeout++; + if (timeout > OMAP_RESET_MAX_WAIT) { + pr_err("%s: timedout waiting for %s:%lu\n", __func__, + dev_name(rcdev->dev), id); + return -EBUSY; + } + + udelay(1); + } + return 0; }