From patchwork Thu Sep 12 11:39:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tero Kristo X-Patchwork-Id: 173688 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:ce:0:0:0:0 with SMTP id r14csp2003738ilq; Thu, 12 Sep 2019 04:39:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqy7UT+2ewr8+8jt2FkLhX03VHR5U3dghRVdbbTlCYarmlAf8q2lrd9NIcm0Wx5hB17lE/FC X-Received: by 2002:a17:906:c359:: with SMTP id ci25mr33430850ejb.205.1568288381076; Thu, 12 Sep 2019 04:39:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1568288381; cv=none; d=google.com; s=arc-20160816; b=hc8MR4JvyydKHv4hnUq6lEXyf5DGmGced2/sVPfrEoN6J+xj9REcRGAj/bILV7LIjI 7b5YFGMWJuiKhuL7HntGTMMMH3AvUSDQeC/GNDqaM7uW7rqn+mxOIvmbzzGPNqk4qXGT +qyGSXe6qOKTSQM5lhcprkZiP45PvH4XeR8OPXvrS0TYShRePg5JQ7ojkk73xr+r1A0j M0CGlnlkTB7+GfsG8x1pgTG62CMssG+QuV+insVf8WxEgO6v1merExkAnk0AGHnZaLLW 5eqkzlKDRQxM+0qknFbRPMy+NO9/gOvBfs05uBSvNCu4c2YJmfqUsEBSAq319vgtCkZF KfwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=Y7vuHmki0AitevIY4QTjUpFCGHBSgA345LWzYu3kdGg=; b=K/o3baXygX4mpxGA+FNPsne1Ym+2Ia5EZlDr8oEs3Clv8I8pszZb8o7aS1dKUBwqyx GHnaB8wOFT7w4FuKZg9XliAnMPKXvsc1VC6LFX0xFXIdHTU1Ht8MktFEM+AbEidDSc9y RWwMdqhz/mbnzjKJD1xGdWLw32AQh6XwDV0F2LgSmMZk0L1oE+a2bOuwQzuR1hqfI+1g CbRHQXH6zCeSATsLIZGFK5+oxa1UPeXW4sKp3BFO56NrWN0X7E4O63t681kdRLeeI0ki b0YmiWC/suRb1HoUycJ7MjzOX4jkXxtnMtDNUnwTNBof15Eze+tJ1QP+rZkbZzT77amA jO8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=JUHApH35; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z20si8881422edq.250.2019.09.12.04.39.40; Thu, 12 Sep 2019 04:39:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=JUHApH35; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728298AbfILLjj (ORCPT + 8 others); Thu, 12 Sep 2019 07:39:39 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:58742 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730268AbfILLjj (ORCPT ); Thu, 12 Sep 2019 07:39:39 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8CBdVWb024466; Thu, 12 Sep 2019 06:39:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1568288371; bh=Y7vuHmki0AitevIY4QTjUpFCGHBSgA345LWzYu3kdGg=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=JUHApH358MOEJyikt2JFci4OCHJ2KvKh0ljxWHTIgizurT7vSPy1BoJI/2KWqftXw et33QuUlNQX/ExgQfoVBzjo1ygi8zgTdvso6+FtdWgfo6PbAwK3WYPlY5vBJJ/HG5o 7/h1a7Home9Mxe2ub07G1mF84Yk9tqQpblv/S24U= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8CBdVFe074023; Thu, 12 Sep 2019 06:39:31 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 12 Sep 2019 06:39:30 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 12 Sep 2019 06:39:29 -0500 Received: from sokoban.bb.dnainternet.fi (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8CBdKcs120606; Thu, 12 Sep 2019 06:39:28 -0500 From: Tero Kristo To: , , , , , CC: , Subject: [PATCHv5 03/10] soc: ti: omap-prm: poll for reset complete during de-assert Date: Thu, 12 Sep 2019 14:39:09 +0300 Message-ID: <20190912113916.20093-4-t-kristo@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190912113916.20093-1-t-kristo@ti.com> References: <20190912113916.20093-1-t-kristo@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Poll for reset completion status during de-assertion of reset, otherwise the IP in question might be accessed before it has left reset properly. Signed-off-by: Tero Kristo --- drivers/soc/ti/omap_prm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c index ab0b66ad715d..96fa2aad9b93 100644 --- a/drivers/soc/ti/omap_prm.c +++ b/drivers/soc/ti/omap_prm.c @@ -153,6 +153,18 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev, writel_relaxed(v, reset->prm->base + reset->prm->data->rstctrl); spin_unlock_irqrestore(&reset->lock, flags); + if (!has_rstst) + return 0; + + /* wait for the status to be set */ + ret = readl_relaxed_poll_timeout(reset->prm->base + + reset->prm->data->rstst, + v, v & BIT(st_bit), 1, + OMAP_RESET_MAX_WAIT); + if (ret) + pr_err("%s: timedout waiting for %s:%lu\n", __func__, + reset->prm->data->name, id); + return 0; }