From patchwork Thu Nov 26 21:06:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 333065 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp1634084ilb; Thu, 26 Nov 2020 13:08:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxhE26xX/NYla/kmt5Ppywrs+B/7P5O2CcW7diVoA3enFD7UJFgcnrXuu3BNR+rbGxd+gPb X-Received: by 2002:a17:907:d1f:: with SMTP id gn31mr4530012ejc.192.1606424910975; Thu, 26 Nov 2020 13:08:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606424910; cv=none; d=google.com; s=arc-20160816; b=oclcBIrxE6Od3xwivp6hB3p0/Qs79pA29VBmQmCv0v/FOMhWZEQ5wNVCjtJrjRiahv oP7iqsH+1ihWRatpxVKXmz7ElmIKu+qhJbFxv8zzV1H0yEHTodqowi6KOkQD9LosIi7w Gu7s5RmC/u9erjiwzRGWOaUDQ+Z7veRLierAZmIQr+gptKYYRTbJgImIOGUwNN6wLQa+ TWo0qE7jOjv14Zo+qHVhuNtCVBVGOJLh4uWBJ8jFzBav4H1InQN/67pVVjVBc1+QR3YF GumEJvSlWscPND/u5HWUCERZ1jNq8K27sdF2EV7z3N3A5RXT9MntLfjXPg3QrgxDbGUu mILA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1P3NOdCqAdCJq/BOuunpYV7qT3SyZVIkKnqupYZ7/no=; b=lLtbvwkMawr+SEppimvbl3NyhOlABY7ngaT7CAa+dFQIze4oJuB1wcfiJo4bVoBuXQ M6AH6aHUpXPZ5w02nr1Mo/7ORHzZicUh4gddvD5uNc0d5OgaG4o8G46CbVkUKjj9zX/c w+fZ9p6IrVDC5PN0WW87wWuqPKkte4y8TRZzCk3y9oLrQR/tV/sFsd45z3L1WNsuOc2t rXRyt1xgDFPSAFFYO4i4ckNN46M4IN4GgeX1Wru5oH6Hf+R0MQm7UM/+1+9mmoRACJ70 wUV1AVzvDS/cIsH+VsFbuv7ls7KOXYsbxmnJdLy7elBFQh2tS3SY0riNem9mmdECyAQ5 WkAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LlMmf89n; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k11si3567033ejg.330.2020.11.26.13.08.30; Thu, 26 Nov 2020 13:08:30 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LlMmf89n; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391770AbgKZVHQ (ORCPT + 6 others); Thu, 26 Nov 2020 16:07:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391621AbgKZVG5 (ORCPT ); Thu, 26 Nov 2020 16:06:57 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D8E8C0617A7 for ; Thu, 26 Nov 2020 13:06:57 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id j19so2581148pgg.5 for ; Thu, 26 Nov 2020 13:06:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1P3NOdCqAdCJq/BOuunpYV7qT3SyZVIkKnqupYZ7/no=; b=LlMmf89n/RaE6fIA2xiG8wudKfbZ9qECYcET3zyzPcMVC2R3jZQWZ8m0OZny6TMBzE kr1HA8Fzoz8eoyA3AEFca6Eup4zYcinQuC0FVbLBt3KavqxuptgPUXctZPzVYzcJ5QMV DjmN76HZIt5NJC35aU+IModI+fjoutBo/SGE38ZlQ0LgVoJYfQf+N+15ZPUFcn33WMDG dJ0QBHxlk0yOv1VYcbHEBAAcQy+8xRtzb+78uszO1Al2bmeARNAUbMAYZ6e2vEFqI5oQ svfPdXVQzFEwrgoZ2Whpc/bTJ4+Oxf7x0w8rfRQ62uCBYm5/nsAa7blYl6bYiQTqJqYA CkVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1P3NOdCqAdCJq/BOuunpYV7qT3SyZVIkKnqupYZ7/no=; b=bp8u7CR5hBW0JBrXLnR7gjE6OoeNtLu9BTms6LLjmm8ZO8uIJJG2Yyr7l7jktxrp0S Z8F3U30doACvn8sPkJ/pBLOx5s3eZVSpxroUQkpog9A8a3GUb/6ifsXnkwKQ5IEgaR6X 6PK78RAdumlhl4FgJ5ici2lUZrygFrPSuEdms8l1fyXpuV3Wb1PtLZz0B/7B5tReN8dt PMq6OUwGkRLeQbR853+nQHX0HihAvRk36821uXLVy7CzDqj/Hp535XSDC+FoiZsEyePC MSbfuTsCRd/sdMwNDWsq5yQOaTwtJvnLgI42VjsdL6mzycUHTz78Lc/MBZD9Jkrgtvfe qqRg== X-Gm-Message-State: AOAM532hhHOf0SbJEitu6SU0Cmq/NDimVLxifF4WkKZ+YUKsXBjL/1dZ lEH3NLtTrwcRTcgsEbOBO6gOFA== X-Received: by 2002:a17:90b:784:: with SMTP id l4mr5752881pjz.56.1606424817036; Thu, 26 Nov 2020 13:06:57 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id c203sm5612676pfc.10.2020.11.26.13.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 13:06:56 -0800 (PST) From: Mathieu Poirier To: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com Subject: [PATCH v3 13/15] remoteproc: Properly deal with a start request when attached Date: Thu, 26 Nov 2020 14:06:40 -0700 Message-Id: <20201126210642.897302-14-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126210642.897302-1-mathieu.poirier@linaro.org> References: <20201126210642.897302-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This patch takes into account scenarios where a remote processor has been attached to when receiving a "start" command from sysfs. As with the "running" case, the command can't be carried out if the remote processor is already in operation. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_cdev.c | 3 ++- drivers/remoteproc/remoteproc_sysfs.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.25.1 Reviewed-by: Arnaud Pouliquen diff --git a/drivers/remoteproc/remoteproc_cdev.c b/drivers/remoteproc/remoteproc_cdev.c index d06f8d4919c7..61541bc7d26c 100644 --- a/drivers/remoteproc/remoteproc_cdev.c +++ b/drivers/remoteproc/remoteproc_cdev.c @@ -32,7 +32,8 @@ static ssize_t rproc_cdev_write(struct file *filp, const char __user *buf, size_ return -EFAULT; if (!strncmp(cmd, "start", len)) { - if (rproc->state == RPROC_RUNNING) + if (rproc->state == RPROC_RUNNING || + rproc->state == RPROC_ATTACHED) return -EBUSY; ret = rproc_boot(rproc); diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 3696f2ccc785..7d281cfe3e03 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b/drivers/remoteproc/remoteproc_sysfs.c @@ -194,7 +194,8 @@ static ssize_t state_store(struct device *dev, int ret = 0; if (sysfs_streq(buf, "start")) { - if (rproc->state == RPROC_RUNNING) + if (rproc->state == RPROC_RUNNING || + rproc->state == RPROC_ATTACHED) return -EBUSY; ret = rproc_boot(rproc);