From patchwork Thu Nov 26 21:06:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 333059 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp1633982ilb; Thu, 26 Nov 2020 13:08:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJyee2d7v9M0jQ/+1XfUNdXpjankoS671aLOi4btM91shk4/t7CVVo7u1PapryqxrQs6NsCh X-Received: by 2002:a17:906:a448:: with SMTP id cb8mr4238839ejb.365.1606424902218; Thu, 26 Nov 2020 13:08:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606424902; cv=none; d=google.com; s=arc-20160816; b=XyGHi97olXwOlOn4pPWLyckTbqQcHy72HODGTagsBOHnDLkFw8YXw1e8P1/plIwj/a V3oY2FwH9KWk19wJgk/ZowVMTpz/aTTzGU26H4jVifMRRqUmMEmoApjiKA1SGqj4+QDj Oy5RIzTiweQ6g0kpl3K8QpLqEbVkXgR5DGO51kP1ZTRMNk1/ZbWmvNpp7GvEn0xgcYf5 vrGRDZMIJu+VOnBZ5rbv1jk1IuqQlP76fkBRHvgY53lfy+2yeL0yLexojCLBzsAMOqkm Zo71iJRi9tLYIvY5J55Dh0gBpqlFnqn1OeBbmxs4MS4fZm6ATiGFpAjz7YHmeWoFM27y w4Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F0fzZSP3VuvALU3rn9jJyyj4XDT1VCM3xuR6CeVfSK4=; b=shh+bISgkvipdsskE6EFa+xWqjJDnKx/3Y4kFSltRU40s2qsfUb/4l0MLJ7HnNWNap +6llMieD1OVdWxbYkT7JgJYTF/oP4vifwmzkjivD5QpUFPJBcxXSRv1Yaosdgvajcvel h/uiqi1VWHmAlLafupY6Mm37pQfbiWFCfZKsRDBlgBDWIzcG8qsfJRwEGYfhimIATbqs n0j0eNT02cl5s1ZLZxi1O8C6kmsesi/XrVzqgWIwb6Xg/QjLBDQUzaixo4iFaeFxhAnl aIa16+dGcUpXjrGVBILmJZDRUDe/KaRmZo+fJ3aCnBwH5cJEtOt19vivkk4q+3s2QBvm 6xzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oKXhRb7r; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k11si3567033ejg.330.2020.11.26.13.08.22; Thu, 26 Nov 2020 13:08:22 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oKXhRb7r; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390945AbgKZVGx (ORCPT + 6 others); Thu, 26 Nov 2020 16:06:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391232AbgKZVGv (ORCPT ); Thu, 26 Nov 2020 16:06:51 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C1AC061A47 for ; Thu, 26 Nov 2020 13:06:50 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id s63so2566651pgc.8 for ; Thu, 26 Nov 2020 13:06:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F0fzZSP3VuvALU3rn9jJyyj4XDT1VCM3xuR6CeVfSK4=; b=oKXhRb7rgRQ8Ff9EtJYzAcI9JIJBalQFImYaa+IHstrrVGKyeUsId9/pRSs7VBxEpM CfBW0UCgA0J5xT/t90eZ4Xjw4bhCzbfRoQefGUdC5tBNWIMDntsiRYprxSmapZ9Sh8qy b9RRPwP+M836Y8JOcTBdTyjCKDyBG5D7fAzODfc/mvellMd67kKcWmPKwM19l1Xjr5xU ZtDCWs4lknP6tZsneZH6ifkAPRzXx3PNAzhl16fufpW8yQpE2A+s0wPaKZ/HbHr3dD1U 6Q6IswulcAgUChgGeZ93HbyamFASpKZNNhKIMLDkZNInZVMxKTdrdoODNWfq1wi2Deio whcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F0fzZSP3VuvALU3rn9jJyyj4XDT1VCM3xuR6CeVfSK4=; b=r7Bim69zFoyP09/eAEgcBaW+e4nWA+4IunJzypxtXaWSVjEX9X0jQ81GimyonmGVkW hMybJdHKBONp8UZo18IRN0PXxpsnIqhUMvtuBdys8V7B0/OTQgOtJEKgnpKDb5p7WCtd Hd1+p6195fAitkpuLq3e+NfnChgvRg599jLMbIWvSC+ODMpQ3ZRjNNH++rRzUB8QAkPr vi9KbJdb7JoykhFqgmAWWPm29CcI8mgiUXd3UL2Evttsn656JZOw5banngaGZO3aznRP 2LUD1CDPvHNILpnk42j2oSSt+XIlHK6I7KivYbeIxStqXaiPFCwgPkcWzkkQ9ZHJytpQ NMgA== X-Gm-Message-State: AOAM531rTOAv4F9oHVnOPJtv1dUePSxintEC+76T1LGvJ0RAy1T5jmI+ c4pD4+y7qX3dcgmbZl7leAvh977dOQahsr0o X-Received: by 2002:a62:8448:0:b029:197:9ab7:9fdb with SMTP id k69-20020a6284480000b02901979ab79fdbmr4161012pfd.49.1606424809866; Thu, 26 Nov 2020 13:06:49 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id c203sm5612676pfc.10.2020.11.26.13.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 13:06:49 -0800 (PST) From: Mathieu Poirier To: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com Subject: [PATCH v3 06/15] remoteproc: Properly deal with a kernel panic when attached Date: Thu, 26 Nov 2020 14:06:33 -0700 Message-Id: <20201126210642.897302-7-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126210642.897302-1-mathieu.poirier@linaro.org> References: <20201126210642.897302-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The panic handler operation of registered remote processors should also be called when remote processors have been attached to. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 300785a18f03..539667948bc8 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -2471,7 +2471,11 @@ static int rproc_panic_handler(struct notifier_block *nb, unsigned long event, rcu_read_lock(); list_for_each_entry_rcu(rproc, &rproc_list, node) { - if (!rproc->ops->panic || rproc->state != RPROC_RUNNING) + if (!rproc->ops->panic) + continue; + + if (rproc->state != RPROC_RUNNING && + rproc->state != RPROC_ATTACHED) continue; d = rproc->ops->panic(rproc);