From patchwork Fri Dec 18 17:32:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 345475 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp2335672jai; Fri, 18 Dec 2020 09:35:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLnZdylGFP+A2fKp2D0v0mPwJJoDvu7BFXJB1bz2xj8gK/y/55+AAJVO3/8Do4sI2Bjrsa X-Received: by 2002:aa7:d6d8:: with SMTP id x24mr5550009edr.105.1608312917273; Fri, 18 Dec 2020 09:35:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608312917; cv=none; d=google.com; s=arc-20160816; b=jQaTZ6LdVOdpWcQmsnz4GKs6o3UOxgpPQKOK7xtse8lkLjsyGI+7nLy2nzUT1bkqBX +O9l0Cek+1ONqKttET4fx+YjFPlDwRJUrIfLpXty+yZjNpL92A3x54Xs8276nStvtIxY LbeCJVRwMxeo4+hyocpcGN2hoOrG/WcyXvALLKDvFOYaJN2Vc3e7h8qq1lqLJpfth0ty bkC8OEVQTiSiRRSS9en3I6kYPf9x5Xa2Qzemcs0z/fe6q+Ot+aLT98vJrm5kEojwCHva yXeyYaZRhbY7/Nh/lBryK021cw+r8oO0ZCwUqU1JczZ30FAA6aQRA1BUaOKhbpGey/AX dA5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vutdwpz2dUDTweVlb30ERc0HCxLnN2+/Hjzz5Y0E1bI=; b=w8QHc1U01bXOYPBOIYtRvspKl9OWWCOaEs00eUVURDqcO3IRpBH7uhULAGBMFD32FC maL0vEhHnHrVfWGq0mwmjYav5OSf7FSOPvN780O7/zGz3yRv2aXhV5PJOPqAj940z0y+ YQoQSXe7QCIE4NmR0bNglLeyJBk/9i9IIUkKgVNETm4tNcmOqX3ql2QAqDwS+wWloXw3 +nRe62VRPOLqYPvoqLLc8pHr90WgJ07aI9NHBJEFmjp9+9BgltqtYtuSSL8Y7aIQXiwQ 60/zO1TTY6vVrOGwz+I4+rI2N6r85mi5Jptll3dlKwite/uMs5H6dtB5hXK08RJqAeWo 020w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BKXSrxbX; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t20si4902939ejd.719.2020.12.18.09.35.17; Fri, 18 Dec 2020 09:35:17 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BKXSrxbX; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732869AbgLRRe3 (ORCPT + 7 others); Fri, 18 Dec 2020 12:34:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732838AbgLRRe2 (ORCPT ); Fri, 18 Dec 2020 12:34:28 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17644C0610ED for ; Fri, 18 Dec 2020 09:32:48 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id p18so1735407pgm.11 for ; Fri, 18 Dec 2020 09:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vutdwpz2dUDTweVlb30ERc0HCxLnN2+/Hjzz5Y0E1bI=; b=BKXSrxbXnh6d2zRd2aZGKoJTdugQUWnvySJCEm8scXWnxe9+TXu4/81oD7MQ7cAa17 gBO+juB3m0O1fJjMKmtwbmlZgSx+e0JTk0c0HSQxxX0PtJqu1sIPMrzlHOrooOtCcSlV jBWWe3U8wAgF2HAAPUjjDl3dn+tkcgA2TspNkWMz0iMrwWGEqpVYwi9SA/2ycdhEX7EB ZroR/ixb5Fa5kmAWWEgaoiZgosqZ7gUGLmayhcP9HTnP7Q9Xz3hklPJzJNnEk/sy635S mZImmX9q2aaGbnoKtTFr/Lu2XDsdDRBFlAnGqEILryiXq7xAUF5u33LS7NVbe1lAjHJ7 TgaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vutdwpz2dUDTweVlb30ERc0HCxLnN2+/Hjzz5Y0E1bI=; b=oTJoIjPctd8w/oA3smMozIasKmHGeCmgNv3d/OL3lpnzUsLZI8+GACnmg9SJ5yrJEy 38BN04HSwoWWUXTGv3JT25VDPZDwcOK2ukvaFv9dsIUDeauuqDoS7NFnt5/IxBlmlhH9 dFk8U4td6ihkn0nRs1Th34nZltaZNGMMv0PapAZTKDE0vfcb9MbZhOsmFrO6uSnl0876 e7CzZ/lRyglgGOT1bxtDN/kAP/YkP0FRbGqYd5f0Ou+cabGjnL24+WO896WjkSHqVvf8 WgsGhSIok3BQXeRJjk1GR+Uf3OsnXjP4lSfP7UMkXtNj48OeKz9Vz6e+n9nYxkmqv8JK nd9A== X-Gm-Message-State: AOAM532ubhXU2HtotZJhYQgY1W8AcW2reTvMJddjheC/mScabv7K5O/S tMUSXx/erqTyGoI3pZythwKnOg== X-Received: by 2002:a65:4c4b:: with SMTP id l11mr1097792pgr.177.1608312767705; Fri, 18 Dec 2020 09:32:47 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id l11sm9892957pgt.79.2020.12.18.09.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 09:32:46 -0800 (PST) From: Mathieu Poirier To: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: arnaud.pouliquen@st.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 15/17] remoteproc: Properly deal with a start request when attached Date: Fri, 18 Dec 2020 10:32:26 -0700 Message-Id: <20201218173228.2277032-16-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201218173228.2277032-1-mathieu.poirier@linaro.org> References: <20201218173228.2277032-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This patch takes into account scenarios where a remote processor has been attached to when receiving a "start" command from sysfs. As with the "running" case, the command can't be carried out if the remote processor is already in operation. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c | 3 ++- drivers/remoteproc/remoteproc_sysfs.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) -- 2.25.1 diff --git a/drivers/remoteproc/remoteproc_cdev.c b/drivers/remoteproc/remoteproc_cdev.c index d06f8d4919c7..61541bc7d26c 100644 --- a/drivers/remoteproc/remoteproc_cdev.c +++ b/drivers/remoteproc/remoteproc_cdev.c @@ -32,7 +32,8 @@ static ssize_t rproc_cdev_write(struct file *filp, const char __user *buf, size_ return -EFAULT; if (!strncmp(cmd, "start", len)) { - if (rproc->state == RPROC_RUNNING) + if (rproc->state == RPROC_RUNNING || + rproc->state == RPROC_ATTACHED) return -EBUSY; ret = rproc_boot(rproc); diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 96751c087585..298052c9d068 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b/drivers/remoteproc/remoteproc_sysfs.c @@ -223,7 +223,8 @@ static ssize_t state_store(struct device *dev, int ret = 0; if (sysfs_streq(buf, "start")) { - if (rproc->state == RPROC_RUNNING) + if (rproc->state == RPROC_RUNNING || + rproc->state == RPROC_ATTACHED) return -EBUSY; ret = rproc_boot(rproc);