From patchwork Fri Dec 18 17:32:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 345478 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp2335709jai; Fri, 18 Dec 2020 09:35:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJyd5sLTRN9IzPkhnp5bzX6hr4fBVysZx7Nc/wySKU2Y3QoPbSVhqthrPxSV/XzBSOAyMSWc X-Received: by 2002:aa7:d6d8:: with SMTP id x24mr5550228edr.105.1608312920328; Fri, 18 Dec 2020 09:35:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608312920; cv=none; d=google.com; s=arc-20160816; b=Epa69yFmARYBbEhiDZ3sE8F4SP0lE/TRf99ajua7JYPofoESITa6cDC1SLRDcbBWXp q03wKzAHIGdZoyulW5xm8LISx19IsIsWaUxMsuwO5wZ6GaY2aXhYxX6Z0GoBtbomKqwb 9EQES2DaCS4jRr8ylVg3T6WiAmoYkSz94OLty7ZUYUD0VzIUuit9evjpH/UblyFp20lf BFn02veRscYt7AyA9b66JLvlgITjAjjyXeJ1OIyHtQHYwY1h3DbFGptYIdSyRWRdM7sy zvCrqGgAm8qOW9UNQ9scxzh+lZ0JzqJ1jIchpkuVOM0k6XuVzsa0rVvZ47p34koFmc5w HZtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=r4WpCps/dmzg/nEPpmlNW78KzWKD4Zyq8EXXFVytS5s=; b=sddFLhF459+YMEXi5tP2cSJ2Hu3HDNLrk0W/3mI8uO35r49BtEuNke4ya8AIVNtiIZ W5AVS1FZDsu+fJDXalUDLmT40rrf6ez75n1UbFJYDKhaSZQiz3kxvMWyHH5T4jBnE73n 9lOXSitpEJtiQqKZ5OMUXsBm4BkdhwT6JafzuXRPAn75vh+gQpELed/ujcoox6v04o+c o/LJ+LTx2djEwB2HFd/gUj5if2hw41TZ+sDhcpsTRRYw14AfOZkS05i4Vdx2Dqm+Zzmw t7N7t+oBFbLIphichDhbAlj/gVVxVUigd3MuWWPKNrYYbt3GH8C2jE7U4OLrG58a+JjC AJmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qmmI9vTp; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t20si4902939ejd.719.2020.12.18.09.35.19; Fri, 18 Dec 2020 09:35:20 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qmmI9vTp; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726570AbgLRRei (ORCPT + 7 others); Fri, 18 Dec 2020 12:34:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732901AbgLRReh (ORCPT ); Fri, 18 Dec 2020 12:34:37 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 448E3C0610F2 for ; Fri, 18 Dec 2020 09:32:49 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id w6so1961434pfu.1 for ; Fri, 18 Dec 2020 09:32:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r4WpCps/dmzg/nEPpmlNW78KzWKD4Zyq8EXXFVytS5s=; b=qmmI9vTp0A2LE/Vso7i2ivHcoYnFAy8QizlK1mNtLII2LdbDpKQg5kY27MrV9Ls3/Y JyNb4oQdv0aiQJnfE7G98FhNqpRsASuQI4IUzozKulAKGc6DiVsC3QuqAAW5MXtF10AJ WCvAlTsla+IZKPRiE6zc4BtjDc+6oag1IFC/7zvuQixp0Mbed8knKsbd8iD0Lio97L1E b5jyOCsr9zHZakNUZPDatWU+lKkkv8Vtojlt04oZy+yT40wy9jLIV73vRf8G9GiNwIwJ JZcIZjeywEqZ3Rchhzf43yBx8HFDCqgL61qhetW/1KdZGja12BnDKd5GQuqzXo23D5/g rAlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r4WpCps/dmzg/nEPpmlNW78KzWKD4Zyq8EXXFVytS5s=; b=RMkOjQ+7gRiCqB/HJUHlDMYrYlf4WCwy+lPzXV7QmDCyDj7JFHfLYg6+18izsiKjnL M1Io0kvFz7SYSfqyJF4nly2Ez3Z2XEe2OD9qr+5DZ2jdN4+zmmf8G17zbxNVeIbxU0uV Hnm1YXejb+KWwNnJpLl35mFs/zno+svllyalUE2Rwpi0ciWWj6niy+hCjE7nnCwpFlic JupKsiJx+C7btEhMUYmhPVl9wkzXH00bHn6c8gJ3Usnb95XyyT7rIGIWJi27KAfqn05h lB0frYS4Al7U+Nb6HNqYPRkcJEMnUwmARKBYb0sutMNCND1+j5wfg+jSzSBiW/FMtqvQ pTGw== X-Gm-Message-State: AOAM5319jcsBkP6XpeXvSEMT2VP9jcmDV42wzq/Gg6nWur3sOldc+LQQ uV4ewkPgQe266Bjy+yM9Mylfig== X-Received: by 2002:a63:5c18:: with SMTP id q24mr5026246pgb.411.1608312768810; Fri, 18 Dec 2020 09:32:48 -0800 (PST) Received: from xps15.cg.shawcable.net (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id l11sm9892957pgt.79.2020.12.18.09.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 09:32:48 -0800 (PST) From: Mathieu Poirier To: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: arnaud.pouliquen@st.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 16/17] remoteproc: Properly deal with detach request Date: Fri, 18 Dec 2020 10:32:27 -0700 Message-Id: <20201218173228.2277032-17-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201218173228.2277032-1-mathieu.poirier@linaro.org> References: <20201218173228.2277032-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This patch introduces the capability to detach a remote processor that has been attached to or booted by the remoteproc core. For that to happen a rproc::ops::detach() operation need to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c | 6 ++++++ drivers/remoteproc/remoteproc_sysfs.c | 6 ++++++ 2 files changed, 12 insertions(+) -- 2.25.1 diff --git a/drivers/remoteproc/remoteproc_cdev.c b/drivers/remoteproc/remoteproc_cdev.c index 61541bc7d26c..f7645f289563 100644 --- a/drivers/remoteproc/remoteproc_cdev.c +++ b/drivers/remoteproc/remoteproc_cdev.c @@ -43,6 +43,12 @@ static ssize_t rproc_cdev_write(struct file *filp, const char __user *buf, size_ return -EINVAL; ret = rproc_shutdown(rproc); + } else if (!strncmp(cmd, "detach", len)) { + if (rproc->state != RPROC_RUNNING && + rproc->state != RPROC_ATTACHED) + return -EINVAL; + + ret = rproc_detach(rproc); } else { dev_err(&rproc->dev, "Unrecognized option\n"); ret = -EINVAL; diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 298052c9d068..ea7b067fe89a 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b/drivers/remoteproc/remoteproc_sysfs.c @@ -236,6 +236,12 @@ static ssize_t state_store(struct device *dev, return -EINVAL; ret = rproc_shutdown(rproc); + } else if (sysfs_streq(buf, "detach")) { + if (rproc->state != RPROC_RUNNING && + rproc->state != RPROC_ATTACHED) + return -EINVAL; + + ret = rproc_detach(rproc); } else { dev_err(&rproc->dev, "Unrecognised option: %s\n", buf); ret = -EINVAL;