diff mbox series

[2/3] arm64: dts: imx8mq-librem5-r3: Mark buck3 as always on

Message ID 20210311120259.3310499-3-martin.kepplinger@puri.sm
State Superseded
Headers show
Series Librem 5 phone dts fixes | expand

Commit Message

Martin Kepplinger March 11, 2021, 12:02 p.m. UTC
From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

Commit 66d3f246d79f ("arm64: dts: librem5: Don't mark buck3 as always on")
removed always-on marking from GPU regulator, which is great for power
saving - however it introduces additional i2c0 traffic which can be deadly
for devices from the Dogwood batch.

To workaround the i2c0 shutdown issue on Dogwood, this commit marks
buck3 as always-on again - but only for Dogwood (r3).

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Shawn Guo March 15, 2021, 7:24 a.m. UTC | #1
On Thu, Mar 11, 2021 at 01:02:58PM +0100, Martin Kepplinger wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

> 

> Commit 66d3f246d79f ("arm64: dts: librem5: Don't mark buck3 as always on")


I cannot find this commit.

Shawn

> removed always-on marking from GPU regulator, which is great for power

> saving - however it introduces additional i2c0 traffic which can be deadly

> for devices from the Dogwood batch.

> 

> To workaround the i2c0 shutdown issue on Dogwood, this commit marks

> buck3 as always-on again - but only for Dogwood (r3).

> 

> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

> ---

>  arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts | 4 ++++

>  1 file changed, 4 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts

> index 0d38327043f8..cd3c3edd48fa 100644

> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts

> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts

> @@ -28,6 +28,10 @@ &bq25895 {

>  	ti,termination-current = <144000>;  /* uA */

>  };

>  

> +&buck3_reg {

> +	regulator-always-on;

> +};

> +

>  &proximity {

>  	proximity-near-level = <25>;

>  };

> -- 

> 2.30.1

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
index 0d38327043f8..cd3c3edd48fa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dts
@@ -28,6 +28,10 @@  &bq25895 {
 	ti,termination-current = <144000>;  /* uA */
 };
 
+&buck3_reg {
+	regulator-always-on;
+};
+
 &proximity {
 	proximity-near-level = <25>;
 };