| Message ID | 20210322144848.1065067-11-geert@linux-m68k.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | auxdisplay: ht16k33: Add character display support | expand |
On 2021-03-22 15:48, Geert Uytterhoeven wrote: > There is no need to check the return code of input_register_device(), > just propagate it to the caller. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/auxdisplay/ht16k33.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/auxdisplay/ht16k33.c > b/drivers/auxdisplay/ht16k33.c > index 6d39f12054618fa5..13d18f218b4d196e 100644 > --- a/drivers/auxdisplay/ht16k33.c > +++ b/drivers/auxdisplay/ht16k33.c > @@ -378,11 +378,7 @@ static int ht16k33_keypad_probe(struct i2c_client > *client, > > ht16k33_keypad_stop(keypad->dev); > > - err = input_register_device(keypad->dev); > - if (err) > - return err; > - > - return 0; > + return input_register_device(keypad->dev); > } > > static int ht16k33_probe(struct i2c_client *client, Acked-by: Robin van der Gracht <robin@protonic.nl>
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c index 6d39f12054618fa5..13d18f218b4d196e 100644 --- a/drivers/auxdisplay/ht16k33.c +++ b/drivers/auxdisplay/ht16k33.c @@ -378,11 +378,7 @@ static int ht16k33_keypad_probe(struct i2c_client *client, ht16k33_keypad_stop(keypad->dev); - err = input_register_device(keypad->dev); - if (err) - return err; - - return 0; + return input_register_device(keypad->dev); } static int ht16k33_probe(struct i2c_client *client,
There is no need to check the return code of input_register_device(), just propagate it to the caller. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/auxdisplay/ht16k33.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)