diff mbox series

[V3,net-next,1/4] dt-bindings: net: add dt binding for realtek rtl82xx phy

Message ID 20210608031535.3651-2-qiangqing.zhang@nxp.com
State Superseded
Headers show
Series net: phy: add dt property for realtek phy | expand

Commit Message

Joakim Zhang June 8, 2021, 3:15 a.m. UTC
Add binding for realtek rtl82xx phy.

Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
---
 .../bindings/net/realtek,rtl82xx.yaml         | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml

Comments

Rob Herring (Arm) June 10, 2021, 2:54 a.m. UTC | #1
On Tue, Jun 08, 2021 at 11:15:32AM +0800, Joakim Zhang wrote:
> Add binding for realtek rtl82xx phy.

> 

> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>

> ---

>  .../bindings/net/realtek,rtl82xx.yaml         | 45 +++++++++++++++++++

>  1 file changed, 45 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml

> 

> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml

> new file mode 100644

> index 000000000000..bb94a2388520

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml

> @@ -0,0 +1,45 @@

> +# SPDX-License-Identifier: GPL-2.0+

> +%YAML 1.2

> +---

> +$id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#

> +$schema: http://devicetree.org/meta-schemas/core.yaml#

> +

> +title: Realtek RTL82xx PHY

> +

> +maintainers:

> +  - Andrew Lunn <andrew@lunn.ch>

> +  - Florian Fainelli <f.fainelli@gmail.com>

> +  - Heiner Kallweit <hkallweit1@gmail.com>

> +

> +description:

> +  Bindings for Realtek RTL82xx PHYs

> +

> +allOf:

> +  - $ref: ethernet-phy.yaml#

> +

> +properties:

> +  realtek,clkout-disable:

> +    type: boolean

> +    description:

> +      Disable CLKOUT clock, CLKOUT clock default is enabled after hardware reset.

> +

> +


Extra blank line.

> +  realtek,aldps-enable:

> +    type: boolean

> +    description:

> +      Enable ALDPS mode, ALDPS mode default is disabled after hardware reset.

> +

> +unevaluatedProperties: false

> +

> +examples:

> +  - |

> +    mdio {

> +        #address-cells = <1>;

> +        #size-cells = <0>;

> +

> +        ethphy1: ethernet-phy@1 {

> +                reg = <1>;

> +                realtek,clkout-disable;

> +                realtek,aldps-enable;


The schema here will never be applied because there is nothing to match 
on to determine which nodes it is valid. This should have a compatible 
(because ethernet phys are not special).

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
new file mode 100644
index 000000000000..bb94a2388520
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
@@ -0,0 +1,45 @@ 
+# SPDX-License-Identifier: GPL-2.0+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/realtek,rtl82xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek RTL82xx PHY
+
+maintainers:
+  - Andrew Lunn <andrew@lunn.ch>
+  - Florian Fainelli <f.fainelli@gmail.com>
+  - Heiner Kallweit <hkallweit1@gmail.com>
+
+description:
+  Bindings for Realtek RTL82xx PHYs
+
+allOf:
+  - $ref: ethernet-phy.yaml#
+
+properties:
+  realtek,clkout-disable:
+    type: boolean
+    description:
+      Disable CLKOUT clock, CLKOUT clock default is enabled after hardware reset.
+
+
+  realtek,aldps-enable:
+    type: boolean
+    description:
+      Enable ALDPS mode, ALDPS mode default is disabled after hardware reset.
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    mdio {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethphy1: ethernet-phy@1 {
+                reg = <1>;
+                realtek,clkout-disable;
+                realtek,aldps-enable;
+        };
+    };