| Message ID | 20210701105730.322718-10-angelogioacchino.delregno@somainline.org |
|---|---|
| State | New |
| Headers | show |
| Series | cpufreq-qcom-hw: Implement full OSM programming | expand |
On Thu, Jul 01, 2021 at 12:57:30PM +0200, AngeloGioacchino Del Regno wrote: > The property reg-names is required after the addition of the OSM > programming sequence, as that mandates specifying different register > domains; to avoid confusion and improve devicetree readability, > specifying the regions names was made mandatory. Can't take patches missing a S-o-b. Making existing properties required breaks compatibility. That's okay on *all* the platforms using this? If so, that needs to be crystal clear in the commit msg. > --- > Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml > index 29b663321a0b..17fd6a6cefb0 100644 > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml > @@ -98,6 +98,7 @@ else: > required: > - compatible > - reg > + - reg-names > - clocks > - clock-names > - '#freq-domain-cells' > -- > 2.32.0 > >
Il 14/07/21 00:42, Rob Herring ha scritto: > On Thu, Jul 01, 2021 at 12:57:30PM +0200, AngeloGioacchino Del Regno wrote: >> The property reg-names is required after the addition of the OSM >> programming sequence, as that mandates specifying different register >> domains; to avoid confusion and improve devicetree readability, >> specifying the regions names was made mandatory. > > Can't take patches missing a S-o-b. > Sorry again. Didn't notice at all. > Making existing properties required breaks compatibility. That's okay on > *all* the platforms using this? If so, that needs to be crystal clear in > the commit msg. > Yes that's just fine on all platforms using this. In any case, they all do have the reg-names specified in their DT, even if previously not required, so there's nothing to update, even. I will make it crystal clear in the commit message in the next version. >> --- >> Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml >> index 29b663321a0b..17fd6a6cefb0 100644 >> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml >> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml >> @@ -98,6 +98,7 @@ else: >> required: >> - compatible >> - reg >> + - reg-names >> - clocks >> - clock-names >> - '#freq-domain-cells' >> -- >> 2.32.0 >> >>
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml index 29b663321a0b..17fd6a6cefb0 100644 --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml @@ -98,6 +98,7 @@ else: required: - compatible - reg + - reg-names - clocks - clock-names - '#freq-domain-cells'