From patchwork Mon Aug 29 16:49:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 601264 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CA1ECAAD2 for ; Mon, 29 Aug 2022 16:50:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230150AbiH2Qup (ORCPT ); Mon, 29 Aug 2022 12:50:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbiH2QuY (ORCPT ); Mon, 29 Aug 2022 12:50:24 -0400 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 241CB642E9 for ; Mon, 29 Aug 2022 09:50:22 -0700 (PDT) Received: by mail-pj1-x102f.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so4857669pjq.3 for ; Mon, 29 Aug 2022 09:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=BxQqHwLkPhmUcTslqYQ4b+VZsZjUArhc5KFTdI1uAuI=; b=Ob+7ECVRm7EAiRAnh+Y3EbOAI8asNMEM3zSNO6pqaOBlJiPuCHlkrookGt6fH8yyOU X+b41ysdhe95Iz/43v9UgBXQ+tLzdmdr946ej23XF5IWlb0pA4q1QaMiTqUytYadv7nY Akv05QtST0xdSFbA5NoyPApWyz5QvdvqrjT5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=BxQqHwLkPhmUcTslqYQ4b+VZsZjUArhc5KFTdI1uAuI=; b=l3ubmH7StGREpshIIWqyv2iXSDYawBnuoAJ9ldH13zgfYrIfULxlOUFgTchpm+14d7 23fytB+ra2J6VPDEOrrCnktu+3zahKtJsNU0q9JzPbvQjM5jmV1WanaIiyNiOtedTwZQ uwh08VJ/Fp8Ejy5WlLXIhj73cXVHWNHTw5fBUt23jWRboJ4DkikK8lRBAuU6W2zZ1Cz/ TLKCH1DZf9NpLhyW1CXMu9n48XLssWeSiiNAydutwICYMjPrqN4ldfIiPzjEUj14rdaM 1t87YWhMPFCjsk6eNCgUaDAt+rOqju31f4MqmUjY1fZcFL6gRmFgYB/QsprHppck9ixD Lfpg== X-Gm-Message-State: ACgBeo17JdhfGuwGBttl+zITQVC5WuwYBgW6W5nmyEsAFj946OI6kmnt pZn1PHY47GMtaqaN278zvoOdnQ== X-Google-Smtp-Source: AA6agR6mqfgmUmDi33l0/vpHcAlm37qsOHl0kd3HkZrS6xj+iK15kNMJZoQzwiWseZblLmw+xa75Iw== X-Received: by 2002:a17:90a:b00f:b0:1f7:67c6:5df5 with SMTP id x15-20020a17090ab00f00b001f767c65df5mr18916536pjq.59.1661791821821; Mon, 29 Aug 2022 09:50:21 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:21 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] arm64: dts: qcom: sm8150-xperia-kumano: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:50 -0700 Message-Id: <20220829094903.v2.4.I51d60414a42ba9e3008e208d60a04c9ffc425fa7@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid Fixes: d0a6ce59ea4e ("arm64: dts: qcom: sm8150: Add support for SONY Xperia 1 / 5 (Kumano platform)") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi index 014fe3a31548..fb6e5a140c9f 100644 --- a/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi @@ -348,6 +348,9 @@ vreg_l6c_2p9: ldo6 { regulator-max-microvolt = <2960000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l7c_3p0: ldo7 { @@ -367,6 +370,9 @@ vreg_l9c_2p9: ldo9 { regulator-max-microvolt = <2960000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l10c_3p3: ldo10 {