From patchwork Mon Aug 29 16:49:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 600921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D88ECAAD5 for ; Mon, 29 Aug 2022 16:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229552AbiH2Qux (ORCPT ); Mon, 29 Aug 2022 12:50:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbiH2Quo (ORCPT ); Mon, 29 Aug 2022 12:50:44 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EF037393D for ; Mon, 29 Aug 2022 09:50:24 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id l3so8556243plb.10 for ; Mon, 29 Aug 2022 09:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=nhn/w5h2jny0OsR9Iya6bJX/FfXt3qTgdH67oe8iCrw=; b=Xe1e4Nq/i7gkbY3ptMSC/LQQ9HFvyzIIhZ0blm+9Dy5QvOULptYN2Bx5jQRfGGudbK 5jtt/GZy1OMN3NnY6PEQiMS2DBMOX3xv908rYMbgS/+QJD2gpizWJDeLN6ChkjxhPBNe e7J0NDRd7U96dHg8vsXWZgsLhsWF/m4lgHyfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=nhn/w5h2jny0OsR9Iya6bJX/FfXt3qTgdH67oe8iCrw=; b=YV9ZCh47AOiSzVmZmWyuN8A2Vvd6U/SfISdYVZaC6Vgf9KmJiyp8rCsab/ksvKeJHn PjEqtMU7+LNMkPM+7RkrUBdnQZGsrM8VtVRoCU6AEHbfL5AcUu6mHc99yH1x782JD2Zd reyngY58Et+BBnGlQWQuK6fMGnViw+UHSzKBpM84AcJkOCXU3Prib63qBRwXnfnNGh0p b4kNPBhzVdtRc6+kb5uO1FdrnTUE+BBhhojBhJAWmB4C4DKqjM8hzhMQ4hA2D/TJ7zro oYSMkigBAK4c8wK2sqlC76fNnoJzzHK+ZiVtUbadTV87WYmqcBoK+xlBs4JHymm0bCjg KHaw== X-Gm-Message-State: ACgBeo3FGC8lcmOSzkIXrjxOGzifIWaS2j3HeLfP2hTis9G0yAdcPKcM 3uMSjmgzwR8VQBjdc3bKdM8Qew== X-Google-Smtp-Source: AA6agR69yrznAbc4gS1Ofi8dCrVzKMw/LDZ6plYxItqYU0dO2S2KPp/NgysrQjGpbzqjpYnTt7kkpQ== X-Received: by 2002:a17:90a:cf01:b0:1fd:5bed:bf55 with SMTP id h1-20020a17090acf0100b001fd5bedbf55mr18532160pju.14.1661791823525; Mon, 29 Aug 2022 09:50:23 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:23 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Konrad Dybcio , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] arm64: dts: qcom: sm8250-xperia-edo: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:51 -0700 Message-Id: <20220829094903.v2.5.Ie446d5183d8b1e9ec4e32228ca300e604e3315eb@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid Fixes: 69cdb97ef652 ("arm64: dts: qcom: sm8250: Add support for SONY Xperia 1 II / 5 II (Edo platform)") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi index 549e0a2aa9fe..5428aab3058d 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi @@ -317,6 +317,9 @@ vreg_l6c_2p9: ldo6 { regulator-max-microvolt = <2960000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l7c_2p85: ldo7 { @@ -339,6 +342,9 @@ vreg_l9c_2p9: ldo9 { regulator-max-microvolt = <2960000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l10c_3p3: ldo10 {