From patchwork Mon Aug 29 16:49:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 601263 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7E9C0502C for ; Mon, 29 Aug 2022 16:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230386AbiH2Quy (ORCPT ); Mon, 29 Aug 2022 12:50:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbiH2Quq (ORCPT ); Mon, 29 Aug 2022 12:50:46 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEDF77AC2D for ; Mon, 29 Aug 2022 09:50:26 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id y141so8759496pfb.7 for ; Mon, 29 Aug 2022 09:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=woneQpwMOMgIO7e0hCdrCZoj4JrbV7vkhMtZpv1/ep8=; b=kmSDFY9nq5Z5Qb5YraZhZdKCocvVR+dWWSurViHAeY24Ijr3xQyq61FPn2WNDBleHT iiG4iERxcptn2BsoT3XiLjGtMjivx/5G9UueB3ywrsSXZxfv5ftP1eSjabPgj4NKMXrh qt8vfKX4rym2utpsMZdYtSymG8SUSMgUAjjAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=woneQpwMOMgIO7e0hCdrCZoj4JrbV7vkhMtZpv1/ep8=; b=avmmV6Bsuh2cM0mI9QAF0RN2WWbHAtKEzOz5nLptNCR5+xTT34JIf0NdE8UmNiWEVv ptgd14kpmshQ9NRHJvfmHHQsbya8dKV8REgy4hRxI+zBoualDC/nuFkp9ckd3KC4lCDx BtduYasMjFoZQ9FAKN0O8PKLtSsjzh0Fg0Df/0wa52q9m47Yy3YTkf49Z105paLCuRPU 380RY4aRy9aZpUQa4KS/OVeJPXjUOxQqaFmhaLzOmNqQY9u+M80J49QzPYNIyx03PTiX mGa3UmKr4BLxON/swQtIqtynkMRqWTtGyRihTUara9f3D2mfN25UkQ8G2MQ060WFFNWv 0w2g== X-Gm-Message-State: ACgBeo30S/GRmdgldOSuATtHxKzWpSfZh2ipv2WcCFUi0qlLwTrQL4SP km3N+cIfd4TqLw4E71jSOvVGNg== X-Google-Smtp-Source: AA6agR4VOEmzb8h688Hlh10n5OC2JGl7tx4FZ9QIiaFqDYhrKJQYQ0M7KGv2bhGU1bVC3w2/4zclgw== X-Received: by 2002:a63:6a46:0:b0:41a:3e67:67cd with SMTP id f67-20020a636a46000000b0041a3e6767cdmr14844814pgc.94.1661791825380; Mon, 29 Aug 2022 09:50:25 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:3a97:5017:7e33:8964]) by smtp.gmail.com with ESMTPSA id l1-20020a170902f68100b001729db603bcsm7864238plg.126.2022.08.29.09.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 09:50:24 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson Cc: Johan Hovold , Andrew Halaney , Mark Brown , Douglas Anderson , Vinod Koul , Konrad Dybcio , Andy Gross , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] arm64: dts: qcom: sm8350-hdk: Specify which LDO modes are allowed Date: Mon, 29 Aug 2022 09:49:52 -0700 Message-Id: <20220829094903.v2.6.I6799be85cf36d3b494f803cba767a569080624f5@changeid> X-Mailer: git-send-email 2.37.2.672.g94769d06f0-goog In-Reply-To: <20220829164952.2672848-1-dianders@chromium.org> References: <20220829164952.2672848-1-dianders@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, but doesn't specify any modes with "regulator-allowed-modes". Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement get_optimum_mode(), not set_load()") the above meant that we were able to set either LPM or HPM mode. After that commit (and fixes [1]) we'll be stuck at the initial mode. Discussion of this has resulted in the decision that the old dts files were wrong and should be fixed to fully restore old functionality. Let's re-enable the old functionality by fixing the dts. [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid Fixes: 9208c19f2124 ("arm64: dts: qcom: Introduce SM8350 HDK") Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney Reviewed-by: Vinod Koul Reviewed-by: Konrad Dybcio --- (no changes since v1) arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts index 0fcf5bd88fc7..69ae6503c2f6 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts @@ -107,6 +107,9 @@ vreg_l5b_0p88: ldo5 { regulator-max-microvolt = <888000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l6b_1p2: ldo6 { @@ -115,6 +118,9 @@ vreg_l6b_1p2: ldo6 { regulator-max-microvolt = <1208000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l7b_2p96: ldo7 { @@ -123,6 +129,9 @@ vreg_l7b_2p96: ldo7 { regulator-max-microvolt = <2504000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; vreg_l9b_1p2: ldo9 { @@ -131,6 +140,9 @@ vreg_l9b_1p2: ldo9 { regulator-max-microvolt = <1200000>; regulator-initial-mode = ; regulator-allow-set-load; + regulator-allowed-modes = + ; }; };