From patchwork Mon Sep 12 06:17:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 605562 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3382ECAAA1 for ; Mon, 12 Sep 2022 06:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbiILGUG (ORCPT ); Mon, 12 Sep 2022 02:20:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbiILGTN (ORCPT ); Mon, 12 Sep 2022 02:19:13 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20D3629C83 for ; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id o2so10987079lfc.10 for ; Sun, 11 Sep 2022 23:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Ix0v/JGnTNkLvR8lnkw4PxO4vTS1Ezmp9TWJ/ylE0lI=; b=RNq2Ay6bofF8EtTn8Aa6fJHXRwtjlaMMQP08M8V+KUrrsyuwbPrNA3XJoxh11yduDU XhOblk3H0YAT/Zaz5e79wMpWLiu64N/MAu1+ByC8ua/LVZgEJzpmQIBVPOMSfff4ZdqF 6NK0B9QpibR84J4dKgbVO07aSpU6jiDS5nPK0BcGUWx/13GHjdssakEgGl008YY8px49 gSUzr0CT98FvcWtoo+NxcOeELtPGmWJtmNsdxlbC684gzYiKKnMMx4mqVL7TTkqpggnN Gsty06IMrt9PG2HOPz2JL5dBVFxW0XKidF/t+Zo1dw9PlC5SkTMTsXni9cCMSOpHua8A 76aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Ix0v/JGnTNkLvR8lnkw4PxO4vTS1Ezmp9TWJ/ylE0lI=; b=br/Gi5l9nUKfXmxtGjmkgJm2l5g7tFobOoQFSDzBdMKlJWBfZeoulHQBjt/igAG3ju Vp/iPEdgvGjOjQTJoF/J2RFMTkmQwRtLygpei2Gq5PyOUeqwHLIkizQX47veOn6x18Dl cnGZ7ZX1G00M68Vc6xlb7XPG2xz5xEY2fvdO++/VhFvo8eMaTebqpyyk7f/WnASPxj3j BjfLqs0c6VtzneoZKMpa4qzT8KunTPkzzVPbjHiHbNtdnWawSOhAvU3PyJ/CLLZTIHKD s1eaEj2pEZN6yKclsKjiuEKa1RdzEK4FhbYrvOrrUHvVkIX2hNjnV5zJzcNpvvWjF2Sc OZqg== X-Gm-Message-State: ACgBeo0MMT5xNj0+Efve8VqD0+ecpYEwMNcEDjrRFmy5vfQelKSrVqY9 07LhTBj2bDt5JjpJqevxdlR6zw== X-Google-Smtp-Source: AA6agR7oxSPmPzWcJYkvHhpvvohJVKs8ewnvLe9zcbvmo5ONG+O/0LmLLaQElLINXty+TqmeG/Q1bw== X-Received: by 2002:a05:6512:118b:b0:492:e3c4:a164 with SMTP id g11-20020a056512118b00b00492e3c4a164mr9200538lfr.598.1662963494177; Sun, 11 Sep 2022 23:18:14 -0700 (PDT) Received: from krzk-bin.. (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id t19-20020ac24c13000000b004996fbfd75esm876805lfq.71.2022.09.11.23.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 23:18:13 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 16/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config Date: Mon, 12 Sep 2022 08:17:22 +0200 Message-Id: <20220912061746.6311-17-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Matching PMIC GPIOs config nodes within a '-state' node by '.*' pattern does not work as expected because of linux,phandle in the DTB: sm8350-hdk.dtb: pinctrl@f100000: qup-uart3-default-state: 'oneOf' conditional failed, one must be fixed: 'pins' is a required property 'function' is a required property 'rx', 'tx' do not match any of the regexes: 'pinctrl-[0-9]+' [[59]] is not of type 'object' Make the schema stricter and expect such nodes to be followed with a '-pins' suffix. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml index 6b7789db2f75..211cca11f94f 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-pinctrl.yaml @@ -44,8 +44,9 @@ patternProperties: oneOf: - $ref: "#/$defs/qcom-sm8350-tlmm-state" - patternProperties: - ".*": + "-pins$": $ref: "#/$defs/qcom-sm8350-tlmm-state" + additionalProperties: false $defs: qcom-sm8350-tlmm-state: @@ -130,13 +131,13 @@ examples: }; uart-w-subnodes-state { - rx { + rx-pins { pins = "gpio18"; function = "qup3"; bias-pull-up; }; - tx { + tx-pins { pins = "gpio19"; function = "qup3"; bias-disable;