diff mbox series

[1/2] arm64: dts: tegra: smaug: add GPU power rail regulator

Message ID 20230511083101.78516-2-diogo.ivo@tecnico.ulisboa.pt
State Superseded
Headers show
Series Enable GPU on Smaug | expand

Commit Message

Diogo Ivo May 11, 2023, 8:31 a.m. UTC
Add the GPU power rail regulator node for the Pixel C.

Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Krzysztof Kozlowski May 11, 2023, 9:02 a.m. UTC | #1
On 11/05/2023 10:31, Diogo Ivo wrote:
> Add the GPU power rail regulator node for the Pixel C.
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
> ---
>  arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> index e55bff859692..8973fcf1e219 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
> @@ -1406,6 +1406,23 @@ max77621_cpu: max77621@1b {
>  			maxim,externally-enable;
>  		};
>  
> +		max77621_gpu: max77621@1c {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +			compatible = "maxim,max77621";
> +			reg = <0x1c>;
> +			interrupt-parent = <&gpio>;
> +			interrupts = <TEGRA_GPIO(A, 6) IRQ_TYPE_LEVEL_LOW>;
> +			regulator-min-microvolt = <840000>;
> +			regulator-max-microvolt = <1150000>;
> +			regulator-name = "PPVAR_GPU";
> +			regulator-ramp-delay = <12500>;
> +			maxim,dvs-default-state = <1>;
> +			maxim,enable-active-discharge;
> +			maxim,enable-bias-control;
> +			maxim,disable-etr;
> +			maxim,enable-gpio = <&pmic 6 0>;

Use defines for GPIO flags.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index e55bff859692..8973fcf1e219 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -1406,6 +1406,23 @@  max77621_cpu: max77621@1b {
 			maxim,externally-enable;
 		};
 
+		max77621_gpu: max77621@1c {
+			compatible = "maxim,max77621";
+			reg = <0x1c>;
+			interrupt-parent = <&gpio>;
+			interrupts = <TEGRA_GPIO(A, 6) IRQ_TYPE_LEVEL_LOW>;
+			regulator-min-microvolt = <840000>;
+			regulator-max-microvolt = <1150000>;
+			regulator-name = "PPVAR_GPU";
+			regulator-ramp-delay = <12500>;
+			maxim,dvs-default-state = <1>;
+			maxim,enable-active-discharge;
+			maxim,enable-bias-control;
+			maxim,disable-etr;
+			maxim,enable-gpio = <&pmic 6 0>;
+			maxim,externally-enable;
+		};
+
 		pmic: pmic@3c {
 			compatible = "maxim,max77620";
 			reg = <0x3c>;