From patchwork Tue May 30 17:29:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 687039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5A3C7EE24 for ; Tue, 30 May 2023 17:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233477AbjE3RbF (ORCPT ); Tue, 30 May 2023 13:31:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233407AbjE3RbB (ORCPT ); Tue, 30 May 2023 13:31:01 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE517C5 for ; Tue, 30 May 2023 10:30:45 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-30ad99fa586so4549881f8f.2 for ; Tue, 30 May 2023 10:30:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1685467844; x=1688059844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s0RVCChZrw1HM9gOYT9R7Dq9M2JqYnSrsD9fDiYXZqw=; b=Mk9j0A28T6ZsD/yDUdYTaasqk+2b7wKUk8E2DlztWHh0RyXRVFPSZD7ZFthFUpAdrG XT7y0PraqOExWZyDr3DW/zW5kv1lZduZS/yWQTcwt4cQuXGneoQCTc5EYZUPD/C9N3MI rQ8qLEbk0YZ/DQcWp9mrTnjHQRAHU6P3f5EFCQQCBownaSvGlzmSc7WxBvb0m9Wh6sO6 /t5/namP+ryoxiOM8VAIZ0qSOS4TG0d9zYoR29nca3R18m/pVoB2tu6337r41oo8hlst rhZa4vvN6M6hD1tiHrFC059RUIwDNRsz8a6AidKnYjJkrWTsOPfCyC9nkmK2y6Lj8AT6 GuyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685467844; x=1688059844; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s0RVCChZrw1HM9gOYT9R7Dq9M2JqYnSrsD9fDiYXZqw=; b=DdHXLKgsu8efWfGMFYmEseesGsnURgeFO6ukcE+K90pDvgetrwu+giuwyNPDStg41C +cLILOrMU5gQu9M6wKGK9etN4jS0BSXo0e9kyDIoetgMpLGHqlioJ/sH3LjQ0gW5Kyrm hLFaY61bF2zWyMisNAs1TX2hU52TqQIf5jVMtgivcCgsI2PpJtxysB2+5ZeAYX0g+s0e YEttpPxtkXNEqMMyNHtFeHm9jn3qkXL2S12KB9LchrP7Okmqbtr2VwLujfSWPyxWZcnY YDAR4z4SZDCyQ9w+LMIGnudsUS4xFQ9xA8f2uiNxlJALm4eLsplToUAD49oREZr+t7V2 6lqw== X-Gm-Message-State: AC+VfDzyeIIUWuuUZglicB0Q6tixAnzWsLTYdouilNa1IkxJvr4+O1q5 shZJReWPMH+fmrvac/hCCk/4iw== X-Google-Smtp-Source: ACHHUZ5Y27ra5AaDsbjy8uc6KnHxbqSIL9rvP8ykCeiZTJYKsmQpxOYMh5RFpxYgewnchbx9vZqxow== X-Received: by 2002:adf:d851:0:b0:304:8147:f0ba with SMTP id k17-20020adfd851000000b003048147f0bamr2494403wrl.3.1685467844357; Tue, 30 May 2023 10:30:44 -0700 (PDT) Received: from dave-Ubuntu2204.pitowers.org ([93.93.133.154]) by smtp.googlemail.com with ESMTPSA id h14-20020a056000000e00b0030ae901bc54sm3964823wrx.62.2023.05.30.10.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 10:30:44 -0700 (PDT) From: Dave Stevenson To: Sakari Ailus , linux-media@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Cc: Dave Stevenson Subject: [PATCH 13/21] media: i2c: imx258: Correct max FRM_LENGTH_LINES value Date: Tue, 30 May 2023 18:29:52 +0100 Message-Id: <20230530173000.3060865-14-dave.stevenson@raspberrypi.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230530173000.3060865-1-dave.stevenson@raspberrypi.com> References: <20230530173000.3060865-1-dave.stevenson@raspberrypi.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The data sheet states that the maximum value for registers 0x0340/0x0341 FRM_LENGTH_LINES is 65525(decimal), not the 0xFFFF defined in this driver. Correct this limit. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi --- drivers/media/i2c/imx258.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index b5c2dcb7c9e6..f5199e3243e8 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -28,7 +28,7 @@ #define IMX258_VTS_30FPS 0x0c50 #define IMX258_VTS_30FPS_2K 0x0638 #define IMX258_VTS_30FPS_VGA 0x034c -#define IMX258_VTS_MAX 0xffff +#define IMX258_VTS_MAX 65525 #define IMX258_REG_VTS 0x0340