| Message ID | 20230602140948.2138668-2-yangcong5@huaqin.corp-partner.google.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add ili9882t timing | expand |
Hi,Krzysztof, Thanks for Krzysztof.Sorry, I didn't run `make dt_binding_check. I will check before sending V2 patch. On Fri, Jun 2, 2023 at 10:19 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 02/06/2023 16:09, Cong Yang wrote: > > Add an ilitek touch screen chip ili9882t. > > > > Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. > > There is no way this would work and if you test you will see error msg. > Feel free to ping if message is unclear. > > > --- > > .../bindings/input/elan,ekth6915.yaml | 36 ++++++++++++++----- > > 1 file changed, 27 insertions(+), 9 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > index 05e6f2df604c..73e94cb6c4e0 100644 > > --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml > > @@ -15,11 +15,15 @@ description: > > > > properties: > > compatible: > > - items: > > - - const: elan,ekth6915 > > + oneOf: > > It's not oneOf. Just enum Done,thanks. > > > + - enum: > > + - elan,ekth6915 > > + - ilitek,ili9882t > > > > reg: > > - const: 0x10 > > + enum: > > + - 0x10 > > + - 0x41 > > > > interrupts: > > maxItems: 1 > > @@ -29,17 +33,31 @@ properties: > > > > vcc33-supply: > > description: The 3.3V supply to the touchscreen. > > + If using ili9882t then this supply will not be needed. > > Are you sure these are compatible devices then? What does it mean "not > needed"? Is the pin there or is not? Yes,ili9882t this touch ic not needed 3.3V supply,this pin does not exist. > > > > > vccio-supply: > > description: > > The IO supply to the touchscreen. Need not be specified if this is the > > same as the 3.3V supply. > > - > > -required: > > - - compatible > > - - reg > > - - interrupts > > - - vcc33-supply > > + If using ili9882t, the IO supply is required. > > + > > + required: > > NAK. Really. Test patches before sending. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml index 05e6f2df604c..73e94cb6c4e0 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -15,11 +15,15 @@ description: properties: compatible: - items: - - const: elan,ekth6915 + oneOf: + - enum: + - elan,ekth6915 + - ilitek,ili9882t reg: - const: 0x10 + enum: + - 0x10 + - 0x41 interrupts: maxItems: 1 @@ -29,17 +33,31 @@ properties: vcc33-supply: description: The 3.3V supply to the touchscreen. + If using ili9882t then this supply will not be needed. vccio-supply: description: The IO supply to the touchscreen. Need not be specified if this is the same as the 3.3V supply. - -required: - - compatible - - reg - - interrupts - - vcc33-supply + If using ili9882t, the IO supply is required. + + required: + - compatible + - reg + - interrupts + - vcc33-supply + +if: + properties: + compatible: + contains: + const: ilitek,ili9882t +then: + required: + - compatible + - reg + - interrupts + - vccio-supply additionalProperties: false
Add an ilitek touch screen chip ili9882t. Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com> --- .../bindings/input/elan,ekth6915.yaml | 36 ++++++++++++++----- 1 file changed, 27 insertions(+), 9 deletions(-)