| Message ID | 20230605153539.497602-3-pavacic.p@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | drm/panel: add fannal c3004 panel | expand |
On 05/06/2023 17:35, Paulo Pavacic wrote: > Added fannal to vendor-prefixes and dt bindings for Fannal C3004. > Fannal C3004 is a 480x800 MIPI DSI Panel which requires > DCS initialization sequences with certain delays between certain > commands. > + #include <dt-bindings/gpio/gpio.h> > + dsi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "fannal,c3004"; > + reg = <0>; > + pinctrl-0 = <&pinctrl_mipi_dsi_rst>; > + pinctrl-names = "default"; > + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; > + vdd-supply = <®1>; > + vddio-supply = <®2>; > + width-mm = <93>; > + height-mm = <56>; > + panel-timing { > + clock-frequency = <27000000>; > + hactive = <480>; > + vactive = <800>; > + hfront-porch = <30>; > + hback-porch = <30>; > + hsync-len = <8>; > + vback-porch = <30>; > + vfront-porch = <30>; > + vsync-len = <8>; > + }; > + }; > + }; Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5c22c828ab46..62374c8424b9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc > F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c > > +DRM DRIVER FOR FANNAL C3004373132019A > +M: Paulo Pavacic <pavacic.p@gmail.com> > +S: Maintained > +C: matrix:r/mipi-dsi-bringup:matrix.org I don't think we have chat channels for individual, small drivers. Add a channel for entire subsystem. Best regards, Krzysztof
On 06/06/2023 11:53, Paulo Pavacic wrote: >>> + #include <dt-bindings/gpio/gpio.h> >>> + dsi { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + panel@0 { >>> + compatible = "fannal,c3004"; >>> + reg = <0>; >>> + pinctrl-0 = <&pinctrl_mipi_dsi_rst>; >>> + pinctrl-names = "default"; >>> + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; >>> + vdd-supply = <®1>; >>> + vddio-supply = <®2>; >>> + width-mm = <93>; >>> + height-mm = <56>; >>> + panel-timing { >>> + clock-frequency = <27000000>; >>> + hactive = <480>; >>> + vactive = <800>; >>> + hfront-porch = <30>; >>> + hback-porch = <30>; >>> + hsync-len = <8>; >>> + vback-porch = <30>; >>> + vfront-porch = <30>; >>> + vsync-len = <8>; >>> + }; >>> + }; >>> + }; >> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> So this you decided to ignore? >> >>> +... >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index 5c22c828ab46..62374c8424b9 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc >>> F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml >>> F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c >>> >>> +DRM DRIVER FOR FANNAL C3004373132019A >>> +M: Paulo Pavacic <pavacic.p@gmail.com> >>> +S: Maintained >>> +C: matrix:r/mipi-dsi-bringup:matrix.org >> >> I don't think we have chat channels for individual, small drivers. Add a >> channel for entire subsystem. > Okay I will add matrix:r/linux-drm:matrix.org I meant, we do not have entries for individual drivers in MAINTAINERS with mailing lists or with chats. The entries covering entire subsystems have such links. We are not going to sign up for 100 different channels, each one per driver. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml new file mode 100644 index 000000000000..bbddb036094b --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/fannal,c3004.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Fannal C3004 MIPI-DSI + +maintainers: + - Paulo Pavacic <pavacic.p@gmail.com> + +description: | + Fannal C3004 is a 480x800 panel which requires DSI DCS + initialization sequences. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - const: fannal,c3004 + + reg: true + + reset-gpios: true + + vdd-supply: + description: power supply voltage + + vddio-supply: + description: power supply voltage for IO + + width-mm: + description: physical panel width [mm] + + height-mm: + description: physical panel height [mm] + + panel-timing: true + +required: + - compatible + - reg + - reset-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "fannal,c3004"; + reg = <0>; + pinctrl-0 = <&pinctrl_mipi_dsi_rst>; + pinctrl-names = "default"; + reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; + vdd-supply = <®1>; + vddio-supply = <®2>; + width-mm = <93>; + height-mm = <56>; + panel-timing { + clock-frequency = <27000000>; + hactive = <480>; + vactive = <800>; + hfront-porch = <30>; + hback-porch = <30>; + hsync-len = <8>; + vback-porch = <30>; + vfront-porch = <30>; + vsync-len = <8>; + }; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 5c22c828ab46..62374c8424b9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6427,6 +6427,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml F: drivers/gpu/drm/panel/panel-ebbg-ft8719.c +DRM DRIVER FOR FANNAL C3004373132019A +M: Paulo Pavacic <pavacic.p@gmail.com> +S: Maintained +C: matrix:r/mipi-dsi-bringup:matrix.org +F: Documentation/devicetree/bindings/display/panel/panel-fannal,c3004.yaml + DRM DRIVER FOR FARADAY TVE200 TV ENCODER M: Linus Walleij <linus.walleij@linaro.org> S: Maintained
Added fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands. Signed-off-by: Paulo Pavacic <pavacic.p@gmail.com> --- v4 changelog: - add spaces between properties v3 changelog: - renamed yml file - refactored yml file to describe fannal,c3004 - added matrix URI to MAINTAINERS v2 changelog: - revised driver title, now describes purpose - revised description, now describes hw - revised maintainers, now has only 1 mail - removed diacritics from commit/commit author - properties/compatible is now enum - compatible using only lowercase - revised dts example - modified MAINTAINERS in this commit (instead of driver commit) - dt_bindings_check checked yml - checkpatch warning fixed --- .../bindings/display/panel/fannal,c3004.yaml | 78 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 84 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/fannal,c3004.yaml