From patchwork Tue Sep 30 14:45:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dann frazier X-Patchwork-Id: 38159 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f197.google.com (mail-we0-f197.google.com [74.125.82.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 581D820549 for ; Tue, 30 Sep 2014 14:45:33 +0000 (UTC) Received: by mail-we0-f197.google.com with SMTP id q58sf2953783wes.0 for ; Tue, 30 Sep 2014 07:45:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=18gI+0qaIB0HvATm6nr4U7wh1zlnA4mji5TvrXpbxAI=; b=itrhq/0QkF2WPMG1io0wVQjnL+IR9i4S393lKRLDVkC7h6VqxlYOjjsECoRPNjV6Rm MR1DVR105Rr0J+QKFE2Sct4AuuKw3mB2fR9Ckc2YEvshu2MvgNerF5B8S+h9vABlx2zZ pSz0t20ZgHD/rgmuML86oP3y2gy3mDrNNxiJl78Z2yFf2pXtJJkIZXDUmu+Q9qMw1dBQ W+qCu1kpdiyFuKbFVvLJp22w+sl+YjaE7MaRsglAlOthqhvjSMrsOYARk1Q6C4pArLOd +QvqeRvPWhudaauMpOOk/brplzkVJeH7txcGCODe3YdE5tSlRtI2yzvF5B36KTIw18+S 63lA== X-Gm-Message-State: ALoCoQnEYZwkMBvpBjepLodUCgWUjcHpfloGUk0PG6yZlcREsArklmg2Sj9tgoT3C2feRHIk/4X8 X-Received: by 10.112.126.228 with SMTP id nb4mr531259lbb.16.1412088332514; Tue, 30 Sep 2014 07:45:32 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.87.193 with SMTP id ba1ls49013lab.16.gmail; Tue, 30 Sep 2014 07:45:32 -0700 (PDT) X-Received: by 10.112.171.229 with SMTP id ax5mr37937181lbc.25.1412088332375; Tue, 30 Sep 2014 07:45:32 -0700 (PDT) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com [209.85.215.53]) by mx.google.com with ESMTPS id f4si23132527laf.32.2014.09.30.07.45.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 30 Sep 2014 07:45:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) client-ip=209.85.215.53; Received: by mail-la0-f53.google.com with SMTP id gq15so2662322lab.12 for ; Tue, 30 Sep 2014 07:45:32 -0700 (PDT) X-Received: by 10.152.204.231 with SMTP id lb7mr47347425lac.44.1412088332252; Tue, 30 Sep 2014 07:45:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp361748lbb; Tue, 30 Sep 2014 07:45:31 -0700 (PDT) X-Received: by 10.66.119.175 with SMTP id kv15mr71078225pab.30.1412088330699; Tue, 30 Sep 2014 07:45:30 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lp3si27025853pab.230.2014.09.30.07.45.30 for ; Tue, 30 Sep 2014 07:45:30 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbaI3OpZ (ORCPT + 5 others); Tue, 30 Sep 2014 10:45:25 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:57015 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbaI3OpV (ORCPT ); Tue, 30 Sep 2014 10:45:21 -0400 Received: by mail-wi0-f175.google.com with SMTP id d1so3591745wiv.2 for ; Tue, 30 Sep 2014 07:45:20 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.194.236.35 with SMTP id ur3mr4256409wjc.127.1412088320374; Tue, 30 Sep 2014 07:45:20 -0700 (PDT) Received: by 10.217.139.135 with HTTP; Tue, 30 Sep 2014 07:45:20 -0700 (PDT) In-Reply-To: <1408778588-3215-4-git-send-email-lho@apm.com> References: <1408778588-3215-1-git-send-email-lho@apm.com> <1408778588-3215-2-git-send-email-lho@apm.com> <1408778588-3215-3-git-send-email-lho@apm.com> <1408778588-3215-4-git-send-email-lho@apm.com> Date: Tue, 30 Sep 2014 08:45:20 -0600 Message-ID: Subject: Re: [PATCH v5 3/4] edac: Add APM X-Gene SoC EDAC driver From: Dann Frazier To: Loc Ho Cc: dougthompson@xmission.com, Borislav Petkov , m.chehab@samsung.com, Rob Herring , Mark Rutland , Ian Campbell , "devicetree@vger.kernel.org" , Feng Kan , Jon Masters , patches@apm.com, linux-arm-kernel , linux-edac@vger.kernel.org, Craig Magina Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: dann.frazier@canonical.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.53 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Sat, Aug 23, 2014 at 1:23 AM, Loc Ho wrote: > This patch adds support for the APM X-Gene SoC EDAC driver. It > requires ARM64 EDAC support patch [1] to compile due to > dependence on MC module which calls an unused software memory > scrub function. > > [1] http://www.spinics.net/lists/arm-kernel/msg324093.html > > Signed-off-by: Feng Kan > Signed-off-by: Loc Ho > --- > drivers/edac/Kconfig | 9 +- > drivers/edac/Makefile | 3 + > drivers/edac/xgene_edac.c | 2132 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 2143 insertions(+), 1 deletions(-) > create mode 100644 drivers/edac/xgene_edac.c > [...] > +#ifdef CONFIG_OF > +static struct of_device_id xgene_edac_mc_of_match[] = { > + { .compatible = "apm,xgene-edac-mc" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, xgene_edac_of_match); > +#endif Something I apparently forgot to mention when I tested v3 was that I had to manually fix this up to get it to build: --- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c index d69c2e5..2f436d45 100644 --- a/drivers/edac/xgene_edac.c +++ b/drivers/edac/xgene_edac.c @@ -452,7 +452,7 @@ static struct of_device_id xgene_edac_mc_of_match[] = { { .compatible = "apm,xgene-edac-mc" }, {}, }; -MODULE_DEVICE_TABLE(of, xgene_edac_of_match); +MODULE_DEVICE_TABLE(of, xgene_edac_mc_of_match); #endif static struct platform_driver xgene_edac_mc_driver = {