From patchwork Sun May 4 09:52:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 887906 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06DDB1A0BF3 for ; Sun, 4 May 2025 09:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746352391; cv=none; b=LS9s0+dQ6Qbryjei5LvxMLLi6XQWU0ufxAxSIgs0WmaD3aVHV8nTvDpnZ/V4HSE+ie7QdB9QXwdYa2GGjKMIRE42mjBAEfMHNLC92e2oSsUK5Lqk+qabaM5s8o7448nTS/ZoC18ag5eMiYk5LOyjiviOtBEK99rGuwB9R8IK2T0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746352391; c=relaxed/simple; bh=B6sTwDf85H/ZctTlQ1ykGUokg6cZvuiTzJxYdCOSrZI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=N9BcenBaZq2/jotlS6USv7Pv+ry3kX5kDhZuZb71PxxdtOn9Uwx9lOiAmWneapYpNXMxXxszZ8m+96QTnw8pAuLuFMa7pgmZmzR7LQldrDZQ43RXHsTvpSxj7LvitKwLtEBaQykfZMcZTcz8WdHHM7jtfECqKhMlxLVnzn33RJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ardb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zAgdVJaY; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ardb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zAgdVJaY" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43d209dc2d3so15355305e9.3 for ; Sun, 04 May 2025 02:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746352388; x=1746957188; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=leD0sWlnnaxAT1Wn0YgrpxxEYNPNg7KvvRTlnX38LAQ=; b=zAgdVJaYBsiJ7+jYP+IE7vDRB52TVAAsmyt1n/jrqjD3Z1OdaIx9WOBcjqwunliVaz p60bfA+s2H1xwEUV9H9PfgXkJoKKHMK+ojlZKOH8qMwU5csC5HT3s1hqqauBPsvxk5cI nUQSWvSduDtiRxcXoIJnWO1iAXGAT4dhcTkcqGcWAWtCYCKR5ArOCDzbvZgW3G1guFXi GJW6KHSY1m9/voBZ5Q6UCDF40UzQHX6cs3bEyD10nyMcTwlh/soVlqJHTp4UVG0vKCCr NhDvjTo+ppAyEEXGwsJ0Tvc70E1gUMZDn+2KO6PKKzWAhBcRD2FdcEE0CZJyw1S2fW96 T7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746352388; x=1746957188; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=leD0sWlnnaxAT1Wn0YgrpxxEYNPNg7KvvRTlnX38LAQ=; b=I3j18RvByWoPj5V5KbnzzKLAGUKuuhdv9ygScOdiOVWKUYeZ6h1gXS+owOwz6n9ngj GeokPKMwuVnt0N1I6prfyq2XYuXw6ZUzzrb59v90bPpo4i2VAWlnzV83nWtwV9DRd53l vpJoHiI9JaFsmg78gApY39KQyJ8OF/AMipLf0mz2NxyUXbwHJQptAc1FmpYbcuIRb7zW xpp4evLDLfFFjJXZCngV212tOyM38yhhYZVizycTCbFEVkT66XFwewcZFAShCJf9bm61 aDK1wQwUqOg+bR2Qm352jS2fqcA+8GTAs3cPSIsmdFMkZ1EEikklZvs5VVday7/C7hbv Z0KQ== X-Gm-Message-State: AOJu0YyT7fwQgJXN6BZnze15IYgLDhUCLGcyNZ1zfmSlLVecbogAzm7i RqWJbogJq8Bkg2UMrNjXmbn8/kO3iuJzPPRV2L9r+AsjFoNyU8xuPa3+DWulfzLYIB6ylQ== X-Google-Smtp-Source: AGHT+IEIOlvldtuHxJz4e50DXzMC/TAHLewwMAK9tSa45s8h2YcmOMMcQXUSx2JQi3bFtMgzVaLzExtP X-Received: from wmsp15.prod.google.com ([2002:a05:600c:1d8f:b0:43d:56fa:9b95]) (user=ardb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8219:b0:43d:79:ae1b with SMTP id 5b1f17b1804b1-441c1ce8e34mr45570345e9.14.1746352388517; Sun, 04 May 2025 02:53:08 -0700 (PDT) Date: Sun, 4 May 2025 11:52:32 +0200 In-Reply-To: <20250504095230.2932860-25-ardb+git@google.com> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250504095230.2932860-25-ardb+git@google.com> X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909 X-Developer-Signature: v=1; a=openpgp-sha256; l=961; i=ardb@kernel.org; h=from:subject; bh=VJ8S2Ug4P5Tq9blQL5XdMARbZUBntSDKvggXQxjCtFA=; b=owGbwMvMwCFmkMcZplerG8N4Wi2JIUPc4uGGD/IBp66qpE5yN9Kd315tUz0n/ZYo75vWjUGSM zTzHwR0lLIwiHEwyIopsgjM/vtu5+mJUrXOs2Rh5rAygQxh4OIUgIkEtTAy9HkEfkw5q5b5L3j1 xKdrL0sdD/l23WnzW/XYpzc3sYgaGTP8j728eKopz+rLEbPn18n4ubKXWW6cziMSH3J17Zn6ufO vsgEA X-Mailer: git-send-email 2.49.0.906.g1f30a19c02-goog Message-ID: <20250504095230.2932860-27-ardb+git@google.com> Subject: [RFT PATCH v2 02/23] x86/boot: Disregard __supported_pte_mask in __startup_64() From: Ard Biesheuvel To: linux-kernel@vger.kernel.org Cc: linux-efi@vger.kernel.org, x86@kernel.org, Ard Biesheuvel , Borislav Petkov , Ingo Molnar , Dionna Amalie Glaze , Kevin Loughlin , Tom Lendacky From: Ard Biesheuvel __supported_pte_mask is statically initialized to U64_MAX and never assigned until long after the startup code executes that creates the initial page tables. So applying the mask is unnecessary, and can be avoided. Signed-off-by: Ard Biesheuvel --- arch/x86/boot/startup/map_kernel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/boot/startup/map_kernel.c b/arch/x86/boot/startup/map_kernel.c index 0eac3f17dbd3..099ae2559336 100644 --- a/arch/x86/boot/startup/map_kernel.c +++ b/arch/x86/boot/startup/map_kernel.c @@ -179,8 +179,6 @@ unsigned long __head __startup_64(unsigned long p2v_offset, pud[(i + 1) % PTRS_PER_PUD] = (pudval_t)pmd + pgtable_flags; pmd_entry = __PAGE_KERNEL_LARGE_EXEC & ~_PAGE_GLOBAL; - /* Filter out unsupported __PAGE_KERNEL_* bits: */ - pmd_entry &= __supported_pte_mask; pmd_entry += sme_get_me_mask(); pmd_entry += physaddr;