mbox series

[v3,0/3] arch/powerpc: Resolve backlight include dependencies

Message ID 20240306122935.10626-1-tzimmermann@suse.de
Headers show
Series arch/powerpc: Resolve backlight include dependencies | expand

Message

Thomas Zimmermann March 6, 2024, 12:28 p.m. UTC 
After cleaning up <linux/fb.h> in commit 11b4eedfc87d ("fbdev: Do
not include <linux/backlight.h> in header"), building with
CONFIG_PMAC_BACKLIGHT=y returns errors about missing declarations.
Patches 1 and 2 resolve the errors. Patch 1 has been reviewed at [1].
Patch 3 removes another dependency between backlight and fbdev code.

Compile tested with ppc6xx_defconfig.

v3:
	* add Fixes tag and fix typos in patch 3
v2:
	* via-pmu-backlight: fix build errors
	* powerpc: resolve dependency between fbdev and backlight

[1] https://patchwork.freedesktop.org/series/130661/

Thomas Zimmermann (3):
  fbdev/chipsfb: Include <linux/backlight.h>
  macintosh/via-pmu-backlight: Include <linux/backlight.h>
  arch/powerpc: Remove <linux/fb.h> from backlight code

 arch/powerpc/include/asm/backlight.h        |  5 ++--
 arch/powerpc/platforms/powermac/backlight.c | 26 ---------------------
 drivers/macintosh/via-pmu-backlight.c       |  1 +
 drivers/video/fbdev/chipsfb.c               |  1 +
 4 files changed, 4 insertions(+), 29 deletions(-)

Comments

Thomas Zimmermann March 7, 2024, 8:59 a.m. UTC | #1 
If there are no further comments, I'm going to merge this patchset in 
time for today's PR of drm-misc-next-fixes.

Am 06.03.24 um 13:28 schrieb Thomas Zimmermann:
> After cleaning up <linux/fb.h> in commit 11b4eedfc87d ("fbdev: Do
> not include <linux/backlight.h> in header"), building with
> CONFIG_PMAC_BACKLIGHT=y returns errors about missing declarations.
> Patches 1 and 2 resolve the errors. Patch 1 has been reviewed at [1].
> Patch 3 removes another dependency between backlight and fbdev code.
>
> Compile tested with ppc6xx_defconfig.
>
> v3:
> 	* add Fixes tag and fix typos in patch 3
> v2:
> 	* via-pmu-backlight: fix build errors
> 	* powerpc: resolve dependency between fbdev and backlight
>
> [1] https://patchwork.freedesktop.org/series/130661/
>
> Thomas Zimmermann (3):
>    fbdev/chipsfb: Include <linux/backlight.h>
>    macintosh/via-pmu-backlight: Include <linux/backlight.h>
>    arch/powerpc: Remove <linux/fb.h> from backlight code
>
>   arch/powerpc/include/asm/backlight.h        |  5 ++--
>   arch/powerpc/platforms/powermac/backlight.c | 26 ---------------------
>   drivers/macintosh/via-pmu-backlight.c       |  1 +
>   drivers/video/fbdev/chipsfb.c               |  1 +
>   4 files changed, 4 insertions(+), 29 deletions(-)
>