From patchwork Fri Feb 11 14:33:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 541906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F236C4332F for ; Fri, 11 Feb 2022 14:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350919AbiBKOeV (ORCPT ); Fri, 11 Feb 2022 09:34:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347449AbiBKOeQ (ORCPT ); Fri, 11 Feb 2022 09:34:16 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1FFE91CF for ; Fri, 11 Feb 2022 06:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644590053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fz2Kno8PPLHlny0kFyGFu1CzpGMejC9s0k6wv2123LE=; b=NsDYQVf/Y4m5uXNyYgUm3QZhNwRRpRsOjg2r/p8kLhiLiSqnUyVPJVohOG4qHsdAce91bP Onn1DEFwjiCJxxY3L9aVmp6+PFAalmZ57WEcSU2U7kovUXuHPoSo3iYvlVWJpB96jgr8Vq YagrX0eiObub9H0CP09/H/fL1C2sLZY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-402-xJv1GBRLPMeq_nngFf4Ncw-1; Fri, 11 Feb 2022 09:34:11 -0500 X-MC-Unique: xJv1GBRLPMeq_nngFf4Ncw-1 Received: by mail-wr1-f70.google.com with SMTP id y10-20020adfc7ca000000b001e30ed3a496so3926950wrg.15 for ; Fri, 11 Feb 2022 06:34:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fz2Kno8PPLHlny0kFyGFu1CzpGMejC9s0k6wv2123LE=; b=fw6p48nivWH420BbNG0vnFKnS7Ss+kZGig/+chCqswcSbnHr59WjTMQLk9UjxcLwl5 /xMWrAtF5NZYLM5KFi/war7EG/psOFOgL0hxQIN7T9fwfAjv+fbdgLuEgBu7k+fb45HQ ITJRAz9eMn0uovCLWSmP1Ne9TkHs0Wvzd4OuaiwrLBykVSo4xUF/nsSv9GavxstUiEPr gOursyyHJE0xORYc35mxh07l3KNRQR7ecpQfacdPuZZXcYf4IAEyqM+65MY+WREG72Iq LNigyOmX9Wu1hSYJJ+vJPuLHmWYdtEdylX9Z/7+HRQmerlFSfgEFltUD1y1SnHof8EWk 2pfQ== X-Gm-Message-State: AOAM532NitEaqXj0F3JXb8EmkU6eKwTyKRosmurLQN0ARnHDXD+xkqsu t55P+jRvbHbfpw7OyL5nlC9IrDGM9N5lHaGtuoq9fBtS2JTTk8n1smqB4v0ACO8VUfZ8IaYSbP0 brw+6tJFqXYbQK1EYVsTxBdo= X-Received: by 2002:adf:decd:: with SMTP id i13mr1616433wrn.314.1644590049849; Fri, 11 Feb 2022 06:34:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJznBtKJaEhhYGX4nEC0I1gBzUDI6glrFk0hX33aohr/ENq8FE0yUVJyhR9x0JuIfNsT+0ZweA== X-Received: by 2002:adf:decd:: with SMTP id i13mr1616415wrn.314.1644590049605; Fri, 11 Feb 2022 06:34:09 -0800 (PST) Received: from minerva.redhat.com ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id o14sm24616012wry.104.2022.02.11.06.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 06:34:09 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Daniel Vetter , linux-fbdev@vger.kernel.org, Sam Ravnborg , Maxime Ripard , dri-devel@lists.freedesktop.org, =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Geert Uytterhoeven , Thomas Zimmermann , Andy Shevchenko , Javier Martinez Canillas , Daniel Vetter , David Airlie Subject: [PATCH v5 4/6] drm/solomon: Add SSD130x OLED displays I2C support Date: Fri, 11 Feb 2022 15:33:56 +0100 Message-Id: <20220211143358.3112958-5-javierm@redhat.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220211143358.3112958-1-javierm@redhat.com> References: <20220211143358.3112958-1-javierm@redhat.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org The ssd130x driver only provides the core support for these devices but it does not have any bus transport logic. Add a driver to interface over I2C. Signed-off-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko --- Changes in v5: - Add Andy Shevchenko's Reviewed-by tag to patch #4. Changes in v4: - Remove unnecessary casting (Geert Uytterhoeven) - Remove redundant blank lines (Andy Shevchenko) - Remove comma after of_device_id table terminator (Andy Shevchenko) Changes in v3: - Add a separate driver for SSD130X chips I2C support (Andy Shevchenko) drivers/gpu/drm/solomon/Kconfig | 9 ++ drivers/gpu/drm/solomon/Makefile | 1 + drivers/gpu/drm/solomon/ssd130x-i2c.c | 116 ++++++++++++++++++++++++++ 3 files changed, 126 insertions(+) create mode 100644 drivers/gpu/drm/solomon/ssd130x-i2c.c diff --git a/drivers/gpu/drm/solomon/Kconfig b/drivers/gpu/drm/solomon/Kconfig index 7720a7039e8d..5861c3ab7c45 100644 --- a/drivers/gpu/drm/solomon/Kconfig +++ b/drivers/gpu/drm/solomon/Kconfig @@ -10,3 +10,12 @@ config DRM_SSD130X the appropriate bus transport in your chip also must be selected. If M is selected the module will be called ssd130x. + +config DRM_SSD130X_I2C + tristate "DRM support for Solomon SSD130x OLED displays (I2C bus)" + depends on DRM_SSD130X && I2C + select REGMAP_I2C + help + Say Y here if the SSD130x OLED display is connected via I2C bus. + + If M is selected the module will be called ssd130x-i2c. diff --git a/drivers/gpu/drm/solomon/Makefile b/drivers/gpu/drm/solomon/Makefile index f685addb19fe..4bfc5acb0447 100644 --- a/drivers/gpu/drm/solomon/Makefile +++ b/drivers/gpu/drm/solomon/Makefile @@ -1 +1,2 @@ obj-$(CONFIG_DRM_SSD130X) += ssd130x.o +obj-$(CONFIG_DRM_SSD130X_I2C) += ssd130x-i2c.o diff --git a/drivers/gpu/drm/solomon/ssd130x-i2c.c b/drivers/gpu/drm/solomon/ssd130x-i2c.c new file mode 100644 index 000000000000..3126aeda4ced --- /dev/null +++ b/drivers/gpu/drm/solomon/ssd130x-i2c.c @@ -0,0 +1,116 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * DRM driver for Solomon SSD130x OLED displays (I2C bus) + * + * Copyright 2022 Red Hat Inc. + * Author: Javier Martinez Canillas + * + * Based on drivers/video/fbdev/ssd1307fb.c + * Copyright 2012 Free Electrons + */ +#include +#include + +#include "ssd130x.h" + +#define DRIVER_NAME "ssd130x-i2c" +#define DRIVER_DESC "DRM driver for Solomon SSD130x OLED displays (I2C)" + +static const struct regmap_config ssd130x_i2c_regmap_config = { + .reg_bits = 8, + .val_bits = 8, +}; + +static int ssd130x_i2c_probe(struct i2c_client *client) +{ + struct ssd130x_device *ssd130x; + struct regmap *regmap; + + regmap = devm_regmap_init_i2c(client, &ssd130x_i2c_regmap_config); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + + ssd130x = ssd130x_probe(&client->dev, regmap); + if (IS_ERR(ssd130x)) + return PTR_ERR(ssd130x); + + i2c_set_clientdata(client, ssd130x); + + return 0; +} + +static int ssd130x_i2c_remove(struct i2c_client *client) +{ + struct ssd130x_device *ssd130x = i2c_get_clientdata(client); + + return ssd130x_remove(ssd130x); +} + +static void ssd130x_i2c_shutdown(struct i2c_client *client) +{ + struct ssd130x_device *ssd130x = i2c_get_clientdata(client); + + ssd130x_shutdown(ssd130x); +} + +static struct ssd130x_deviceinfo ssd130x_ssd1305_deviceinfo = { + .default_vcomh = 0x34, + .default_dclk_div = 1, + .default_dclk_frq = 7, +}; + +static struct ssd130x_deviceinfo ssd130x_ssd1306_deviceinfo = { + .default_vcomh = 0x20, + .default_dclk_div = 1, + .default_dclk_frq = 8, + .need_chargepump = 1, +}; + +static struct ssd130x_deviceinfo ssd130x_ssd1307_deviceinfo = { + .default_vcomh = 0x20, + .default_dclk_div = 2, + .default_dclk_frq = 12, + .need_pwm = 1, +}; + +static struct ssd130x_deviceinfo ssd130x_ssd1309_deviceinfo = { + .default_vcomh = 0x34, + .default_dclk_div = 1, + .default_dclk_frq = 10, +}; + +static const struct of_device_id ssd130x_of_match[] = { + { + .compatible = "solomon,ssd1305fb-i2c", + .data = &ssd130x_ssd1305_deviceinfo, + }, + { + .compatible = "solomon,ssd1306fb-i2c", + .data = &ssd130x_ssd1306_deviceinfo, + }, + { + .compatible = "solomon,ssd1307fb-i2c", + .data = &ssd130x_ssd1307_deviceinfo, + }, + { + .compatible = "solomon,ssd1309fb-i2c", + .data = &ssd130x_ssd1309_deviceinfo, + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ssd130x_of_match); + +static struct i2c_driver ssd130x_i2c_driver = { + .driver = { + .name = DRIVER_NAME, + .of_match_table = ssd130x_of_match, + }, + .probe_new = ssd130x_i2c_probe, + .remove = ssd130x_i2c_remove, + .shutdown = ssd130x_i2c_shutdown, +}; +module_i2c_driver(ssd130x_i2c_driver); + +MODULE_DESCRIPTION(DRIVER_DESC); +MODULE_AUTHOR("Javier Martinez Canillas "); +MODULE_LICENSE("GPL v2");