| Message ID | 20230829142109.4521-2-tzimmermann@suse.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | fbdev: Split off code for boot-up logo | expand |
Thomas Zimmermann <tzimmermann@suse.de> writes: > The fbcon module takes care of displaying the logo, if any. Remove > the code form au1200fb. If we want to display the logo without fbcon, > we should implement this in the fbdev core code. > Agreed. I see that this code has been since the driver was added in 2006, I wonder if was ever used. Enabling a fbdev driver without fbcon doesn't seem to be a common configuration. > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- Acked-by: Javier Martinez Canillas <javierm@redhat.com>
diff --git a/drivers/video/fbdev/au1200fb.c b/drivers/video/fbdev/au1200fb.c index c137d6afe484..98afd385c49c 100644 --- a/drivers/video/fbdev/au1200fb.c +++ b/drivers/video/fbdev/au1200fb.c @@ -1719,15 +1719,6 @@ static int au1200fb_drv_probe(struct platform_device *dev) } au1200fb_fb_set_par(fbi); - -#if !defined(CONFIG_FRAMEBUFFER_CONSOLE) && defined(CONFIG_LOGO) - if (plane == 0) - if (fb_prepare_logo(fbi, FB_ROTATE_UR)) { - /* Start display and show logo on boot */ - fb_set_cmap(&fbi->cmap, fbi); - fb_show_logo(fbi, FB_ROTATE_UR); - } -#endif } /* Now hook interrupt too */
The fbcon module takes care of displaying the logo, if any. Remove the code form au1200fb. If we want to display the logo without fbcon, we should implement this in the fbdev core code. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/video/fbdev/au1200fb.c | 9 --------- 1 file changed, 9 deletions(-)