| Message ID | 20240329170038.3863998-11-eahariha@linux.microsoft.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Make I2C terminology more inclusive for I2C Algobit and consumers | expand |
On Fri, Mar 29, 2024 at 05:00:34PM +0000, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists > in the specification. > > Compile tested, no functionality changes intended > > [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ > > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> Reviewed-by: Simon Horman <horms@kernel.org>
On Fri, Mar 29, 2024 at 05:00:34PM +0000, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists > in the specification. > > Compile tested, no functionality changes intended > > [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ > > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> > --- > drivers/net/ethernet/sfc/falcon/falcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/falcon/falcon.c b/drivers/net/ethernet/sfc/falcon/falcon.c > index 7a1c9337081b..147e7c8e3c02 100644 > --- a/drivers/net/ethernet/sfc/falcon/falcon.c > +++ b/drivers/net/ethernet/sfc/falcon/falcon.c > @@ -367,7 +367,7 @@ static const struct i2c_algo_bit_data falcon_i2c_bit_operations = { > .getsda = falcon_getsda, > .getscl = falcon_getscl, > .udelay = 5, > - /* Wait up to 50 ms for slave to let us pull SCL high */ > + /* Wait up to 50 ms for client to let us pull SCL high */ > .timeout = DIV_ROUND_UP(HZ, 20), > }; > > -- > 2.34.1 >
On 4/2/2024 1:29 AM, Simon Horman wrote: > On Fri, Mar 29, 2024 at 05:00:34PM +0000, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the terminology for users of >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists >> in the specification. >> >> Compile tested, no functionality changes intended >> >> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ >> >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > > Reviewed-by: Simon Horman <horms@kernel.org> Thank you, Simon, for reviewing. I believe that we are settling on controller/target terminology from feedback on the other drivers in this series. Would you want to re-review v1 with that change, or should I add you R-B in v1 despite the change? Thanks, Easwar
On 4/2/2024 2:00 AM, Martin Habets wrote: > On Fri, Mar 29, 2024 at 05:00:34PM +0000, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the terminology for users of >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists >> in the specification. >> >> Compile tested, no functionality changes intended >> >> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ >> >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > > Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> > Thank you, Martin, for reviewing. I believe that we are settling on controller/target terminology from feedback on the other drivers in this series. Would you want to re-review v1 with that change, or should I add your R-B in v1 despite the change? Thanks, Easwar
On Thu, Apr 04, 2024 at 12:17:26PM -0700, Easwar Hariharan wrote: > On 4/2/2024 1:29 AM, Simon Horman wrote: > > On Fri, Mar 29, 2024 at 05:00:34PM +0000, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > >> with more appropriate terms. Inspired by and following on to Wolfram's > >> series to fix drivers/i2c/[1], fix the terminology for users of > >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists > >> in the specification. > >> > >> Compile tested, no functionality changes intended > >> > >> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ > >> > >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > > > > Reviewed-by: Simon Horman <horms@kernel.org> > > > Thank you, Simon, for reviewing. I believe that we are settling on controller/target > terminology from feedback on the other drivers in this series. Would you want to re-review > v1 with that change, or should I add you R-B in v1 despite the change? Thanks for asking, either way is fine by me.
On Thu, Apr 04, 2024 at 12:18:06PM -0700, Easwar Hariharan wrote: > On 4/2/2024 2:00 AM, Martin Habets wrote: > > On Fri, Mar 29, 2024 at 05:00:34PM +0000, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" > >> with more appropriate terms. Inspired by and following on to Wolfram's > >> series to fix drivers/i2c/[1], fix the terminology for users of > >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists > >> in the specification. > >> > >> Compile tested, no functionality changes intended > >> > >> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ > >> > >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > > > > Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> > > > > Thank you, Martin, for reviewing. I believe that we are settling on controller/target > terminology from feedback on the other drivers in this series. Would you want to re-review > v1 with that change, or should I add your R-B in v1 despite the change? You can add in my Reviewed-by. Martin > Thanks, > Easwar >
diff --git a/drivers/net/ethernet/sfc/falcon/falcon.c b/drivers/net/ethernet/sfc/falcon/falcon.c index 7a1c9337081b..147e7c8e3c02 100644 --- a/drivers/net/ethernet/sfc/falcon/falcon.c +++ b/drivers/net/ethernet/sfc/falcon/falcon.c @@ -367,7 +367,7 @@ static const struct i2c_algo_bit_data falcon_i2c_bit_operations = { .getsda = falcon_getsda, .getscl = falcon_getscl, .udelay = 5, - /* Wait up to 50 ms for slave to let us pull SCL high */ + /* Wait up to 50 ms for client to let us pull SCL high */ .timeout = DIV_ROUND_UP(HZ, 20), };
I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> --- drivers/net/ethernet/sfc/falcon/falcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)