From patchwork Thu Oct 24 02:20:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 839427 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11010034.outbound.protection.outlook.com [52.101.229.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C870145B0B; Thu, 24 Oct 2024 02:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.34 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729736408; cv=fail; b=oisAgqYiOEANVD1QV06X14CjlUbr/vb7LZ4pq8/4sPfg+fbgTP0enaV2SjLxgQQqjOSQ1B7pp4UPK7QfZfdwsPe/kNO3y3JaZrAyMHrJJMsP/55xZggLLc0x5dLKFWa5aB73tDQSxr+kIEhD3kgvlJ6LdcboKDDdS1BOLp1FSlI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729736408; c=relaxed/simple; bh=H6U4+todUoSlZHf1KoJaoiqokSu2VaGbbqs2CpjUvY4=; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type: Date:MIME-Version; b=c4+c0jitthhhPy0JGb5zks+F3F2oT5saFHiA1wDZeULiZXur85EVl5o4Jtlhpo3XX4krV+StWtwNlLyqjLAQQELZzcKL2oZWVdk2DfCb38wcRoDrxsW2/CCHYefayPslMge5sMvO2MLerEETw7F4Xwa+7ekx22h0bx6JRsR3Yl8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=YyosNEqZ; arc=fail smtp.client-ip=52.101.229.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="YyosNEqZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FNaHXppTwazAIyGJyhMoCGZ6gvBAXdGGUok2J5Xl+7p4sR+puZ3Zf3iIQkGZisXtebtfdtiEb3CbXOdh7zn6JBhTWaWQKrV8F6rN5dyO9LR5cGwgoNMQhi1Hyel6bJmNsnllV48Z9/+okH0Sf0J7tK3V3V9Zf/8GaXNGf1ZGSlNgafSbI/CVRw8ky9KY07mynI1/2HBXsT8aT5VRfrT35iwpYSlqhKyk1Sg9mLDrIy4vAeeUIa4oKNqARju62Y5nBKBaUKkgOGG4NJCyhe9pbdQ3R1TfYuE38/h0hLUIFgitd53HN/0pz9/AFoqQccFY9RR1kGXut6+nmk5B8/9gCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aJLhHsD3BHXJ4wIk58zeTG2N0Bpz71CtBXO3IQhjJ90=; b=NM+Qp/krxE+x+c0+BDWNBKhv/tflstJo1a3Mz6ZjK2dzocPsUEZFx+l3HNcoVi+ZclSPGL4qSwlKCm6wR8S2yVcKDTa1wnWhLvIS2Kr9JNEOLpMr+yta+VHluvmTmwihrAzHJu/1JNhs22Cze1HipwXXeWXjzJA/8CjzE2OJdnPBZjI9uMyTlUQQ4FW6+9b8+dlIWX+hLLrP309aCXTskFunVQ1xaGQlEQn3Zw63FAOOx5RoJ2DYATagikWwrKTFofDkCP/qnivWWTfIK2p/yEdaQy0hszzSG5lHDQ2eQvtyKZmVp5/3U+kZ8ynzakeJ6tv3N0Ji+fhdcaFi2fhlEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aJLhHsD3BHXJ4wIk58zeTG2N0Bpz71CtBXO3IQhjJ90=; b=YyosNEqZtbdeyeDd9U9gxX73NLpuxOxU4vzr8604hXGBP9V8TLCXlXjE/zMt0+uJEUuh+LmHoRMQgfpO5g0kArdj3zSgpp3JypTxhPPiygTJCo/bBCSkohZJsESrULWNx76XohqYaIkpEQDcGeFhwwkiyWcv9okZlsaP+ouY7p8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) by OSZPR01MB8629.jpnprd01.prod.outlook.com (2603:1096:604:187::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.17; Thu, 24 Oct 2024 02:20:02 +0000 Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11]) by TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11%5]) with mapi id 15.20.8093.014; Thu, 24 Oct 2024 02:20:02 +0000 Message-ID: <87ldyeb5t9.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH v8 1/9] of: property: add of_graph_get_next_port() User-Agent: Wanderlust/2.15.9 Emacs/29.3 Mule/6.0 To: Daniel Vetter , David Airlie , Helge Deller , Jaroslav Kysela , Laurent Pinchart , Liam Girdwood , Maarten Lankhorst , Mark Brown , Mauro Carvalho Chehab , Maxime Ripard , Michal Simek , Rob Herring , Saravana Kannan , Takashi Iwai , Thomas Zimmermann , Tomi Valkeinen , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-sound@vger.kernel.org, Sakari Ailus In-Reply-To: <87msiub5tt.wl-kuninori.morimoto.gx@renesas.com> References: <87msiub5tt.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 24 Oct 2024 02:20:02 +0000 X-ClientProxiedBy: TYCP286CA0121.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b6::14) To TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB10914:EE_|OSZPR01MB8629:EE_ X-MS-Office365-Filtering-Correlation-Id: 92fc2c77-3303-4395-3fe9-08dcf3d25df4 X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|52116014|1800799024|366016|921020|38350700014; X-Microsoft-Antispam-Message-Info: vi+jD0SOho4J5RBGNuDYbZIfeGIzfJ0t37U4jaWUnn0VKBBCiRozUNrpWROcTX6myAnuX4Doaqe6KTlusCoRtD+dqjn6U2UijuUI3DyIHx1BMcAAblSd3E7wTCxLuLoJXLLBhISKO7ieEWsPDmXcKdD4zbRf3zVDCq29lSZsdRtsmF+uwJh9TEH5CwOdj1jnV9MMldhcXmSXZRYjRNqXEuwrX7SMnfeDD1ITzRD1IVv7CNLe6pECITFNxdzV8penpbxRWyzB2KecZmWRXMQEo2mkzZO4jmNmuQN3rt59NEdXxs7FAf9CIkgFJrT4gnKu5Uxb7Pm2PDPJil2NPuvO96D5HPpm9l7m5LUN3Rt/M2S6vd/qS0/BIHSW7WpQRQy46eqSjrBbe02taXl4doEyMDg27Y6Txn8bUt4NvazMne/5Ssqu5EREWp62k8Z4J++ZKkDooRWrhfr5WTB1mtZkeaPc1ws0eFPDGExkJD7bJXEcGAp0ttUSRTidwgCbdAi7BvH+zOUxrGMQdWyLIc5oh76LxbpM8sHiRS/cMFLUq/y+so54xZ6xGdg/zTjOl5ftnZED3P4nqWtU8FiSSr6zsVESj17Pn2NUlA2BnDA/G/CSPKoTLPUwSlcWV9pXMkB/87u6eZa77jfOkrl/o6yId9QCwDRtolwWeB29mL03BmXcm6CUPfrGgLOSNc4hbd9EG6h60UmZbjTTgfSch6VofXGotcKuv+K7Wq+W3pd+F0TXlF6Oh/GnbzUGyd+ZwwNHmaSQVTHmVT4XoLn50HcgJCbLuBNf1LLteJyZtVjsziJBdtXHcK+gNMoF73DCumNaDkOd1u2xANyqvSkibhWCQ0uZY1zH8SMfwFzYrBFczzhZiecpGptlUyIM1S3WQU2JFPRBkwLhqHgYjwoEfKEQ9XrWAc0FhBHS3+vYWrQvZcwptOBS3R/B/BKzED/cdQiFT6pYvNYz+TMq57Lw/YRX8KULYUXvvizg6RNnQgTkZKijQGcAe5PBAnnwefVAl/KmC6LyKftYG32JR6Jxsk4pAYNmetQplOJMCdqRiLMAMASx0nXFeodjfW3mJvK+cfHMpWPqGSWxDmJH0c9I1G7nZ/xTFiClDMcOjq0saKLCfh5zNCM8ARZ0T+HEEVmaqXlZBQuI/DyT3B5XG6aQAJiPjUuXF8AHtk5rn2fLRnm0aCVJNbnaHVbk+lLR/nCiaBctv8e/5cg2PqAn+7RjQRsjMCm1by9qKAA4OXivypKhODCRfazuyg1ntJXp27Z42qunToTVMupez9+J6LK4Hz4Eus0a+oTWRqBMqoNpE5uMOIDWcUIocTn0i2jodeSPj6xZhH6PmKwQmMDr7Z8IBiOPsGRlCt/6hWWY9AMp7Z8UC++PWNjxgZa+XhllNOsFhKt5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB10914.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(52116014)(1800799024)(366016)(921020)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PEhu155sEaicb+6Hu7qLxSbnZ7te+01RhL7JvvE51aphBOYEYE3sv6Ay5penSh86HarOlvFCSyMidFdssoJ9wsdYF0vgwXRYjMkcNONPPj+NYXw8kG4uVqvIQvTq11jCMbFyqNjfHhNgZhxVyC0Md7x75RXEwYsxOU6sSw7ciE43OJx/PK9FfPqX1gy+49qzv4ebYEAOcn++6XUcT7eN0d5pymOxAPpB1lBp0Xnh4Td0cJdLX2ERwKhPZt7EBK6VyGDduuNCcyLWyEeDh0hgNf7/FsthIM0pOu62hrswo+AMDmlP2UQn2ypS32vg2XbfO/aLOykGPy5SSSC33VgjH9vpjR9lm3gb8EYcDMeOFkwSWHhFlRRO7dswPze1Q6pAbHYlR3q1iYCxO3uPnLUV52A9yISyytkp3j6WTUgzHXZd84kRZm9KAzEeX7p4+BpagDqaKwvuTaJiNguIXuPY/WsoF01WtqUd47lXdwE6fr8qUSguc9IDMESRTJfz+07Db6YVyMTrcXKo9JxxdihgX15U3ygdPMfljHFzV6175l0ycHziLopTPQ+0lh+GTUtMs68F22dem0NDrpScYDZwyLuUAZdVkjupPSgCpGkYeuh9EMqDmj+Jh69W5NDt1PoG6h/UmO1vylfEHbv/X7RUj88Plgz+3tqjBEO3vlk0LSejn73OYQIEjdxh2SZbNMIbvxyfT+7UtWkq+x3/cIUSgkpT+Qbqfv5DxO6PV4gyq2qIE/dEzQ4vj7K3eOIqx4gL6m6Yo72EFvEu0pQmZzHRsCnwgVriXjCFePevY/k5Xnm0rk5zukE2jO7Itph0LLhj/iPBcNJXnpo+IcC8F6NlY8ei5AAG2B/JtJkubgqEzmMvsphmci9eLo0KMwJErBRI8fh8OVt6mkysBoZEbNXY5/YF5jR9Ofnz+WxHDEiIfwubZxkfHEMfndqVD3VrPYRqp0sCi4IWuvM4Qzgnob5Dram62/2+t2zICXBVo8XAY4xX09fpnJI9pMrbIf0miOse1HKaHn0LjEkfyCVzV0cyinCVW+dfJU8fQW6GwYlVxsVb9ioZt6/2VqqIPkfwVkRpInmc7MpxXshz3Wjs21AHnt3JTE4rOPfmw7LNHNnsclq5vdRzgR82t+Jm26VohmQ9cRRQG+gCZ+Hzin2yE5eS8qaEpTQlC79Hwq2K8PWJgvOcnTjrui4TCztfPK762Cr7pq5N4hlk0EVYF98U+bv+IOx9YMG3ODwv+3/Rjxa9pRVMf/k8FE5K5/LOQVW5gRXNApOhSeYAPMPjrEqRyHrTfVsPFj6FoYfmThWY0VWM1YJ1NRAgTxB1nWsBycHN4bA1VummR4dQhbcMpfKLKfx4jR5bNnN3XqkEj1YN3eOhomSqKZ78zlVs0fLM9T7Ni6U5bgs3EgmhZ6BlgMxQufP7ZRBV9N/Q2DLGpxV9rKpCiUUx5Z5UwOEplxwsp1Ccl6/RjKy69O4veXwh5GBK3us6YNXFMJLYkTSzZexnaYv8bHS/g1JakzduXvkkejA563er9qlF+6MS1srZKCOpHMI+zdDIeEhIhtCMrnhMmyOlljnPIA0PJz6WNpGYhB1J6z8OhAGPlFRdiUPKGOXGjEtccS0zFT1uu4H9ID7TstISUA8= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92fc2c77-3303-4395-3fe9-08dcf3d25df4 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2024 02:20:02.5703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +jN78FxnfGxk+UXubneVyf4uBoDtlWAYO5G8ek9ZUKZK4ULL/Z67qDEZDhS/PA0Eo+8n4ZjOILWbfq5jAmkapoBPhhwqui+vlMG/ub8ExLJJEbBti08gh6ai7PgwHVE7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB8629 We have endpoint base functions - of_graph_get_next_endpoint() - of_graph_get_endpoint_count() - for_each_endpoint_of_node() Here, for_each_endpoint_of_node() loop finds each endpoints ports { port@0 { (1) endpoint {...}; }; port@1 { (2) endpoint {...}; }; ... }; In above case, it finds endpoint as (1) -> (2) -> ... Basically, user/driver knows which port is used for what, but not in all cases. For example on flexible/generic driver case, how many ports are used is not fixed. For example Sound Generic Card driver which is very flexible/generic and used from many venders can't know how many ports are used, and used for what, because it depends on each vender SoC and/or its used board. And more, the port can have multi endpoints. For example Generic Sound Card case, it supports many type of connection between CPU / Codec, and some of them uses multi endpoint in one port. see below. ports { (A) port@0 { (1) endpoint@0 {...}; (2) endpoint@1 {...}; }; (B) port@1 { (3) endpoint {...}; }; ... }; Generic Sound Card want to handle each connection via "port" base instead of "endpoint" base. But, it is very difficult to handle each "port" via existing for_each_endpoint_of_node(). Because getting each "port" via of_get_parent() from each "endpoint" doesn't work. For example in above case, both (1) (2) endpoint has same "port" (= A). Add "port" base functions. Signed-off-by: Kuninori Morimoto --- drivers/of/property.c | 54 ++++++++++++++++++++++++++++++++++++++++ include/linux/of_graph.h | 28 +++++++++++++++++++++ 2 files changed, 82 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index 11b922fde7af1..375d81fad8bf8 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -630,6 +630,43 @@ struct device_node *of_graph_get_port_by_id(struct device_node *parent, u32 id) } EXPORT_SYMBOL(of_graph_get_port_by_id); +/** + * of_graph_get_next_port() - get next port node. + * @parent: pointer to the parent device node, or parent ports node + * @prev: previous port node, or NULL to get first + * + * Parent device node can be used as @parent whether device node has ports node + * or not. It will work same as ports@0 node. + * + * Return: A 'port' node pointer with refcount incremented. Refcount + * of the passed @prev node is decremented. + */ +struct device_node *of_graph_get_next_port(const struct device_node *parent, + struct device_node *prev) +{ + if (!parent) + return NULL; + + if (!prev) { + struct device_node *node __free(device_node) = + of_get_child_by_name(parent, "ports"); + + if (node) + parent = node; + + return of_get_child_by_name(parent, "port"); + } + + do { + prev = of_get_next_child(parent, prev); + if (!prev) + break; + } while (!of_node_name_eq(prev, "port")); + + return prev; +} +EXPORT_SYMBOL(of_graph_get_next_port); + /** * of_graph_get_next_endpoint() - get next endpoint node * @parent: pointer to the parent device node @@ -823,6 +860,23 @@ unsigned int of_graph_get_endpoint_count(const struct device_node *np) } EXPORT_SYMBOL(of_graph_get_endpoint_count); +/** + * of_graph_get_port_count() - get the number of port in a device or ports node + * @np: pointer to the device or ports node + * + * Return: count of port of this device or ports node + */ +unsigned int of_graph_get_port_count(struct device_node *np) +{ + unsigned int num = 0; + + for_each_of_graph_port(np, port) + num++; + + return num; +} +EXPORT_SYMBOL(of_graph_get_port_count); + /** * of_graph_get_remote_node() - get remote parent device_node for given port/endpoint * @node: pointer to parent device_node containing graph port/endpoint diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h index a4bea62bfa290..44518f3583a44 100644 --- a/include/linux/of_graph.h +++ b/include/linux/of_graph.h @@ -11,6 +11,7 @@ #ifndef __LINUX_OF_GRAPH_H #define __LINUX_OF_GRAPH_H +#include #include #include @@ -37,14 +38,29 @@ struct of_endpoint { for (child = of_graph_get_next_endpoint(parent, NULL); child != NULL; \ child = of_graph_get_next_endpoint(parent, child)) +/** + * for_each_of_graph_port - iterate over every port in a device or ports node + * @parent: parent device or ports node containing port + * @child: loop variable pointing to the current port node + * + * When breaking out of the loop, and continue to use the @child, you need to + * use return_ptr(@child) or no_free_ptr(@child) not to call __free() for it. + */ +#define for_each_of_graph_port(parent, child) \ + for (struct device_node *child __free(device_node) = of_graph_get_next_port(parent, NULL);\ + child != NULL; child = of_graph_get_next_port(parent, child)) + #ifdef CONFIG_OF bool of_graph_is_present(const struct device_node *node); int of_graph_parse_endpoint(const struct device_node *node, struct of_endpoint *endpoint); unsigned int of_graph_get_endpoint_count(const struct device_node *np); +unsigned int of_graph_get_port_count(struct device_node *np); struct device_node *of_graph_get_port_by_id(struct device_node *node, u32 id); struct device_node *of_graph_get_next_endpoint(const struct device_node *parent, struct device_node *previous); +struct device_node *of_graph_get_next_port(const struct device_node *parent, + struct device_node *port); struct device_node *of_graph_get_endpoint_by_regs( const struct device_node *parent, int port_reg, int reg); struct device_node *of_graph_get_remote_endpoint( @@ -73,6 +89,11 @@ static inline unsigned int of_graph_get_endpoint_count(const struct device_node return 0; } +static inline unsigned int of_graph_get_port_count(struct device_node *np) +{ + return 0; +} + static inline struct device_node *of_graph_get_port_by_id( struct device_node *node, u32 id) { @@ -86,6 +107,13 @@ static inline struct device_node *of_graph_get_next_endpoint( return NULL; } +static inline struct device_node *of_graph_get_next_port( + const struct device_node *parent, + struct device_node *previous) +{ + return NULL; +} + static inline struct device_node *of_graph_get_endpoint_by_regs( const struct device_node *parent, int port_reg, int reg) {