From patchwork Tue May 27 17:11:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Florin X-Patchwork-Id: 893415 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FA42281529 for ; Tue, 27 May 2025 17:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365902; cv=none; b=CkUDy0bnIsB3+5bF28aFDidf+XjHFj6WRm0vIzbOMfDYEImFF5Uvv7Df/Vwgzd6AMj4/MRu3lPiMfL9SGpvtIY3JV/AF8msnM0fRzUFu+TBtDWAdQVq+O+BuSu7RFKCnZ5TlZf/6fdMQ6fqHevmEhqF+LYYqNjQCVYHVcOhQs90= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748365902; c=relaxed/simple; bh=WRJHINpKvIzq+kAIFhHGh/uFlb6VeUjDetEZlCoYiZ4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MhfgBZUtCt2H1MkEfbUBKjKarIEOrEUM8ldzFmRlK9jwJ6tCdfg+VJKYO10jmKCYO5yp1qjH68IqMaCHomdaOI7s0DZK93CZ6W9z/LtYezoZa33Hj7qZJCL3Ru84JU8fpj3mz+90vbo/goOwEuS8ulEp5TxolwtJAORvRTWFuNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qpbGGBHI; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ericflorin.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qpbGGBHI" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b1ffc678adfso2042144a12.0 for ; Tue, 27 May 2025 10:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748365900; x=1748970700; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7pWVizCte/zfBc5wbZWXELXXuItPZZs1aoRgUlPPJRw=; b=qpbGGBHIN0TqW9C3PippNa15FnnYBgR8Y4balOPlyC+nStPLHg39VtzSOnMNBAi011 yb3BqdDQBoUY7Ia4L24yaZ/sXg1AslzBvTer4QuSI6S514VVT978XDZ6fFsSJX8C5TtO pfkAODU0EiM3ufxCxHbMeospo+Vg3Wuqcf+86BoMVScZXnS8lki07o13p2+LcekoeFWP NWDAWzntfXxhDlbqPWc3KsSObCvyThLg8XDCkE2NTLfkYJtqbg6iJuuI1CZoY1VnnoCq nlil15/ByuQCdnxuJDqjyqg7BFBQV0h15MJAEm60a/JL6AmxdDM4e4j/Z5pscJ/uU7PJ ODww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748365900; x=1748970700; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7pWVizCte/zfBc5wbZWXELXXuItPZZs1aoRgUlPPJRw=; b=ELP8ctxl91D+p89wxcKiYzCBt3nR/ReU5v66bpBKAmuvqIWp+gZXIyS6cayfEgrySn C7YBt8g6UnALAK4QGugVxW2H3pgdKDFEuccXDRpTX5789hTgmChwH1WlYuoF++ckB22/ Ge8BhSqcADvYDsD7QLqQo0050rVBOSrjJcCiB0WcF3aAte9yZ/GI+pM9autJYCOWwoCf ntF/LIiWIf5VddPY4RzZiv9MDz8xAsD3o8Vt6bbpeTtdLMG7TVs3PZk3rf81+mNG6EJD D/blNkzi+7Pg+ZDau/jsoSe1Pziph2cDoeOGcLgrW03rztcOhYCtv3iWM2r61oQOpivI Wfqw== X-Forwarded-Encrypted: i=1; AJvYcCXeA8P67pEcD/UtBMtHlKc+kOzp4qOZQqz8P8lG5QmlmIKAIpMXd6feuwxX0CQ9H8JViJIX14Vexn/N2A==@vger.kernel.org X-Gm-Message-State: AOJu0YztkIV1Bn8Fi3e7CP4eCD9JbOZYryN4bDoLzMkm8/27AQiU5eyJ 6C7juFUDPZM2EGL/79zo7wvbOMdPnE1JnoZPvMqz5abI+nsEAYpE2rur6aO9mvFSgwwppB5RPn1 QOAsFXAjYu3KZe2cT/p6Ztw== X-Google-Smtp-Source: AGHT+IGco4V40TsVlohUm2gdWA+Dyi4GYATtBZ7Xwh96aBepziaL0EAKO0k6gcGCVwhfFEHtJ+i81GuM/G1Mo+NX X-Received: from pjuj14.prod.google.com ([2002:a17:90a:d00e:b0:311:4201:4021]) (user=ericflorin job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:35cc:b0:2fc:a3b7:108e with SMTP id 98e67ed59e1d1-3110f33438emr22861081a91.4.1748365900271; Tue, 27 May 2025 10:11:40 -0700 (PDT) Date: Tue, 27 May 2025 10:11:28 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1164.gab81da1b16-goog Message-ID: Subject: [PATCH 6/6] staging: sm750fb: Rename local var `nDirection` From: Eric Florin To: teddy.wang@siliconmotion.com Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Eric Florin Rename local variable `nDirection` to `n_direction` in `sm750_hw_copyarea` to conform with kernel style guidelines as reported by checkpatch.pl CHECK: Avoid CamelCase: Signed-off-by: Eric Florin --- drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index a34d8f6a033d..b9f90c934b7d 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int width, unsigned int height, unsigned int rop2) { - unsigned int nDirection, de_ctrl; + unsigned int n_direction, de_ctrl; - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 = Left to Right, (-1) = Right to Left */ de_ctrl = 0; @@ -173,7 +173,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = BOTTOM_TO_TOP; + n_direction = BOTTOM_TO_TOP; } else if (sy > dy) { /* +----------+ * |D | @@ -185,7 +185,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ - nDirection = TOP_TO_BOTTOM; + n_direction = TOP_TO_BOTTOM; } else { /* sy == dy */ @@ -198,7 +198,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = RIGHT_TO_LEFT; + n_direction = RIGHT_TO_LEFT; } else { /* sx > dx */ @@ -210,12 +210,12 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ - nDirection = LEFT_TO_RIGHT; + n_direction = LEFT_TO_RIGHT; } } } - if ((nDirection == BOTTOM_TO_TOP) || (nDirection == RIGHT_TO_LEFT)) { + if ((n_direction == BOTTOM_TO_TOP) || (n_direction == RIGHT_TO_LEFT)) { sx += width - 1; sy += height - 1; dx += width - 1; @@ -277,7 +277,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ de_ctrl = (rop2 & DE_CONTROL_ROP_MASK) | DE_CONTROL_ROP_SELECT | - ((nDirection == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | + ((n_direction == RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS; write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */