| Message ID | 20180302035045.14660-1-manivannan.sadhasivam@linaro.org |
|---|---|
| Headers | show |
| Series | Add Actions Semi S900 pinctrl and gpio support | expand |
On Fri, Mar 2, 2018 at 4:50 AM, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > Add pinctrl bindings for Actions Semi S900 SoC > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> Patch applied. These bindings are definately good looking and finalized, so no point in keeping iterating them, good work! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 2, 2018 at 4:50 AM, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > Add pinctrl nodes for Actions Semi S900 SoC > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Please funnel this patch through the ARM SoC tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 2, 2018 at 4:50 AM, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > Select PINCTRL for Actions Semi SoCs > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Please funnel this patch through the ARM SoC tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Mar 2, 2018 at 4:50 AM, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > Since I'll be working on improving support for ACTIONS platforms, adding > myself as the reviewer. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Andreas it would be great of I can have your ACK on this so I can merge the new pinctrl drivers and maintainer changes through the pinctrl tree. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Linus, On Fri, Mar 02, 2018 at 02:21:37PM +0100, Linus Walleij wrote: > On Fri, Mar 2, 2018 at 4:50 AM, Manivannan Sadhasivam > <manivannan.sadhasivam@linaro.org> wrote: > > > Add pinctrl driver for Actions Semi S900 SoC. The driver supports > > pinctrl, pinmux and pinconf functionalities through a range of registers > > common to both gpio driver and pinctrl driver. > > > > Pinmux functionality is available only for the pin groups while the > > pinconf functionality is available for both pin groups and individual > > pins. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Seems like this is pretty much finished. > > Let's see if you can collect some ACKs before we apply it. > Andreas is at Embedded World conference. I hope once he is back, he will have a look at this patchset. > Now just minor things remain. > > Random chosen example: > > > +static unsigned int lvds_e_drv_pads[] = { > > + LVDS_EEP, > > + LVDS_EEN, > > + LVDS_EDP, > > + LVDS_EDN, > > + LVDS_ECP, > > + LVDS_ECN, > > + LVDS_EBP, > > + LVDS_EBN, > > +}; > > + > > +static unsigned int sd0_d3_d0_drv_pads[] = { > > + SD0_D3, > > + SD0_D2, > > + SD0_D1, > > + SD0_D0, > > +}; > > People (e.g. Torvalds) sometimes get upset with files with too many lines > in them. This file has a lot of lines. A lot of pin control drivers try to cut > down the lines with macros, and you do it in some places too, > would you consider to see if you can cut down these tables with > macros? > > S900_PADS(LVDS_EEP, LVDS_EEN, LVDS_EDP, LVDS_EDN, > LVDS_ECP, LVDS_ECN, LVDS_EBP, LVDS_EBN); > S900_PADS(SD0_D3, SD0_D2, SD0_D1, SD0_D0); > I don't think it would be efficient to use macros here. However, I can align the pads and func definitions in a single line. This will also save a considerable amount of space. Thanks, Mani > Would be so much more compact. > > It's not the biggest problem though. > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html