mbox series

[RFC,0/3] add available pwm for bananapi-r64

Message ID 20201016204019.2606-1-linux@fw-web.de
Headers show
Series add available pwm for bananapi-r64 | expand

Message

Frank Wunderlich Oct. 16, 2020, 8:40 p.m. UTC
From: Frank Wunderlich <frank-w@public-files.de>

- mt7622 provides 6 pwm channels and only one is configured in dts
- pinctl-driver contains 7 pwm-channels where one is currently used.
- Mediatek confirmed that pwm7 does not exist and so dts is wrong
  and also the pinctrl definitions.

Frank Wunderlich (3):
  dts64: mt7622: enable all pwm for bananapi r64
  dts64: mt7622: disable spi1 and uart2 because pins are used by pwm
  pinctl: mt7622: drop pwm ch7 as mt7622 only has 6 channels

 .../boot/dts/mediatek/mt7622-bananapi-bpi-r64.dts   | 13 ++++++++-----
 drivers/pinctrl/mediatek/pinctrl-mt7622.c           | 13 +------------
 2 files changed, 9 insertions(+), 17 deletions(-)

Comments

Linus Walleij Oct. 29, 2020, 5:09 p.m. UTC | #1
On Fri, Oct 16, 2020 at 10:40 PM Frank Wunderlich <linux@fw-web.de> wrote:

> From: Frank Wunderlich <frank-w@public-files.de>
>
> mt7622 is reported by mediatek to have only 6 pwm channels
> so drop pindefines for 7th channel
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

I can merge this patch to the pinctrl tree if I get some kind of
review response from one of the Mediatek maintainers.

The rest should probably go through ARM SoC.

Yours,
Linus Walleij
Sean Wang Oct. 30, 2020, 6:36 p.m. UTC | #2
> > mt7622 is reported by mediatek to have only 6 pwm channels

> > so drop pindefines for 7th channel

> >

> > Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

>

> I can merge this patch to the pinctrl tree if I get some kind of

> review response from one of the Mediatek maintainers.

>


After confirming with the internal team, MT7622 actually does not have
the 7th channel. Thanks for Frank's catchup and patch.

Acked-by: Sean Wang <sean.wang@kernel.org>


> The rest should probably go through ARM SoC.

>

> Yours,

> Linus Walleij
Linus Walleij Nov. 6, 2020, 1:40 p.m. UTC | #3
On Fri, Oct 16, 2020 at 10:40 PM Frank Wunderlich <linux@fw-web.de> wrote:

> From: Frank Wunderlich <frank-w@public-files.de>
>
> mt7622 is reported by mediatek to have only 6 pwm channels
> so drop pindefines for 7th channel
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

This patch (3/3) applied to the pinctrl tree.

Please apply 1-2 to the ARM SoC tree.

Yours,
Linus Walleij