mbox series

[0/2] pinctrl: ingenic: Cleanup & add lcd-8bit group

Message ID 20201101090104.5088-1-paul@crapouillou.net
Headers show
Series pinctrl: ingenic: Cleanup & add lcd-8bit group | expand

Message

Paul Cercueil Nov. 1, 2020, 9:01 a.m. UTC
Hi Linus,

A cleanup patch to get rid of a lot of const data, and a patch to add
the lcd-8bit group for JZ4770 SoCs.

Based on your latest for-next branch, since there are already some
commits on pinctrl-ingenic.c there that aren't on v5.10-rc1.

Cheers,
-Paul

Paul Cercueil (2):
  pinctrl: ingenic: Get rid of repetitive data
  pinctrl: ingenic: Add lcd-8bit group for JZ4770

 drivers/pinctrl/pinctrl-ingenic.c | 1267 +++++++++++------------------
 1 file changed, 455 insertions(+), 812 deletions(-)

Comments

Zhou Yanjie Nov. 5, 2020, 2:20 p.m. UTC | #1
Hello,

On 2020/11/1 下午5:01, Paul Cercueil wrote:
> Hi Linus,
>
> A cleanup patch to get rid of a lot of const data, and a patch to add
> the lcd-8bit group for JZ4770 SoCs.
>
> Based on your latest for-next branch, since there are already some
> commits on pinctrl-ingenic.c there that aren't on v5.10-rc1.
>
> Cheers,
> -Paul
>
> Paul Cercueil (2):
>    pinctrl: ingenic: Get rid of repetitive data
>    pinctrl: ingenic: Add lcd-8bit group for JZ4770
>
>   drivers/pinctrl/pinctrl-ingenic.c | 1267 +++++++++++------------------
>   1 file changed, 455 insertions(+), 812 deletions(-)
>
Works fine on JZ4770, JZ4780, X1000, and X1830.

Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>


Thanks and best regards!
Linus Walleij Nov. 6, 2020, 1:44 p.m. UTC | #2
On Sun, Nov 1, 2020 at 10:01 AM Paul Cercueil <paul@crapouillou.net> wrote:

> Abuse the pin function pointer to store the pin function value directly,

> when all the pins of a group have the same function value. Now when the

> pointer value is <= 3 (unsigned), the pointer value is used as the pin

> function; otherwise it is used as a regular pointer.

>

> This drastically reduces the number of pin function tables needed, and

> drops .data usage by about 2 KiB. Additionally, the few pin function

> tables that are still around now contain u8 instead of int, since the

> largest number that will be stored is 3.

>

> Signed-off-by: Paul Cercueil <paul@crapouillou.net>


Both patches applied.

Yours,
Linus Walleij