mbox series

[0/5] GPIO PCH/ML-IOH consolidation baby steps

Message ID 20211130220841.2776562-1-helgaas@kernel.org
Headers show
Series GPIO PCH/ML-IOH consolidation baby steps | expand

Message

Bjorn Helgaas Nov. 30, 2021, 10:08 p.m. UTC
From: Bjorn Helgaas <bhelgaas@google.com>

These are tiny cleanups to pch and ml-ioh to try to make them easier to
merge together.  I can't really test either driver, so I'm not pushing too
hard on this.

If anybody wants to go further, Andy mentioned some docs here:
  https://lore.kernel.org/lkml/CAHp75VfDcQXqmK9=4k4rqi7t2OZaVPC13b45vLY7fELr7zBG_Q@mail.gmail.com/

Bjorn Helgaas (5):
  gpio: pch: Use .driver_data instead of checking Device IDs again
  gpio: pch: Cache &pdev->dev to reduce repetition
  gpio: ml-ioh: Cache &pdev->dev to reduce repetition
  gpio: ml-ioh: Use BIT() to match gpio-pch.c
  gpio: ml-ioh: Change whitespace to match gpio-pch.c

 drivers/gpio/gpio-ml-ioh.c | 52 +++++++++++++++++++-------------------
 drivers/gpio/gpio-pch.c    | 42 +++++++++++++++---------------
 2 files changed, 46 insertions(+), 48 deletions(-)

Comments

Andy Shevchenko Dec. 1, 2021, 1:08 p.m. UTC | #1
On Tue, Nov 30, 2021 at 04:08:36PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> These are tiny cleanups to pch and ml-ioh to try to make them easier to
> merge together.  I can't really test either driver, so I'm not pushing too
> hard on this.

Thanks, all pushed to my review and testing queue!

> If anybody wants to go further, Andy mentioned some docs here:
>   https://lore.kernel.org/lkml/CAHp75VfDcQXqmK9=4k4rqi7t2OZaVPC13b45vLY7fELr7zBG_Q@mail.gmail.com/
> 
> Bjorn Helgaas (5):
>   gpio: pch: Use .driver_data instead of checking Device IDs again
>   gpio: pch: Cache &pdev->dev to reduce repetition
>   gpio: ml-ioh: Cache &pdev->dev to reduce repetition
>   gpio: ml-ioh: Use BIT() to match gpio-pch.c
>   gpio: ml-ioh: Change whitespace to match gpio-pch.c
> 
>  drivers/gpio/gpio-ml-ioh.c | 52 +++++++++++++++++++-------------------
>  drivers/gpio/gpio-pch.c    | 42 +++++++++++++++---------------
>  2 files changed, 46 insertions(+), 48 deletions(-)
> 
> -- 
> 2.25.1
>