mbox series

[v1,0/6] pinctrl: intel: Enable PWM optional feature

Message ID 20221101155642.52575-1-andriy.shevchenko@linux.intel.com
Headers show
Series pinctrl: intel: Enable PWM optional feature | expand

Message

Andy Shevchenko Nov. 1, 2022, 3:56 p.m. UTC
This is a continuation of the previously applied PWM LPSS clean up.
Now, we would like to enable PWM optional feature that may be embedded
into Intel pin control IPs (starting from Sky Lake platforms).

I would like to route this via Intel pin control tree with issuing
an immutable branch for both PINCTRL and PWM subsystems, but I'm
open for other suggestions.

Hans, I dared to leave your Rb tags, however the patches are slighly
differ, because of the Uwe's suggestion on how to handle the missing
headers. I hope you is okay with that. If not, please comment what
must be ammended then.

Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>

Andy Shevchenko (6):
  pwm: Add a stub for devm_pwmchip_add()
  pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS
  pwm: lpss: Include headers we are direct user of
  pwm: lpss: Allow other drivers to enable PWM LPSS
  pwm: lpss: Add pwm_lpss_probe() stub
  pinctrl: intel: Enumerate PWM device when community has a capabilitty

 drivers/pinctrl/intel/pinctrl-intel.c         | 29 +++++++++++++
 drivers/pwm/pwm-lpss.c                        |  2 +-
 drivers/pwm/pwm-lpss.h                        | 34 ++++-----------
 .../linux/platform_data/x86}/pwm-lpss.h       | 41 ++++++++-----------
 include/linux/pwm.h                           |  5 +++
 5 files changed, 61 insertions(+), 50 deletions(-)
 copy {drivers/pwm => include/linux/platform_data/x86}/pwm-lpss.h (51%)

Comments

Mika Westerberg Nov. 2, 2022, 12:19 p.m. UTC | #1
Hi Andy,

On Tue, Nov 01, 2022 at 05:56:36PM +0200, Andy Shevchenko wrote:
> This is a continuation of the previously applied PWM LPSS clean up.
> Now, we would like to enable PWM optional feature that may be embedded
> into Intel pin control IPs (starting from Sky Lake platforms).
> 
> I would like to route this via Intel pin control tree with issuing
> an immutable branch for both PINCTRL and PWM subsystems, but I'm
> open for other suggestions.
> 
> Hans, I dared to leave your Rb tags, however the patches are slighly
> differ, because of the Uwe's suggestion on how to handle the missing
> headers. I hope you is okay with that. If not, please comment what
> must be ammended then.
> 
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> 
> Andy Shevchenko (6):
>   pwm: Add a stub for devm_pwmchip_add()
>   pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS
>   pwm: lpss: Include headers we are direct user of
>   pwm: lpss: Allow other drivers to enable PWM LPSS
>   pwm: lpss: Add pwm_lpss_probe() stub
>   pinctrl: intel: Enumerate PWM device when community has a capabilitty

Looks good to me. For the entire series,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>