| Message ID | 20221107071511.2764628-1-Mr.Bossman075@gmail.com |
|---|---|
| Headers | show |
| Series | Clean-up and documentation for i.MXRT1050 | expand |
On 11/7/22 02:44, Arnd Bergmann wrote: > On Mon, Nov 7, 2022, at 08:15, Jesse Taube wrote: >> Remove unused compatibles from i.MXRT1050.dtsi. >> Change GPT clock-names to match documentation. >> >> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com> >> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> > > Can you make sure your changelog texts explain why you do this? Yes, sorry I wasn't clear. > Are they fundamentally different from the devices you had > claimed to be compatible with that need a different driver, UART and SDHC had drivers added which are better fit. The GPT binds to imx6dl which is also the same as imx6sl. > or are there drivers in the field that bind to the wrong > string first? I don't understand? Thanks, Jesse Taube > > Arnd
On Mon, Nov 7, 2022, at 16:09, Jesse Taube wrote: > On 11/7/22 02:44, Arnd Bergmann wrote: >> On Mon, Nov 7, 2022, at 08:15, Jesse Taube wrote: >>> Remove unused compatibles from i.MXRT1050.dtsi. >>> Change GPT clock-names to match documentation. >>> >>> Cc: Giulio Benetti <giulio.benetti@benettiengineering.com> >>> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> >> >> Can you make sure your changelog texts explain why you do this? > Yes, sorry I wasn't clear. > >> Are they fundamentally different from the devices you had >> claimed to be compatible with that need a different driver, > > UART and SDHC had drivers added which are better fit. > The GPT binds to imx6dl which is also the same as imx6sl. Where are those drivers added? Looking at linux-6.1-rc2 and linux-next, I still see them use the same drivers as the original ones, and listing both strings would be the preferred method. >> or are there drivers in the field that bind to the wrong >> string first? > I don't understand? I mean if you had run into the case where you have a driver that misbehaves when the fallback string is present in addition to the most specific one. Arnd
On Mon, Nov 7, 2022 at 8:15 AM Jesse Taube <mr.bossman075@gmail.com> wrote: > During the initial commit of i.MXRT1050 > many of the DT docs were missing; this patch adds them. > The commit also adds docs for i.MXRT1170. > Clean up dtsi. > fix all the naming of pins in pinctrl, > wrong due to a miscommunication. > > Jesse Taube (7): > dt-bindings: arm: imx: Add i.MXRT compatible Documentation > dt-bindings: pinctrl: Fix file path for pinfunc include > dt-bindings: timer: gpt: Add i.MXRT compatible Documentation > dt-bindings: serial: fsl-lpuart: add i.MXRT1170 compatible > dt-bindings: mmc: fsl-imx-esdhc: add i.MXRT1170 compatible > pinctrl: freescale: Fix i.MXRT1050 pad names I applied patches 1-6 to the pinctrl tree. > ARM: dts: imx: Update i.MXRT1050.dtsi compatibles Please apply this patch 7/7 to the i.MX SoC tree. Yours, Linus Walleij
On Mon, Nov 7, 2022 at 8:15 AM Jesse Taube <mr.bossman075@gmail.com> wrote: > Remove unused compatibles from i.MXRT1050.dtsi. > Change GPT clock-names to match documentation. > > Cc: Giulio Benetti <giulio.benetti@benettiengineering.com> > Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com> I applied patches 1-6 to the pinctrl tree, this one seems independent and possibly should not even be applied as I understand it. Yours, Linus Walleij