mbox series

[v2,0/3] gpio: pcf857x: Implement get_multiple/set_multiple methods

Message ID 20230106160419.1020733-1-radu.rendec@gmail.com
Headers show
Series gpio: pcf857x: Implement get_multiple/set_multiple methods | expand

Message

Radu Rendec Jan. 6, 2023, 4:04 p.m. UTC 
The first two patches are just cosmetic changes. The actual changes are
in the third patch. They are all bundled together in a patch series just
because the third patch doesn't apply cleanly without the other two.

Change description from the third patch:

  This change allows the GPIO core to read/change multiple pins in a
  single driver call and subsequent I2C transfer. It helps a lot with
  PCF857x devices, since their I2C protocol always reads/changes all
  existing pins anyway. Therefore, when the GPIO client code does a bulk
  operation on multiple pins, the driver makes a single I2C transfer.

Radu Rendec (3):
  gpio: pcf857x: Replace 'unsigned' with 'unsigned int'
  gpio: pcf857x: Fix indentation of variable declarations
  gpio: pcf857x: Implement get_multiple/set_multiple methods

 drivers/gpio/gpio-pcf857x.c | 79 +++++++++++++++++++++++++------------
 1 file changed, 54 insertions(+), 25 deletions(-)

Comments

Bartosz Golaszewski Jan. 11, 2023, 9:58 a.m. UTC | #1 
On Fri, Jan 6, 2023 at 5:05 PM Radu Rendec <radu.rendec@gmail.com> wrote:
>
> The first two patches are just cosmetic changes. The actual changes are
> in the third patch. They are all bundled together in a patch series just
> because the third patch doesn't apply cleanly without the other two.
>
> Change description from the third patch:
>
>   This change allows the GPIO core to read/change multiple pins in a
>   single driver call and subsequent I2C transfer. It helps a lot with
>   PCF857x devices, since their I2C protocol always reads/changes all
>   existing pins anyway. Therefore, when the GPIO client code does a bulk
>   operation on multiple pins, the driver makes a single I2C transfer.
>
> Radu Rendec (3):
>   gpio: pcf857x: Replace 'unsigned' with 'unsigned int'
>   gpio: pcf857x: Fix indentation of variable declarations
>   gpio: pcf857x: Implement get_multiple/set_multiple methods
>
>  drivers/gpio/gpio-pcf857x.c | 79 +++++++++++++++++++++++++------------
>  1 file changed, 54 insertions(+), 25 deletions(-)
>
> --
> 2.39.0
>

Applied, thanks!

Bart