| Message ID | 20230120095036.514639-1-herve.codina@bootlin.com |
|---|---|
| Headers | show |
| Series | Add the Renesas IDT821034 codec support | expand |
On 20/01/2023 10:50, Herve Codina wrote: > The Renesas IDT821034 codec is a quad PCM codec with programmable > gain. > > Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- Thank you for your patch. There is something to discuss/improve. > + gpio-controller: true > + > +required: > + - compatible > + - reg > + - spi-cpha > + - '#sound-dai-cells' > + - gpio-controller > + - '#gpio-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi0 { I didn't notice it earlier - this should be just "spi". With above: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi, The Renesas IDT821034 codec is four channel PCM codec with on-chip filters and programmable gain setting. It also provides SLIC (Subscriber Line Interface Circuit) signals as GPIOs. Based on previous iteration: https://lore.kernel.org/all/20230111134905.248305-1-herve.codina@bootlin.com/ the bigger change is the codec driver rework in order to remove the regmap virtual registers layer. Best regards, Herve Codina Changes v1 -> v2: - All patches Reformat commit log - Patch 1 Remove '$ref: /schemas/gpio/gpio.yaml#' Use 'unevaluatedProperties: false' Update the node name and remove the sound node in the example - Patch 2 Change the file header comment format Rework in order to remove the regmap virtual registers Herve Codina (3): dt-bindings: sound: Add Renesas IDT821034 codec ASoC: codecs: Add support for the Renesas IDT821034 codec MAINTAINERS: add the Renesas IDT821034 codec entry .../bindings/sound/renesas,idt821034.yaml | 75 ++ MAINTAINERS | 7 + sound/soc/codecs/Kconfig | 12 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/idt821034.c | 1200 +++++++++++++++++ 5 files changed, 1296 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/renesas,idt821034.yaml create mode 100644 sound/soc/codecs/idt821034.c