| Message ID | 20230303002850.51858-1-arinc.unal@arinc9.com |
|---|---|
| Headers | show |
| Series | pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings | expand |
On Fri, Mar 3, 2023 at 1:29 AM <arinc9.unal@gmail.com> wrote: > [PATCH 00/20] pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings > > This is an ambitious effort I've been wanting to do for months. Good with ambitions :) As long as Sergio is on board and can test the changes and as long as the DT maintainers do not explicitly disapprove, I'm game to merge this. I guess you will respin on top of v6.3-rc1 when the first round of non-RFC feedback is collected. Yours, Linus Walleij
On Mon, Mar 6, 2023 at 2:50 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Mar 3, 2023 at 1:29 AM <arinc9.unal@gmail.com> wrote: > > > [PATCH 00/20] pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings > > > > This is an ambitious effort I've been wanting to do for months. > > Good with ambitions :) > > As long as Sergio is on board and can test the changes and as long > as the DT maintainers do not explicitly disapprove, I'm game to merge > this. For sure I am :-). Changes in code are pretty straightforward. The real big change is just a split of mt7620 and mt76x8 in two different files. But the split looks good to me. The other bulk of changes is just moving files around. If DT maintainers are finally ok with the changes I will try to make time to test this series in a rt5350 SoC based board I think I have somewhere and on mt7621 SoC based one. Most of my ralink boards are based on mt7621 so I don't have more platforms to test this pinctrl changes :(. > > I guess you will respin on top of v6.3-rc1 when the first round of > non-RFC feedback is collected. > > Yours, > Linus Walleij Thanks, Sergio Paracuellos
On 6.03.2023 16:50, Linus Walleij wrote: > On Fri, Mar 3, 2023 at 1:29 AM <arinc9.unal@gmail.com> wrote: > >> [PATCH 00/20] pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings >> >> This is an ambitious effort I've been wanting to do for months. > > Good with ambitions :) > > As long as Sergio is on board and can test the changes and as long > as the DT maintainers do not explicitly disapprove, I'm game to merge > this. Cheers. > > I guess you will respin on top of v6.3-rc1 when the first round of > non-RFC feedback is collected. Sure, if it's necessary. Once I get feedback, I'll rebase it to your linusw/linux-pinctrl.git for-next tree, see if it needs manual changes. I'll let you know. Arınç
On Mon, Mar 6, 2023 at 3:56 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote: > Sure, if it's necessary. Once I get feedback, I'll rebase it to your > linusw/linux-pinctrl.git for-next tree, see if it needs manual changes. > I'll let you know. Hm my for-next branch is a mixdown for linux-next so use the branch named "devel" instead. Thanks! Linus Walleij
[PATCH 00/20] pinctrl: ralink: fix ABI, improve driver, move to mediatek, improve dt-bindings This is an ambitious effort I've been wanting to do for months. Straight off the bat, I'm fixing the ABI that I broke a while back, by reintroducing the ralink,rt2880-pinmux compatible string. If you take a look at the schema for mt7620 and rt305x, some functions got multiple lists for groups. Like refclk on mt7620. Because mt7620 and mt7628/mt7688 SoCs use the same compatible string, it's impossible to differentiate on the binding which SoC a devicetree is actually for. Therefore, the binding will allow all groups listed for that function. For example, if the SoC is mt7620, only the refclk function for the mdio group can be used. If one were to put "spi cs1" as the function there, there wouldn't be a warning. I address this by introducing new compatible strings for these SoCs, then split the schemas. I also separate mt7628/mt7688 from mt7620 pinctrl subdriver in the process. I wanted to split the rt305x driver too but too much code would be reused so I backed down from that. This platform from Ralink was acquired by MediaTek in 2011. Then, MediaTek introduced new SoCs which utilise this platform. We're moving the Ralink pinctrl driver to MediaTek, and rename the schemas for MediaTek SoCs to mediatek. I've renamed the ralink core driver to mtmips. I decided to call the core mtmips as I've seen folks from MediaTek use the same name when they added support for MT7621 pinctrl on U-Boot. Feel free to comment on this. Arınç RFC to v1: - Address Rob and Krzysztof's reviews, add Rob's acked-by. - More cleanups, hooray! - Keep ralink,rt2880-pinmux deprecated. - Deprecate ralink,mt7620-pinctrl. Another one bites the dust! - More slight changes I can't currently remember to mention. Arınç ÜNAL (20): pinctrl: ralink: reintroduce ralink,rt2880-pinmux compatible string pinctrl: ralink: {mt7620,mt7621}: add new mediatek compatible strings pinctrl: ralink: rt305x: add new compatible string for every SoC pinctrl: ralink: mt7620: split out to mt76x8 pinctrl: ralink: move to mediatek as mtmips pinctrl: mediatek: remove OF_GPIO as reverse dependency dt-bindings: pinctrl: ralink: improve bindings dt-bindings: pinctrl: ralink: add new compatible strings dt-bindings: pinctrl: ralink: {mt7620,mt7621}: rename to mediatek dt-bindings: pinctrl: mediatek: mt6795: rename to mediatek,mt6795-pinctrl dt-bindings: pinctrl: mediatek: mt8186: rename to mediatek,mt8186-pinctrl dt-bindings: pinctrl: mediatek: mt8192: rename to mediatek,mt8192-pinctrl dt-bindings: pinctrl: mediatek: mt8195: rename to mediatek,mt8195-pinctrl dt-bindings: pinctrl: mediatek: fix naming inconsistency dt-bindings: pinctrl: {mediatek,ralink}: fix formatting dt-bindings: pinctrl: mediatek: drop quotes from referred schemas dt-bindings: pinctrl: mediatek: mt7986: fix patternProperties regex dt-bindings: pinctrl: ralink: rt305x: split binding dt-bindings: pinctrl: mediatek: mt7620: split binding MAINTAINERS: move ralink pinctrl to mediatek mips pinctrl .../pinctrl/mediatek,mt65xx-pinctrl.yaml | 28 +- .../pinctrl/mediatek,mt6779-pinctrl.yaml | 37 +- ...mt6795.yaml => mediatek,mt6795-pinctrl.yaml} | 39 +- .../pinctrl/mediatek,mt7620-pinctrl.yaml | 298 ++++++++++++++ ...inctrl.yaml => mediatek,mt7621-pinctrl.yaml} | 23 +- .../pinctrl/mediatek,mt7622-pinctrl.yaml | 32 +- ...inctrl.yaml => mediatek,mt76x8-pinctrl.yaml} | 252 ++---------- .../pinctrl/mediatek,mt7981-pinctrl.yaml | 35 +- .../pinctrl/mediatek,mt7986-pinctrl.yaml | 72 ++-- .../pinctrl/mediatek,mt8183-pinctrl.yaml | 30 +- ...mt8186.yaml => mediatek,mt8186-pinctrl.yaml} | 51 ++- .../pinctrl/mediatek,mt8188-pinctrl.yaml | 76 ++-- ...mt8192.yaml => mediatek,mt8192-pinctrl.yaml} | 53 +-- ...mt8195.yaml => mediatek,mt8195-pinctrl.yaml} | 44 +-- .../pinctrl/mediatek,mt8365-pinctrl.yaml | 28 +- .../bindings/pinctrl/ralink,rt2880-pinctrl.yaml | 11 +- .../bindings/pinctrl/ralink,rt305x-pinctrl.yaml | 89 +---- .../bindings/pinctrl/ralink,rt3352-pinctrl.yaml | 243 ++++++++++++ .../bindings/pinctrl/ralink,rt3883-pinctrl.yaml | 11 +- .../bindings/pinctrl/ralink,rt5350-pinctrl.yaml | 206 ++++++++++ MAINTAINERS | 29 +- drivers/pinctrl/Kconfig | 1 - drivers/pinctrl/Makefile | 1 - drivers/pinctrl/mediatek/Kconfig | 54 ++- drivers/pinctrl/mediatek/Makefile | 63 +-- drivers/pinctrl/mediatek/pinctrl-mt7620.c | 138 +++++++ .../{ralink => mediatek}/pinctrl-mt7621.c | 32 +- drivers/pinctrl/mediatek/pinctrl-mt76x8.c | 283 ++++++++++++++ .../pinctrl-mtmips.c} | 90 ++--- .../pinctrl-mtmips.h} | 16 +- .../{ralink => mediatek}/pinctrl-rt2880.c | 21 +- .../{ralink => mediatek}/pinctrl-rt305x.c | 47 +-- .../{ralink => mediatek}/pinctrl-rt3883.c | 29 +- drivers/pinctrl/ralink/Kconfig | 35 -- drivers/pinctrl/ralink/Makefile | 8 - drivers/pinctrl/ralink/pinctrl-mt7620.c | 391 ------------------- 36 files changed, 1723 insertions(+), 1173 deletions(-)