[V2,0/6] pinctrl: sprd: Modification of UNIOC Platform pinctrl Driver

From: Linhua Xu <Linhua.Xu@unisoc.com>

Recently, some bugs have been discovered during use, and patch2 and patch3
are bug fixes. Also, this patchset add new features: patch1 is for
compatibility with more platforms, patch4 add pinctrl support for UMS512,
patch5 Increase the range of register values, patch6 add pinctrl support
for UMS9621.

change in V2
-Add comment for common_pin_offset and misc_pin_offset
-Remove cast commits
-Modify the mask definition into GENMASK form
-Delete the three-speed configuration that modifies the original parameters
-Add 1.8K resistor configuration
-Delete depends on OF
-Modify the format of sprd_pinctrl_of_match
-Drop trailing comma in the terminator entry
-Add bits.h header file
-Add kernel.h header file

Linhua Xu (6):
  pinctrl: sprd: Modify the probe function parameters
  pinctrl: sprd: Fix the incorrect mask and shift definition
  pinctrl: sprd: Modify pull-up parameters
  pinctrl: sprd: Add pinctrl support for UMS512
  pinctrl: sprd: Increase the range of register values
  pinctrl: sprd: Add pinctrl support for UMS9621

 drivers/pinctrl/sprd/Kconfig                |   22 +
 drivers/pinctrl/sprd/Makefile               |    2 +
 drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c  |    7 +-
 drivers/pinctrl/sprd/pinctrl-sprd-ums512.c  |  878 +++++++++++++++
 drivers/pinctrl/sprd/pinctrl-sprd-ums9621.c | 1117 +++++++++++++++++++
 drivers/pinctrl/sprd/pinctrl-sprd.c         |   49 +-
 drivers/pinctrl/sprd/pinctrl-sprd.h         |   33 +-
 7 files changed, 2071 insertions(+), 37 deletions(-)
 create mode 100644 drivers/pinctrl/sprd/pinctrl-sprd-ums512.c
 create mode 100644 drivers/pinctrl/sprd/pinctrl-sprd-ums9621.c

On Fri, Sep 8, 2023 at 7:52 AM Linhua Xu <Linhua.xu@unisoc.com> wrote:

> From: Linhua Xu <Linhua.Xu@unisoc.com>
>
> Recently, some bugs have been discovered during use, and patch2 and patch3
> are bug fixes. Also, this patchset add new features: patch1 is for
> compatibility with more platforms, patch4 add pinctrl support for UMS512,
> patch5 Increase the range of register values, patch6 add pinctrl support
> for UMS9621.
>
> change in V2

V2 is starting to look good, please address Andy's comments, especially
move the fixes first in the series so they can be queued as fixes
if need be.

I would really appreciate if Baolin can review the patches as well as
he knows this hardware very well and wrote the initial version.

Yours,
Linus Walleij

On 9/11/2023 9:41 PM, Linus Walleij wrote:
> On Fri, Sep 8, 2023 at 7:52 AM Linhua Xu <Linhua.xu@unisoc.com> wrote:
> 
>> From: Linhua Xu <Linhua.Xu@unisoc.com>
>>
>> Recently, some bugs have been discovered during use, and patch2 and patch3
>> are bug fixes. Also, this patchset add new features: patch1 is for
>> compatibility with more platforms, patch4 add pinctrl support for UMS512,
>> patch5 Increase the range of register values, patch6 add pinctrl support
>> for UMS9621.
>>
>> change in V2
> 
> V2 is starting to look good, please address Andy's comments, especially
> move the fixes first in the series so they can be queued as fixes
> if need be.

Yes, agree. Please send the fix patches separately with proper Fixes tag.

> 
> I would really appreciate if Baolin can review the patches as well as
> he knows this hardware very well and wrote the initial version.

Sure.