| Message ID | 20231108104343.24192-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | dt-bindings: samsung: add specific compatibles for existing SoC | expand |
On Wed, 08 Nov 2023, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../mfd/samsung,exynos5433-lpass.yaml | 2 +- > .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++------- > 2 files changed, 13 insertions(+), 8 deletions(-) Acked-by: Lee Jones <lee@kernel.org>
Hi Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Wednesday, November 8, 2023 4:13 PM > To: David Airlie <airlied@gmail.com>; Daniel Vetter <daniel@ffwll.ch>; > Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard > <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>; > Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > <conor+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>; Andi > Shyti <andi.shyti@kernel.org>; Jonathan Cameron <jic23@kernel.org>; Lars- > Peter Clausen <lars@metafoo.de>; Lee Jones <lee@kernel.org>; Ulf > Hansson <ulf.hansson@linaro.org>; Tomasz Figa <tomasz.figa@gmail.com>; > Sylwester Nawrocki <s.nawrocki@samsung.com>; Linus Walleij > <linus.walleij@linaro.org>; Thierry Reding <thierry.reding@gmail.com>; Uwe > Kleine-König <u.kleine-koenig@pengutronix.de>; Alessandro Zummo > <a.zummo@towertech.it>; Alexandre Belloni > <alexandre.belloni@bootlin.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; Jiri Slaby <jirislaby@kernel.org>; Liam > Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; > Jaehoon Chung <jh80.chung@samsung.com>; Sam Protsenko > <semen.protsenko@linaro.org>; dri-devel@lists.freedesktop.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > i2c@vger.kernel.org; linux-iio@vger.kernel.org; linux-mmc@vger.kernel.org; > linux-gpio@vger.kernel.org; linux-pwm@vger.kernel.org; linux- > rtc@vger.kernel.org; linux-serial@vger.kernel.org; alsa-devel@alsa- > project.org; linux-sound@vger.kernel.org > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Subject: [PATCH 00/17] dt-bindings: samsung: add specific compatibles for > existing SoC > > Hi, > > Merging > ======= > I propose to take entire patchset through my tree (Samsung SoC), because: > 1. Next cycle two new SoCs will be coming (Google GS101 and > ExynosAutov920), so > they will touch the same lines in some of the DT bindings (not all, though). > It is reasonable for me to take the bindings for the new SoCs, to have clean > `make dtbs_check` on the new DTS. > 2. Having it together helps me to have clean `make dtbs_check` within my > tree > on the existing DTS. > 3. No drivers are affected by this change. > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect > follow up patchsets. > Sure, make sense. > If folks agree, please kindly Ack the patches. > > Description > =========== > Samsung Exynos SoCs reuse several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine and > there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like compatibles. > This will also help reviews of new code using existing DTS as template. No > functional impact on Linux drivers behavior. > > Future > ====== > If reasonable, I will do similar work for Tesla FSD and ARMv7/ARM32 Exynos > bindings and DTS. > > Best regards, > Krzysztof > > Krzysztof Kozlowski (17): > dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles > for existing SoC > dt-bindings: i2c: exynos5: add specific compatibles for existing SoC > dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for > existing SoC > dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for > existing SoC > dt-bindings: pinctrl: samsung: add specific compatibles for existing > SoC > dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC > dt-bindings: serial: samsung: add specific compatibles for existing > SoC > dt-bindings: samsung: exynos-pmu: add specific compatibles for > existing SoC > dt-bindings: gpu: arm,mali-midgard: add specific compatibles for > existing Exynos SoC > dt-bindings: iio: samsung,exynos-adc: add specific compatibles for > existing SoC > ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing > SoC > dt-bindings: pwm: samsung: add specific compatibles for existing SoC > arm64: dts: exynos5433: add specific compatibles to several blocks > arm64: dts: exynos7: add specific compatibles to several blocks > arm64: dts: exynos7885: add specific compatibles to several blocks > arm64: dts: exynos850: add specific compatibles to several blocks > arm64: dts: exynosautov9: add specific compatibles to several blocks > > .../bindings/gpu/arm,mali-midgard.yaml | 5 ++ > .../hwinfo/samsung,exynos-chipid.yaml | 17 +++++- > .../devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++- > .../bindings/i2c/samsung,s3c2410-i2c.yaml | 22 ++++--- > .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++---- > .../mfd/samsung,exynos5433-lpass.yaml | 2 +- > .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 +++++--- > .../samsung,pinctrl-wakeup-interrupt.yaml | 24 +++++--- > .../bindings/pinctrl/samsung,pinctrl.yaml | 3 +- > .../devicetree/bindings/pwm/pwm-samsung.yaml | 2 + > .../devicetree/bindings/rtc/s3c-rtc.yaml | 5 ++ > .../bindings/serial/samsung_uart.yaml | 14 ++++- > .../bindings/soc/samsung/exynos-pmu.yaml | 6 ++ > .../bindings/soc/samsung/exynos-usi.yaml | 2 +- > .../bindings/sound/samsung-i2s.yaml | 19 +++--- > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 60 ++++++++++++------- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 18 +++--- > arch/arm64/boot/dts/exynos/exynos7885.dtsi | 45 +++++++++----- > arch/arm64/boot/dts/exynos/exynos850.dtsi | 34 ++++++----- > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 6 +- > 20 files changed, 233 insertions(+), 115 deletions(-) > > -- > 2.34.1
On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > Merging > ======= > I propose to take entire patchset through my tree (Samsung SoC), because: > 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), so > they will touch the same lines in some of the DT bindings (not all, though). > It is reasonable for me to take the bindings for the new SoCs, to have clean > `make dtbs_check` on the new DTS. > 2. Having it together helps me to have clean `make dtbs_check` within my tree > on the existing DTS. > 3. No drivers are affected by this change. > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect > follow up patchsets. > > [...] Applied, thanks! [01/17] dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/4be756fd983a0d91c258196b3206e9131e63d62d [02/17] dt-bindings: i2c: exynos5: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/9da80ed69eb150617e8c72aeb7fdb9bfc7b97fba [03/17] dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/c45860f6ee9b52b2e2f9b9255d93b9875e416cb0 [04/17] dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/5faf7e3d35b819cfa8de971f7e8ed84552c3a676 [05/17] dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/3e17c66d1aa322db1d68e842089bd639a88a88bf [06/17] dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/b8029fbe90351d1fdd54dceb39b21c4062c94ce1 [07/17] dt-bindings: serial: samsung: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/6f52f8b78d319ba63ce7fae950d9395d376bb6bf [08/17] dt-bindings: samsung: exynos-pmu: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/ed856d66b8c679ec1260c3151b2f4f3202aa213b [09/17] dt-bindings: gpu: arm,mali-midgard: add specific compatibles for existing Exynos SoC https://git.kernel.org/krzk/linux/c/e47d571301460a214c6253c15ff79db20ea50389 [10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/bbe4d4bbacd7f11b601a0c912f3f6270558899d8 [11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/4a559c3db839afea05dc0f471823d4401b4444fc [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC https://git.kernel.org/krzk/linux/c/0b549b3f74e39f7b0e787f8ffdfd2cf67c0fdc4b [13/17] arm64: dts: exynos5433: add specific compatibles to several blocks https://git.kernel.org/krzk/linux/c/e9a72a20acf7b620e48cd4e268d7c7a4d45e1930 [14/17] arm64: dts: exynos7: add specific compatibles to several blocks https://git.kernel.org/krzk/linux/c/a1c0d44441d35063b79f38120105b5f92ca40445 [15/17] arm64: dts: exynos7885: add specific compatibles to several blocks https://git.kernel.org/krzk/linux/c/050e7f7217e4d4d73dfcebfbc35b3eafbc36272a [16/17] arm64: dts: exynos850: add specific compatibles to several blocks https://git.kernel.org/krzk/linux/c/bd3623def8a93cea94a8689514e557fd4522dd53 [17/17] arm64: dts: exynosautov9: add specific compatibles to several blocks https://git.kernel.org/krzk/linux/c/2a8ff4d56ef6cb4a7b2b4025ea4366178e4e8eaf Best regards,
On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > Merging > ======= > I propose to take entire patchset through my tree (Samsung SoC), because: > 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), so > they will touch the same lines in some of the DT bindings (not all, though). > It is reasonable for me to take the bindings for the new SoCs, to have clean > `make dtbs_check` on the new DTS. > 2. Having it together helps me to have clean `make dtbs_check` within my tree > on the existing DTS. > 3. No drivers are affected by this change. > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect > follow up patchsets. > > [...] Applied, thanks! [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC commit: 5d67b8f81b9d598599366214e3b2eb5f84003c9f Best regards,
On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: > > On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > > Merging > > ======= > > I propose to take entire patchset through my tree (Samsung SoC), because: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), so > > they will touch the same lines in some of the DT bindings (not all, though). > > It is reasonable for me to take the bindings for the new SoCs, to have clean > > `make dtbs_check` on the new DTS. > > 2. Having it together helps me to have clean `make dtbs_check` within my tree > > on the existing DTS. > > 3. No drivers are affected by this change. > > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect > > follow up patchsets. > > > > [...] > > Applied, thanks! > > [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC > commit: 5d67b8f81b9d598599366214e3b2eb5f84003c9f You didn't honor (or even comment) Krzysztof's proposal to take the whole patchset via his tree (marked above). Was there some off-list agreement? Best regards Uwe
On 28/11/2023 21:58, Uwe Kleine-König wrote: > On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: >> >> On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: >>> Merging >>> ======= >>> I propose to take entire patchset through my tree (Samsung SoC), because: > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > >>> 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), so >>> they will touch the same lines in some of the DT bindings (not all, though). >>> It is reasonable for me to take the bindings for the new SoCs, to have clean >>> `make dtbs_check` on the new DTS. >>> 2. Having it together helps me to have clean `make dtbs_check` within my tree >>> on the existing DTS. >>> 3. No drivers are affected by this change. >>> 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect >>> follow up patchsets. >>> >>> [...] >> >> Applied, thanks! >> >> [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC >> commit: 5d67b8f81b9d598599366214e3b2eb5f84003c9f > > You didn't honor (or even comment) Krzysztof's proposal to take the > whole patchset via his tree (marked above). Was there some off-list > agreement? > It was also written in the PWM patch itself (under changelog ---) and expressed with my "applied" response when I took everything. I am sending now another set, also touching PWM. Best regards, Krzysztof
On Tue, Nov 28, 2023 at 09:58:41PM +0100, Uwe Kleine-König wrote: > On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: > > > > On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > > > Merging > > > ======= > > > I propose to take entire patchset through my tree (Samsung SoC), because: > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), so > > > they will touch the same lines in some of the DT bindings (not all, though). > > > It is reasonable for me to take the bindings for the new SoCs, to have clean > > > `make dtbs_check` on the new DTS. > > > 2. Having it together helps me to have clean `make dtbs_check` within my tree > > > on the existing DTS. > > > 3. No drivers are affected by this change. > > > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect > > > follow up patchsets. > > > > > > [...] > > > > Applied, thanks! > > > > [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC > > commit: 5d67b8f81b9d598599366214e3b2eb5f84003c9f > > You didn't honor (or even comment) Krzysztof's proposal to take the > whole patchset via his tree (marked above). Was there some off-list > agreement? I had read all that and then looking at patchwork saw that you had marked all other patches in the series as "handled-elsewhere" and only this one was left as "new", so I assumed that, well, everything else was handled elsewhere and I was supposed to pick this one up... I'll drop this one. Thierry
Hello Thierry, On Tue, Dec 05, 2023 at 01:36:05PM +0100, Thierry Reding wrote: > On Tue, Nov 28, 2023 at 09:58:41PM +0100, Uwe Kleine-König wrote: > > On Tue, Nov 28, 2023 at 06:49:23PM +0100, Thierry Reding wrote: > > > > > > On Wed, 08 Nov 2023 11:43:26 +0100, Krzysztof Kozlowski wrote: > > > > Merging > > > > ======= > > > > I propose to take entire patchset through my tree (Samsung SoC), because: > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > > > 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), so > > > > they will touch the same lines in some of the DT bindings (not all, though). > > > > It is reasonable for me to take the bindings for the new SoCs, to have clean > > > > `make dtbs_check` on the new DTS. > > > > 2. Having it together helps me to have clean `make dtbs_check` within my tree > > > > on the existing DTS. > > > > 3. No drivers are affected by this change. > > > > 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect > > > > follow up patchsets. > > > > > > > > [...] > > > > > > Applied, thanks! > > > > > > [12/17] dt-bindings: pwm: samsung: add specific compatibles for existing SoC > > > commit: 5d67b8f81b9d598599366214e3b2eb5f84003c9f > > > > You didn't honor (or even comment) Krzysztof's proposal to take the > > whole patchset via his tree (marked above). Was there some off-list > > agreement? > > I had read all that and then looking at patchwork saw that you had > marked all other patches in the series as "handled-elsewhere" and only > this one was left as "new", so I assumed that, well, everything else was > handled elsewhere and I was supposed to pick this one up... I didn't mark it as handled-elsewhere, but my expectation was that you might want to send an Ack only. For today's series by Krzysztof I acked and marked the patch as handled-elsewhere (together with the rest of the series that isn't pwm related). So you have to consult your inbox if you still want to send an Ack for that one. Best regards Uwe
Hi, Merging ======= I propose to take entire patchset through my tree (Samsung SoC), because: 1. Next cycle two new SoCs will be coming (Google GS101 and ExynosAutov920), so they will touch the same lines in some of the DT bindings (not all, though). It is reasonable for me to take the bindings for the new SoCs, to have clean `make dtbs_check` on the new DTS. 2. Having it together helps me to have clean `make dtbs_check` within my tree on the existing DTS. 3. No drivers are affected by this change. 4. I plan to do the same for Tesla FSD and Exynos ARM32 SoCs, thus expect follow up patchsets. If folks agree, please kindly Ack the patches. Description =========== Samsung Exynos SoCs reuse several devices from older designs, thus historically we kept the old (block's) compatible only. This works fine and there is no bug here, however guidelines expressed in Documentation/devicetree/bindings/writing-bindings.rst state that: 1. Compatibles should be specific. 2. We should add new compatibles in case of bugs or features. Add compatibles specific to each SoC in front of all old-SoC-like compatibles. This will also help reviews of new code using existing DTS as template. No functional impact on Linux drivers behavior. Future ====== If reasonable, I will do similar work for Tesla FSD and ARMv7/ARM32 Exynos bindings and DTS. Best regards, Krzysztof Krzysztof Kozlowski (17): dt-bindings: hwinfo: samsung,exynos-chipid: add specific compatibles for existing SoC dt-bindings: i2c: exynos5: add specific compatibles for existing SoC dt-bindings: i2c: samsung,s3c2410-i2c: add specific compatibles for existing SoC dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for existing SoC dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC dt-bindings: rtc: s3c-rtc: add specific compatibles for existing SoC dt-bindings: serial: samsung: add specific compatibles for existing SoC dt-bindings: samsung: exynos-pmu: add specific compatibles for existing SoC dt-bindings: gpu: arm,mali-midgard: add specific compatibles for existing Exynos SoC dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC dt-bindings: pwm: samsung: add specific compatibles for existing SoC arm64: dts: exynos5433: add specific compatibles to several blocks arm64: dts: exynos7: add specific compatibles to several blocks arm64: dts: exynos7885: add specific compatibles to several blocks arm64: dts: exynos850: add specific compatibles to several blocks arm64: dts: exynosautov9: add specific compatibles to several blocks .../bindings/gpu/arm,mali-midgard.yaml | 5 ++ .../hwinfo/samsung,exynos-chipid.yaml | 17 +++++- .../devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++- .../bindings/i2c/samsung,s3c2410-i2c.yaml | 22 ++++--- .../bindings/iio/adc/samsung,exynos-adc.yaml | 29 +++++---- .../mfd/samsung,exynos5433-lpass.yaml | 2 +- .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 +++++--- .../samsung,pinctrl-wakeup-interrupt.yaml | 24 +++++--- .../bindings/pinctrl/samsung,pinctrl.yaml | 3 +- .../devicetree/bindings/pwm/pwm-samsung.yaml | 2 + .../devicetree/bindings/rtc/s3c-rtc.yaml | 5 ++ .../bindings/serial/samsung_uart.yaml | 14 ++++- .../bindings/soc/samsung/exynos-pmu.yaml | 6 ++ .../bindings/soc/samsung/exynos-usi.yaml | 2 +- .../bindings/sound/samsung-i2s.yaml | 19 +++--- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 60 ++++++++++++------- arch/arm64/boot/dts/exynos/exynos7.dtsi | 18 +++--- arch/arm64/boot/dts/exynos/exynos7885.dtsi | 45 +++++++++----- arch/arm64/boot/dts/exynos/exynos850.dtsi | 34 ++++++----- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 6 +- 20 files changed, 233 insertions(+), 115 deletions(-)