mbox series

[0/4] Add RZ/G2L pinctrl support

Message ID 20241205180924.154715-1-biju.das.jz@bp.renesas.com
Headers show
Series Add RZ/G2L pinctrl support | expand

Message

Biju Das Dec. 5, 2024, 6:09 p.m. UTC 
Add pin controller support for the Renesas RZ/G3E(R9A09G047) SoC. The
RZ/G3E PFC is similar to the RZ/V2H SoC but has more pins(P00-PS3).
The port number is alpha-numeric compared to the number on
the other SoCs.

This patch series depend upon [1]
[1]
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=914097

Biju Das (4):
  dt-bindings: pinctrl: renesas: Document RZ/G3E SoC
  pinctrl: renesas: rzg2l: Add support for RZ/G3E SoC
  arm64: dts: renesas: r9a09g047: Add pincontrol node
  arm64: dts: renesas: r9a09g047: Add scif pincontrol

 .../pinctrl/renesas,rzg2l-pinctrl.yaml        |   4 +-
 arch/arm64/boot/dts/renesas/r9a09g047.dtsi    |  13 ++
 .../boot/dts/renesas/r9a09g047e57-smarc.dts   |  13 ++
 drivers/pinctrl/renesas/Kconfig               |   1 +
 drivers/pinctrl/renesas/pinctrl-rzg2l.c       | 158 ++++++++++++++++++
 include/dt-bindings/pinctrl/rzg2l-pinctrl.h   |  25 +++
 6 files changed, 213 insertions(+), 1 deletion(-)

Comments

Biju Das Dec. 5, 2024, 8:25 p.m. UTC | #1 
Hi All,

> -----Original Message-----
> From: Rob Herring (Arm) <robh@kernel.org>
> Sent: 05 December 2024 19:35
> Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: renesas: Document RZ/G3E SoC
> 
> 
> On Thu, 05 Dec 2024 18:09:17 +0000, Biju Das wrote:
> > Add documentation for the pin controller found on the Renesas RZ/G3E
> > (R9A09G047) SoC. The RZ/G3E PFC is similar to the RZ/V2H SoC but has
> > more pins(P00-PS3). The port number is alpha-numeric compared to the
> > number on the other SoCs. So add macros for alpha-numeric to number conversion.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> >  .../pinctrl/renesas,rzg2l-pinctrl.yaml        |  4 ++-
> >  include/dt-bindings/pinctrl/rzg2l-pinctrl.h   | 25 +++++++++++++++++++
> >  2 files changed, 28 insertions(+), 1 deletion(-)
> >
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml:147:13: [error] duplication of
> key "const" in mapping (key-duplicates)
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-
> pinctrl.yaml: ignoring, error parsing file
> ./Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml:147:13: found duplicate key
> "const" with value "renesas,r9a09g057-pinctrl" (original value: "renesas,r9a09g047-pinctrl")
> make[2]: *** Deleting file 'Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-
> pinctrl.example.dts'
> Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml:147:13: found duplicate key
> "const" with value "renesas,r9a09g057-pinctrl" (original value: "renesas,r9a09g047-pinctrl")
> make[2]: *** [Documentation/devicetree/bindings/Makefile:26:
> Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.example.dts] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
> make: *** [Makefile:251: __sub-make] Error 2
> 
> doc reference errors (make refcheckdocs):
> 
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241205180924.154715-2-
> biju.das.jz@bp.renesas.com

Iam able to reproduce this issue and is fixed by
           contains:
-            const: renesas,r9a09g047-pinctrl
-            const: renesas,r9a09g057-pinctrl
+            enum:
+              - renesas,r9a09g047-pinctrl
+              - renesas,r9a09g057-pinctrl

I will fix this in next version.

Cheers,
Biju