From patchwork Sun Mar 9 08:47:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 871962 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67AC018E1F; Sun, 9 Mar 2025 08:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741510108; cv=none; b=pllSvSV3MMlCYw6Hl/x0+tdHnwDTNbqDotPcde67QXlxrHJuEetjhOLYBA1cVFqKq50cCX+lWKfFw9ZBYohAOeAENMHCraaBAeaoR08GbLT3XyXbGb7sAdjilLOl/orY8EeEYLc2Z3CBIMcHJ80K5w6j5tEdyqbACdDZPBjS6ME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741510108; c=relaxed/simple; bh=uPre4oTLY075H7ytM2SiW9AMN/odpcJY90t1k53KMzc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IOtojpOTrzBj0ZfU9KZXcmkBUaL2KF6u/hokPAWfSgDywhf+RfFqSXyczpJbglT0dIx998Ih79tzjxE814hbCiXMQY+uwDLeSbwKoTffSCJXOi9fjrTUOMaadAov0iQjSH/cR1LksfXooMcJipdIYYKtLfaH3aZNrSDdxWETpgg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mHVmUGis; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mHVmUGis" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-aaec111762bso615017966b.2; Sun, 09 Mar 2025 00:48:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741510105; x=1742114905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZVGcsUdrY4Ojxb0Wjt3O7HW8bB7/V56V860JdJdtjqA=; b=mHVmUGisfzahqUhYLkwUpBK8oqvbXfkleT3W1uvBZndBn76ID63DZQA9c9Y1+BuXII C0Hc7WTSvsR+SRxqQ8OLyvQG7giL1hBuTrojmGtuEHUV+8sij58t+RWKyFqrHUFjrNQ4 L+HNYIhaRy+tf0ts8VX8Z2RGBv3ZGFrW9b+TE6ah0zyBiPqLh9OOMX4T6JOWYksp2TO3 xu0EP95fuseMbnJ4wC0U6WwHLYRarZ27ghYnY1bID1RkhD21ibGOViYWhoU7DImcYLTD sMTeztNvsgr4AHNYBeHSvk1c9YpU4LdyNhdjgCoKtQav2vAIlsYqE6dXjNUhaa1FK9Cs nRQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741510105; x=1742114905; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZVGcsUdrY4Ojxb0Wjt3O7HW8bB7/V56V860JdJdtjqA=; b=uHBbuWxMA7TDAfE63sHEjltQYJPdXHESPmjL7QIQXXmKUTK+h009dQzKqJ7wmCXfEm XVAMM+/m/Gv0o8Lu4tXRcb0pnI7VMQu3jSAkbv+YOFjYr/0MWU04pWVFlu3IzV9x039l O1kDddhElRIpfdiGvzcvcg25/1hxV8UYsikQ9XGO+kyGmi788k/yLkNhDC/9JESeaDeC eC41WS+egSYDc2NXl7//stmWasakXPIC0z0KJTDr6MdKQnw4IdMIrGoWU1SmiuXZZfFT EaNvJT+2sG4r3d/rquDSTtgQ7dR8VFSp9RbjLF9D+6M9T/M5bGBFl9iGO8E7Zo+AIqG6 YmVQ== X-Forwarded-Encrypted: i=1; AJvYcCV3rzI5fowxzS556dKxS2FGn3gUWTb8KD05fAAe2/qIrG/u5e+m8B4t6QohKT4F9jFaJv3UTvrp5CXd3CI=@vger.kernel.org, AJvYcCWM0LSXLjquPstI8y88of0Rtv2xsbvEZhyvj3jkT6AFciZ4mEJQCEPjOtCtt+4Yb88p3jZwb1z+0WY6TItG@vger.kernel.org, AJvYcCX5hGuHpGGQ1r6iePH1f42UvCLnCpzsevpAhfQL8gLoyjziedu9PsZPggIUoiJ02hLHNj03rZ9WwQlB@vger.kernel.org, AJvYcCXz7jPxg/aiwmWltB3Y9ONwjc3FW8EJQqOdUoFlbMgEl+aEtxSDHRAe880sZExNQM/kS0M2A1Dq2U169A==@vger.kernel.org X-Gm-Message-State: AOJu0YzR+mkwqybxWQsMvNOStxeH1RVl/KTjpWyKadlXyxk9L0vWAUBq OKaTOji2DiZfUITgbGCh/P2McdaNbsKl9yv2u+u8pOiq9R3JNXMaWL/p7g== X-Gm-Gg: ASbGncvp8Gz1qEtqWR8zlicu48DZaVky0z53BfGf/lbN+gaKbZO3fERZ005EpdOPCA/ oPJB8rmIrLcYePwXO2WQRMRpfbgZMf75A11jPstimIUH4+palcqijegCMLvO5iaRjvajKgVh9rE 494oGVDwhOPUIfxPkejVSrGn99kfkEWu8IVg+/YrTAyIH81umpOiN40Kl/0iuJwURf4k2rvy4xm wpvaoRdc4ZMGyG6QxrbGDNOGtK5HJLMq+b3D+3DHdQld9+DETy6r02+ZL1hSsUbCH7PEWWaKzOw 2e7dWvfRAtG3yJsqm3+OBy40CT6ub8Auyk+5XRdL6xEQYf2vOfI8iFO1sQ== X-Google-Smtp-Source: AGHT+IHI4Zyfvvqb7frkRpwXvq+ngfIqgiZRQjrvqboXWAs52psPPFqtYXNUWfj7KjP1zDv7XZFEpw== X-Received: by 2002:a17:906:f590:b0:ab8:c215:fd27 with SMTP id a640c23a62f3a-ac252a9e65bmr864919566b.14.1741510104309; Sun, 09 Mar 2025 00:48:24 -0800 (PST) Received: from demon-pc.localdomain ([188.27.130.21]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac239736153sm566347466b.108.2025.03.09.00.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Mar 2025 00:48:23 -0800 (PST) From: Cosmin Tanislav To: Cc: Tomi Valkeinen , Cosmin Tanislav , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?utf-8?q?Niklas_S=C3=B6derlund?= , Julien Massot , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , Bjorn Andersson , Geert Uytterhoeven , Dmitry Baryshkov , Arnd Bergmann , Taniya Das , Biju Das , =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A?= =?utf-8?q?_=2E_Prado?= , Eric Biggers , Javier Carrasco , Ross Burton , Hans Verkuil , Sakari Ailus , Laurent Pinchart , Zhi Mao , Kieran Bingham , Dongcheng Yan , AngeloGioacchino Del Regno , Benjamin Mugnier , Tommaso Merciai , Dan Carpenter , Ihor Matushchak , Laurentiu Palcu , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-gpio@vger.kernel.org, Cosmin Tanislav Subject: [RFC PATCH v2 00/16] media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers Date: Sun, 9 Mar 2025 10:47:52 +0200 Message-ID: <20250309084814.3114794-1-demonsingur@gmail.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This series adds new drivers for multiple Maxim GMSL2 and GMSL3 devices, replacing the few GMSL2 drivers already in upstream, and introducing a common framework that can be used to implement such GMSL chips, which avoids code duplication while also adding support for previously unsupported features. While the normally acceptable and polite way would be to extend the current mainline drivers, the choice was made here to add a totally new set of drivers. The current drivers support only a small subset of the possible features, and only a few devices, so the end result after extending them would in any case be essentially fully rewritten, new drivers. This series depends on these two series: * https://lore.kernel.org/lkml/20250306-fpc202-v9-0-2779af6780f6@bootlin.com * https://lore.kernel.org/lkml/20250228151730.1874916-1-demonsingur@gmail.com The following deserializers are supported: * MAX96712 (already exists in staging) * MAX96714 (already exists) * MAX96716 (GMSL2) * MAX96724 (part of existing MAX96712 driver) * MAX9296A (GMSL2) * MAX96792A (GMSL3) The following serializers are supported: * MAX96717 (already exists) * MAX9295A (GMSL2) * MAX96793 (GMSL3) Missing features: * The current TPG implementation makes use of the V4L2_CID_TEST_PATTERN V4L2 control. With V4L2 streams support added, we would like to hook up TPG using the internal pad feature which has not been accepted upstream yet. We decided to leave TPG out for the moment and add it back after internal pads have been accepted. Known backward compatibility breakages: * No default routing. Default routing has been intentionally ommitted as the devices support quite complex routing and it would be unfeasible to provide sane defaults for multi-link deserialziers. It is expected that userspace programs would set appropritate routing. The following list enumerates new features that are supported by the common framework and their respective chip-specific drivers: * Full Streams API support. Most deserializers have support for more than one link, and more than one PHY. Streams support allows configuration of routing between these links and PHYs. * .get_frame_desc() support. Both the serializers and deserializers implement this to query and provide frame descriptor data. This is used in features explained in-depth below. * .get_mbus_config() support. The deserializers implement this to allow upstream devices to query the link frequency of its pads. * Address translation with I2C ATR for the serializers. * I2C MUX where supported by the hardware for deserializers, otherwise I2C ATR translation - some deserializers cannot do muxing since I2C communication channel masking is not available per-link, and the only other way to select links is to turn them off, causing link resets. For such cases, I2C ATR is used to change the address of the serializers at probe time. * Automatic VC remapping on the deserializers. VCs are picked so that if they were unique on the sink pad, they will end up as unique on the source pad they are routed to too, prioritizing using the same VC ID as the sink pad, to facilitate the possibility of using tunnel mode. * Automatic pixel mode / tunnel mode selection. Tunnel mode is used when VC IDs do not need to be changed and all hardware supports tunnel mode, otherwise, pixel mode is used. The serializers are automatically switched between the two by using a private API. * Automatic double mode selection. In pixel mode, double mode can be used to pack two pixels into a single data unit, optimizing bandwidth usage. The serializers are automatically set up to support the double modes determined by the deserializers using a private API. * Automatic data padding. In pixel mode, if the data being transferred uses two different BPPs, data needs to be padded. The serializers automatically set this up depending on the configured double mode settings and incoming data types. * Logging. Both the deserializers and serializers implement the V4L2 .log_status() ops to allow debugging of the internal state and important chip status registers. * PHY modes. Deserializer chips commonly have more than a single PHY. The firmware ports are parsed to determine the modes in which to configure the PHYs (2x4, 4x2, 1x4+2x2, 2x2+1x4, and variations using fewer lanes). * Serializer pinctrl. Serializers implement pinctrl to allow setting configs which would otherwise be inaccessible through GPIO: TX/RX via GMSL link, pull-up & pull-down (with strength), open-drain & push-pull, slew rate, RCLK pin selection. The drivers have been tested on the following hardware combinations, but further testing is welcome to ensure no / minimal breakage: * Raspberry Pi 5 + MAX96724 + 4xMAX96717 + 4xIMX219 * Raspberry Pi 5 + MAX96792A + 1xMAX96793 + 1xMAX96717 + 2xIMX219 * Raspberry Pi 5 + MAX96792A + 2xMAX96717 + 2xIMX219 * Renesas V4H + MAX96712 + 2xMAX96717 + 2xIMX219 Analog Devices is taking responsibility for the maintenance of these drivers and common framework, and plans to add support for new broad-market chips on top of them. Special thanks go to Tomi Valkeinen for testing the drivers, helping debug and coming up with ideas / implementations for various features. V2: * add missing compatible for MAX96717F * fix embarrassing dt-bindings mistakes * move MAX9296A/MAX96716/MAX96792A to a separate file as they have two links / PHYs, and adding those conditionally seems impossible Cosmin Tanislav (16): dt-bindings: media: i2c: max96717: add myself as maintainer dt-bindings: media: i2c: max96717: reflow text dt-bindings: media: i2c: max96717: add support for I2C ATR dt-bindings: media: i2c: max96717: add support for pinctrl/pinconf dt-bindings: media: i2c: max96717: add support for MAX9295A dt-bindings: media: i2c: max96717: add support for MAX96793 dt-bindings: media: i2c: max96712: add myself as maintainer dt-bindings: media: i2c: max96712: use pattern properties for ports dt-bindings: media: i2c: max96712: add support for I2C MUX dt-bindings: media: i2c: max96712: add support for POC supplies dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A media: i2c: add Maxim GMSL2/3 serializer and deserializer drivers arm64: defconfig: disable deprecated MAX96712 driver staging: media: remove MAX96712 driver media: i2c: remove MAX96717 driver media: i2c: remove MAX96714 driver .../bindings/media/i2c/maxim,max9296a.yaml | 281 ++ .../bindings/media/i2c/maxim,max96712.yaml | 47 +- .../media/i2c/maxim,max96717-pinctrl.yaml | 71 + .../bindings/media/i2c/maxim,max96717.yaml | 80 +- MAINTAINERS | 13 +- arch/arm64/configs/defconfig | 1 - drivers/media/i2c/Kconfig | 34 +- drivers/media/i2c/Makefile | 3 +- drivers/media/i2c/max96714.c | 1024 -------- drivers/media/i2c/max96717.c | 1103 -------- drivers/media/i2c/maxim-serdes/Kconfig | 53 + drivers/media/i2c/maxim-serdes/Makefile | 6 + drivers/media/i2c/maxim-serdes/max9296a.c | 1146 ++++++++ drivers/media/i2c/maxim-serdes/max96717.c | 1501 +++++++++++ drivers/media/i2c/maxim-serdes/max96724.c | 905 +++++++ drivers/media/i2c/maxim-serdes/max_des.c | 2321 +++++++++++++++++ drivers/media/i2c/maxim-serdes/max_des.h | 135 + drivers/media/i2c/maxim-serdes/max_ser.c | 1584 +++++++++++ drivers/media/i2c/maxim-serdes/max_ser.h | 132 + drivers/media/i2c/maxim-serdes/max_serdes.c | 302 +++ drivers/media/i2c/maxim-serdes/max_serdes.h | 88 + drivers/staging/media/Kconfig | 2 - drivers/staging/media/Makefile | 1 - drivers/staging/media/max96712/Kconfig | 14 - drivers/staging/media/max96712/Makefile | 2 - drivers/staging/media/max96712/max96712.c | 487 ---- 26 files changed, 8634 insertions(+), 2702 deletions(-) create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml delete mode 100644 drivers/media/i2c/max96714.c delete mode 100644 drivers/media/i2c/max96717.c create mode 100644 drivers/media/i2c/maxim-serdes/Kconfig create mode 100644 drivers/media/i2c/maxim-serdes/Makefile create mode 100644 drivers/media/i2c/maxim-serdes/max9296a.c create mode 100644 drivers/media/i2c/maxim-serdes/max96717.c create mode 100644 drivers/media/i2c/maxim-serdes/max96724.c create mode 100644 drivers/media/i2c/maxim-serdes/max_des.c create mode 100644 drivers/media/i2c/maxim-serdes/max_des.h create mode 100644 drivers/media/i2c/maxim-serdes/max_ser.c create mode 100644 drivers/media/i2c/maxim-serdes/max_ser.h create mode 100644 drivers/media/i2c/maxim-serdes/max_serdes.c create mode 100644 drivers/media/i2c/maxim-serdes/max_serdes.h delete mode 100644 drivers/staging/media/max96712/Kconfig delete mode 100644 drivers/staging/media/max96712/Makefile delete mode 100644 drivers/staging/media/max96712/max96712.c Acked-by: Rob Herring (Arm) Acked-by: Rob Herring (Arm) Reviewed-by: Rob Herring (Arm)