mbox series

[v4,0/2] ESWIN EIC7700 pinctrl driver

Message ID 20250515054524.390-1-luyulin@eswincomputing.com
Headers show
Series ESWIN EIC7700 pinctrl driver | expand

Message

Yulin Lu May 15, 2025, 5:45 a.m. UTC
Implements support for the Eswin eic7700 SoC pinctrl controller.
  Provides API to manage pinctrl for the eic7700 SoC.
  Integration with the Linux pinctrl subsystem for consistency and
  scalability.

  Supported chips:
    Eswin eic7700 SoC.

  Test:
    Tested this patch on the Sifive HiFive Premier P550 (which uses
    the EIC7700 SoC), including system boot, networking, EMMC, display,
    and other peripherals. The drivers for these modules all use the
    pinctrl module, so this verifies that this pinctrl driver
    patch is working properly.

---
Changes since V3:
- Added "Reviewed-by" tag of "Krzysztof Kozlowski"
- Corrected some incorrect spaces and blank lines in the YAML file.
- Link: https://lore.kernel.org/all/20250514080928.385-1-luyulin@eswincomputing.com/

Changes since V2:
- Added "Reviewed-by" tag of "Krzysztof Kozlowski"
- Address the comments from Krzysztof Kozlowski, some commit information are modified.
- Fixed some errors and warnings reported by the kernel test robot.
- Modified the usage of some labels and syntax in the YAML file, as well as the usage
  of the dev_err_probe function, to make their application scenarios more accurate.
- Link: https://lore.kernel.org/all/20250506090844.1516-1-luyulin@eswincomputing.com/

Changes since V1:
- Made overall modifications to the driver structure and the DTS writing style.
- Link: https://lore.kernel.org/all/20250325141311.758787-1-emil.renner.berthing@canonical.com/

Yulin Lu (2):
  dt-bindings: pinctrl: eswin: Document for EIC7700 SoC
  pinctrl: eswin: Add EIC7700 pinctrl driver

 .../pinctrl/eswin,eic7700-pinctrl.yaml        | 156 ++++
 drivers/pinctrl/Kconfig                       |  11 +
 drivers/pinctrl/Makefile                      |   1 +
 drivers/pinctrl/pinctrl-eic7700.c             | 702 ++++++++++++++++++
 4 files changed, 870 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/eswin,eic7700-pinctrl.yaml
 create mode 100644 drivers/pinctrl/pinctrl-eic7700.c

Comments

Krzysztof Kozlowski May 15, 2025, 11:11 a.m. UTC | #1
On 15/05/2025 07:45, Yulin Lu wrote:
>   Implements support for the Eswin eic7700 SoC pinctrl controller.
>   Provides API to manage pinctrl for the eic7700 SoC.
>   Integration with the Linux pinctrl subsystem for consistency and
>   scalability.
> 
>   Supported chips:
>     Eswin eic7700 SoC.
> 
>   Test:
>     Tested this patch on the Sifive HiFive Premier P550 (which uses
>     the EIC7700 SoC), including system boot, networking, EMMC, display,
>     and other peripherals. The drivers for these modules all use the
>     pinctrl module, so this verifies that this pinctrl driver
>     patch is working properly.
> 
> ---
> Changes since V3:
> - Added "Reviewed-by" tag of "Krzysztof Kozlowski"
> - Corrected some incorrect spaces and blank lines in the YAML file.
> - Link: https://lore.kernel.org/all/20250514080928.385-1-luyulin@eswincomputing.com/

Start using b4 so you will not introduce such errors like here.

Best regards,
Krzysztof