| Message ID | cover.1625227382.git.matthias.schiffer@ew.tq-group.com |
|---|---|
| Headers | show |
| Series | TQMx86: TQMx110EB and TQMxE40x MFD/GPIO support | expand |
On Fri, Jul 02, 2021 at 02:23:47PM +0200, Matthias Schiffer wrote: > The tqmx86 MFD driver was passing IRQ 0 for "no IRQ" in the past. This > causes warnings with newer kernels. > > Prepare the gpio-tqmx86 driver for the fixed MFD driver by handling a > missing IRQ properly. > > Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller") > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> The system i was using this on made use of interrupts, so i never tested with it missing. It is a shame platform_get_irq_optional() does something different to all the other _optional() calls :-( Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Fri, Jul 02, 2021 at 02:23:51PM +0200, Matthias Schiffer wrote: > Add the board IDs for the TQMx110EB and the TQMxE40x family. All use a > 24MHz LPC clock. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Fri, Jul 02, 2021 at 02:23:53PM +0200, Matthias Schiffer wrote: > All future TQMx86 modules should use a 24MHz LPC clock. Warn about > unknown boards, but assume this is the case. > > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Fri, 2021-07-02 at 15:41 +0200, Andrew Lunn wrote: > On Fri, Jul 02, 2021 at 02:23:46PM +0200, Matthias Schiffer wrote: > > Updated patch series: > > > > - A number of new patches (more hardware support and a few fixes) > > - Patches 1-3 have gained Fixes tags > > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the > > MFD tree to keep them together? > > - The change in patch 7 was somewhat controversial. I've added a > > warning, but it is the last patch of the series, so it doesn't affect > > the rest of the series if it is rejected. > > Hi Matthias > > Nice to see the vendor involved. That does not happen enough. > > Please split these into fixes and new features. They go into different > trees, so splitting them makes it easier for the maintainers. > > I would also suggest splitting the patches per subsystem, and send > them to the specific subsystem maintainer. The exception would be when > there is cross subsystem dependencies. > > Andrew Hi Andrew, thanks for the quick review. As mentioned in the cover letter, patch 2 depends on 1, so I think it would make sense to push all through the MFD tree, including the GPIO fix. I guess patches 5 and 6 would be covered by the "new device IDs and quirks" rule of the stable kernel rules. Does that mean they should also go through the "fixes" rather than the "next" branch, making 4 and 7 the only ones for "next"? Should I add "Cc: stable@vger.kernel.org" to all patches for the "fixes" tree? Kind regards, Matthias
On Fri, 02 Jul 2021, Matthias Schiffer wrote: > Updated patch series: > > - A number of new patches (more hardware support and a few fixes) > - Patches 1-3 have gained Fixes tags > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the > MFD tree to keep them together? > - The change in patch 7 was somewhat controversial. I've added a > warning, but it is the last patch of the series, so it doesn't affect > the rest of the series if it is rejected. > > > Matthias Schiffer (7): > gpio: tqmx86: really make IRQ optional > mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set > mfd: tqmx86: remove incorrect TQMx90UC board ID > mfd: tqmx86: fix typo in "platform" > mfd: tqmx86: add support for TQMx110EB and TQMxE40x > mfd: tqmx86: add support for TQ-Systems DMI IDs > mfd: tqmx86: assume 24MHz LPC clock for unknown boards > > drivers/gpio/gpio-tqmx86.c | 6 ++--- > drivers/mfd/tqmx86.c | 48 ++++++++++++++++++++++++++++++-------- > 2 files changed, 41 insertions(+), 13 deletions(-) Patches look good. Could you please collect up Andrew's acks, remove the suggested Fixes: lines and resubmit please? I'll quickly apply them once resent (probably Monday - if you get them out today). -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
On Fri, 2021-07-16 at 10:20 +0100, Lee Jones wrote: > On Fri, 02 Jul 2021, Matthias Schiffer wrote: > > > Updated patch series: > > > > - A number of new patches (more hardware support and a few fixes) > > - Patches 1-3 have gained Fixes tags > > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the > > MFD tree to keep them together? > > - The change in patch 7 was somewhat controversial. I've added a > > warning, but it is the last patch of the series, so it doesn't affect > > the rest of the series if it is rejected. > > > > > > Matthias Schiffer (7): > > gpio: tqmx86: really make IRQ optional > > mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set > > mfd: tqmx86: remove incorrect TQMx90UC board ID > > mfd: tqmx86: fix typo in "platform" > > mfd: tqmx86: add support for TQMx110EB and TQMxE40x > > mfd: tqmx86: add support for TQ-Systems DMI IDs > > mfd: tqmx86: assume 24MHz LPC clock for unknown boards > > > > drivers/gpio/gpio-tqmx86.c | 6 ++--- > > drivers/mfd/tqmx86.c | 48 ++++++++++++++++++++++++++++++-------- > > 2 files changed, 41 insertions(+), 13 deletions(-) > > Patches look good. > > Could you please collect up Andrew's acks, remove the suggested Fixes: > lines and resubmit please? Are you referring to the Fixes: line in "[PATCH v2 3/7] mfd: tqmx86: remove incorrect TQMx90UC board ID"? > > I'll quickly apply them once resent (probably Monday - if you get them > out today). > Thanks, I'll try to get it done today.
On Fri, 16 Jul 2021, Matthias Schiffer wrote: > On Fri, 2021-07-16 at 10:20 +0100, Lee Jones wrote: > > On Fri, 02 Jul 2021, Matthias Schiffer wrote: > > > > > Updated patch series: > > > > > > - A number of new patches (more hardware support and a few fixes) > > > - Patches 1-3 have gained Fixes tags > > > - Patch 2 depends on 1, so maybe we can push the GPIO patch through the > > > MFD tree to keep them together? > > > - The change in patch 7 was somewhat controversial. I've added a > > > warning, but it is the last patch of the series, so it doesn't affect > > > the rest of the series if it is rejected. > > > > > > > > > Matthias Schiffer (7): > > > gpio: tqmx86: really make IRQ optional > > > mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set > > > mfd: tqmx86: remove incorrect TQMx90UC board ID > > > mfd: tqmx86: fix typo in "platform" > > > mfd: tqmx86: add support for TQMx110EB and TQMxE40x > > > mfd: tqmx86: add support for TQ-Systems DMI IDs > > > mfd: tqmx86: assume 24MHz LPC clock for unknown boards > > > > > > drivers/gpio/gpio-tqmx86.c | 6 ++--- > > > drivers/mfd/tqmx86.c | 48 ++++++++++++++++++++++++++++++-------- > > > 2 files changed, 41 insertions(+), 13 deletions(-) > > > > Patches look good. > > > > Could you please collect up Andrew's acks, remove the suggested Fixes: > > lines and resubmit please? > > Are you referring to the Fixes: line in "[PATCH v2 3/7] mfd: tqmx86: > remove incorrect TQMx90UC board ID"? I'm referring to the lines that Andrew said did not qualify. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog