From patchwork Tue Nov 26 13:32:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 21780 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f200.google.com (mail-vc0-f200.google.com [209.85.220.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CB60B202E0 for ; Tue, 26 Nov 2013 13:32:59 +0000 (UTC) Received: by mail-vc0-f200.google.com with SMTP id hu19sf12455356vcb.11 for ; Tue, 26 Nov 2013 05:32:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=zZ45rdtsTdxkfVjNBy2NhuSC5UmysWZmUONIja13ElA=; b=DsGz7VBiJza9JYhWOk9oPfGtijvCSPBi0HfAKV+0XRN+uvXQTALnUMNQGjjVvZEhgA Ifz//LXLzOBQyh9JXXncP3kEcZ4v/H7Cr1SxMcAXDtc5fuu2cPDJdwyLY6CGDUWQjgN1 iD6ti0xWbd/NroEu81OYWqN5ZcfaYCyUj2Eijxq3Rl5PW27lv5fDvRDVsfE+3pQ/ddRy rw7Fei6xCKg34wAMQEgXPlM+y91NzD9BQigs0+74QBvByWiMRAx4goPIeRBDUUnnTJAS zDkpJAXlOdnSE82dQR7ONdtnbXbyzAV+W3dxVTU52lbsjwSvbc/2VrQwEYTjoBjTOyrx ro6A== X-Gm-Message-State: ALoCoQkhDOvVSx8mvytJmDr1jmv/0nwtlhZ3Jm365fMaWliMhyWk9l2VGYi6LZ/ScEq9Mr8Wbw1U X-Received: by 10.236.209.134 with SMTP id s6mr14334637yho.40.1385472779120; Tue, 26 Nov 2013 05:32:59 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.3.106 with SMTP id b10ls2519167qeb.40.gmail; Tue, 26 Nov 2013 05:32:59 -0800 (PST) X-Received: by 10.220.58.1 with SMTP id e1mr30636725vch.0.1385472778993; Tue, 26 Nov 2013 05:32:58 -0800 (PST) Received: from mail-ve0-f176.google.com (mail-ve0-f176.google.com [209.85.128.176]) by mx.google.com with ESMTPS id vi1si18666609vcb.19.2013.11.26.05.32.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Nov 2013 05:32:58 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.176; Received: by mail-ve0-f176.google.com with SMTP id oz11so3926385veb.21 for ; Tue, 26 Nov 2013 05:32:58 -0800 (PST) X-Received: by 10.52.243.138 with SMTP id wy10mr25855928vdc.2.1385472778889; Tue, 26 Nov 2013 05:32:58 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp212889vcz; Tue, 26 Nov 2013 05:32:58 -0800 (PST) X-Received: by 10.152.5.163 with SMTP id t3mr4680864lat.39.1385472777745; Tue, 26 Nov 2013 05:32:57 -0800 (PST) Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com [209.85.217.172]) by mx.google.com with ESMTPS id yg9si17464151lbb.98.2013.11.26.05.32.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Nov 2013 05:32:57 -0800 (PST) Received-SPF: neutral (google.com: 209.85.217.172 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=209.85.217.172; Received: by mail-lb0-f172.google.com with SMTP id z5so4397211lbh.17 for ; Tue, 26 Nov 2013 05:32:57 -0800 (PST) X-Received: by 10.152.116.46 with SMTP id jt14mr5187380lab.31.1385472776884; Tue, 26 Nov 2013 05:32:56 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id r10sm45372812lag.7.2013.11.26.05.32.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2013 05:32:56 -0800 (PST) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Alexandre Courbot , Linus Walleij , David Cohen , Mika Westerberg , Mathias Nyman , Dan Carpenter Subject: [PATCH] gpio: drop users of irq_set_chip_and_handler_name() Date: Tue, 26 Nov 2013 14:32:51 +0100 Message-Id: <1385472771-26681-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: linus.walleij@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Switch all users of irq_set_chip_and_handler_name() to simply use irq_set_chip_and_handler(), all just provide a boilerplate name like "demux" or "mux" - a fact which is anyway obvious from the hwirq number from the irqdomain now present in e.g. /proc/interrupts. Cc: David Cohen Cc: Mika Westerberg Cc: Mathias Nyman Cc: Dan Carpenter Signed-off-by: Linus Walleij --- I'm challenging all users of this function to make an argument for it to stay in, and suspecting that this is mostly a copy and paste artifact... --- drivers/gpio/gpio-intel-mid.c | 3 +-- drivers/gpio/gpio-lynxpoint.c | 3 +-- drivers/gpio/gpio-msic.c | 7 +++---- drivers/gpio/gpio-timberdale.c | 4 ++-- 4 files changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c index be803af658ac..17f135046c7f 100644 --- a/drivers/gpio/gpio-intel-mid.c +++ b/drivers/gpio/gpio-intel-mid.c @@ -358,8 +358,7 @@ static int intel_gpio_irq_map(struct irq_domain *d, unsigned int irq, { struct intel_mid_gpio *priv = d->host_data; - irq_set_chip_and_handler_name(irq, &intel_mid_irqchip, - handle_simple_irq, "demux"); + irq_set_chip_and_handler(irq, &intel_mid_irqchip, handle_simple_irq); irq_set_chip_data(irq, priv); irq_set_irq_type(irq, IRQ_TYPE_NONE); diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c index f1ca9d5880b6..89867ed7bd50 100644 --- a/drivers/gpio/gpio-lynxpoint.c +++ b/drivers/gpio/gpio-lynxpoint.c @@ -331,8 +331,7 @@ static int lp_gpio_irq_map(struct irq_domain *d, unsigned int irq, { struct lp_gpio *lg = d->host_data; - irq_set_chip_and_handler_name(irq, &lp_irqchip, handle_simple_irq, - "demux"); + irq_set_chip_and_handler(irq, &lp_irqchip, handle_simple_irq); irq_set_chip_data(irq, lg); irq_set_irq_type(irq, IRQ_TYPE_NONE); diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c index d75eaa3a1dcc..69d60ab1d698 100644 --- a/drivers/gpio/gpio-msic.c +++ b/drivers/gpio/gpio-msic.c @@ -305,10 +305,9 @@ static int platform_msic_gpio_probe(struct platform_device *pdev) for (i = 0; i < mg->chip.ngpio; i++) { irq_set_chip_data(i + mg->irq_base, mg); - irq_set_chip_and_handler_name(i + mg->irq_base, - &msic_irqchip, - handle_simple_irq, - "demux"); + irq_set_chip_and_handler(i + mg->irq_base, + &msic_irqchip, + handle_simple_irq); } irq_set_chained_handler(mg->irq, msic_gpio_irq_handler); irq_set_handler_data(mg->irq, mg); diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c index 7a0e956ef1ed..521971e6a9f5 100644 --- a/drivers/gpio/gpio-timberdale.c +++ b/drivers/gpio/gpio-timberdale.c @@ -290,8 +290,8 @@ static int timbgpio_probe(struct platform_device *pdev) return 0; for (i = 0; i < pdata->nr_pins; i++) { - irq_set_chip_and_handler_name(tgpio->irq_base + i, - &timbgpio_irqchip, handle_simple_irq, "mux"); + irq_set_chip_and_handler(tgpio->irq_base + i, + &timbgpio_irqchip, handle_simple_irq); irq_set_chip_data(tgpio->irq_base + i, tgpio); #ifdef CONFIG_ARM set_irq_flags(tgpio->irq_base + i, IRQF_VALID | IRQF_PROBE);