From patchwork Thu Apr 9 15:18:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ivan T. Ivanov" X-Patchwork-Id: 46964 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 157AB21416 for ; Thu, 9 Apr 2015 15:19:01 +0000 (UTC) Received: by lbbrr5 with SMTP id rr5sf25122219lbb.3 for ; Thu, 09 Apr 2015 08:18:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=HMCZ8pPvcGvIlzqCNQdyG//dSO9VIXd/hRhUskxa4io=; b=m900VxKjMBVO0XxCJHlurBUKobCu9s9C8ayTR5PNNycW+aeY/REmOfIrz0+Q83rTXc jpA5vGs3Oz8wPHMxRVdBeIqoyM1dS/TEbYC4WV+FqRfmQn9yulfXb8mWFCsgxy8fhg8Q bl+ReA91UXsWEdqVJzJe772skNP7OBMN/noXzG90fFuk/qUn26VsMrLcai2EoG5q+kYw m829VKoqeVpy9VDkbTSFQQjDtpQ6l1AysvFiYHVoqaoVPhXPISNi5m8KtK2r1SY6+Mvu EOA84dt3eMLhrkGDF3t0T1QReSvbFvgCTKDRKRLGEE/WBQvw/kiHw2mzXrVzLaaUT0Lb 6+ig== X-Gm-Message-State: ALoCoQk4jADPBsMJPP67DERlKRrbb1/yOYJ0EvfQk9eIEz3BB+1Iekmz3wNT+KIMDXVMFza4sgwd X-Received: by 10.180.74.197 with SMTP id w5mr706446wiv.5.1428592739947; Thu, 09 Apr 2015 08:18:59 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.184.8 with SMTP id eq8ls364984lac.91.gmail; Thu, 09 Apr 2015 08:18:59 -0700 (PDT) X-Received: by 10.152.8.17 with SMTP id n17mr5044450laa.63.1428592739651; Thu, 09 Apr 2015 08:18:59 -0700 (PDT) Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com. [209.85.217.175]) by mx.google.com with ESMTPS id f12si11682650lbm.108.2015.04.09.08.18.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Apr 2015 08:18:59 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) client-ip=209.85.217.175; Received: by lbbuc2 with SMTP id uc2so90244507lbb.2 for ; Thu, 09 Apr 2015 08:18:59 -0700 (PDT) X-Received: by 10.112.141.202 with SMTP id rq10mr28691096lbb.88.1428592739544; Thu, 09 Apr 2015 08:18:59 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp535663lbt; Thu, 9 Apr 2015 08:18:58 -0700 (PDT) X-Received: by 10.68.138.230 with SMTP id qt6mr56941829pbb.66.1428592737819; Thu, 09 Apr 2015 08:18:57 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id zn2si21576839pbc.102.2015.04.09.08.18.56; Thu, 09 Apr 2015 08:18:57 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755766AbbDIPSx (ORCPT + 27 others); Thu, 9 Apr 2015 11:18:53 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36429 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755505AbbDIPSl (ORCPT ); Thu, 9 Apr 2015 11:18:41 -0400 Received: by wizk4 with SMTP id k4so96435115wiz.1 for ; Thu, 09 Apr 2015 08:18:40 -0700 (PDT) X-Received: by 10.180.87.101 with SMTP id w5mr7107617wiz.18.1428592720605; Thu, 09 Apr 2015 08:18:40 -0700 (PDT) Received: from localhost.localdomain ([37.157.136.206]) by mx.google.com with ESMTPSA id ed14sm10383483wic.11.2015.04.09.08.18.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Apr 2015 08:18:39 -0700 (PDT) From: "Ivan T. Ivanov" To: Linus Walleij Cc: Bjorn Andersson , Arnd Bergmann , Soren Brinkmann , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 1/3] pinctrl: qcom-spmi-gpio: Fix output type configuration Date: Thu, 9 Apr 2015 18:18:35 +0300 Message-Id: <1428592717-21706-1-git-send-email-ivan.ivanov@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ivan.ivanov@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , GPIO output type configuration was incorrectly overwritten by strength value. Fix this. Signed-off-by: Ivan T. Ivanov --- drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index b2d2221..4b21aac 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -417,7 +417,7 @@ static int pmic_gpio_config_set(struct pinctrl_dev *pctldev, unsigned int pin, return ret; val = pad->buffer_type << PMIC_GPIO_REG_OUT_TYPE_SHIFT; - val = pad->strength << PMIC_GPIO_REG_OUT_STRENGTH_SHIFT; + val |= pad->strength << PMIC_GPIO_REG_OUT_STRENGTH_SHIFT; ret = pmic_gpio_write(state, pad, PMIC_GPIO_REG_DIG_OUT_CTL, val); if (ret < 0)