From patchwork Tue May 30 09:11:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 100696 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp120079qge; Tue, 30 May 2017 02:13:24 -0700 (PDT) X-Received: by 10.84.216.15 with SMTP id m15mr44310280pli.33.1496135604059; Tue, 30 May 2017 02:13:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496135604; cv=none; d=google.com; s=arc-20160816; b=fBts4nataD5zcS/trMNQ2uOV9flRLrybGHqraQsvj20jBKOZhF1w6wm6tjhlilt0kK WUvL5WFgKCAuT6GpzmNJVy0EGFa5yDRGBv77AVjrYeNYLMPbt2bMqSwcu4Q/Xscc0Qvt ch2U/+c8SZWg8NCwQ0C3rOLNiGgd73wnJrP20mDxW0qvcE4n2t8U2cRZQ2bIh5us/IOp MCwlv7DLxqRYai0WJUYoT3dLI9N2lcBKX6CWvIpc2b8lHs8JcBuXeh0j4Wgtxwj5Lir+ FSREV28OEhm1aPkd2mxnPWaW2OOUVV3kQXho4h0Hpz/T78itxNAQ0nGzd8xbJmKwJybP S9Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ulOM8PXrye+oTfYuAIreZ8x3xkPYU0g3HeYinXvPqjU=; b=XJfxVXFfrNIDLWGMliT2GTdtDiYpMhZojT4r9QikwrlhSPPSosetK0ZVSFMPSycu+u KM7OMiBmzOtj2WzwuBSDAumuV6AF6urXDstgjDQ07QCekUGHwKKhQWkk560zQ+NGmOUG 2X/8Ii8/hYJnKE6nWLYQpbLxhHzA36m152dAiHNTXN6luQbetrMFt9CdCgSPyyU4NapG jLWCTX7OqE7QlqEu9GaK6k25TyM/rBx+Wg57xd+prfUVbcQMKeGPJDVZRFP0QpTQd7Pr PwaATxyOnErNDZX+HdQn+4jWIk3tA8u7PVQwi9AQU8mX7OJOY3nqGJoA0EdP4HNb5yCK IehA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i126si12646851pgd.376.2017.05.30.02.13.23; Tue, 30 May 2017 02:13:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751177AbdE3JNX (ORCPT + 4 others); Tue, 30 May 2017 05:13:23 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:64248 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdE3JNW (ORCPT ); Tue, 30 May 2017 05:13:22 -0400 Received: from wuerfel.lan ([78.42.17.5]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0LvAna-1dyLdO2iY6-010Ovy; Tue, 30 May 2017 11:13:16 +0200 From: Arnd Bergmann To: Linus Walleij Cc: Arnd Bergmann , Sebastian Reichel , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: mcp23s08: improve I2C Kconfig dependency Date: Tue, 30 May 2017 11:11:28 +0200 Message-Id: <20170530091314.891224-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:uDG61ZnBj9pAbCvxnS+knY9eyGJjHHg7McM6DKITyAeR4aT27nd HiKaP9EIZKjCtcfx2JSMjrldPxcufbz5xHAwYWSiYotvNIqJKEgn1hVRgyHobm/6lT2uKW8 JYYH5K1TeNNnF03AyZCRFEQhhv3YSYLb292XHlbmrH5bh6quDNIy7trJFOMF+nBUt5Ao/sR IQTTvkbhw8ps/3SDcU2mA== X-UI-Out-Filterresults: notjunk:1; V01:K0:nu5qao5RzGM=:EjD/XYKQ5idysGLFvc1Zql CR7AitrchzNZ5dMQsWtE2OPByauYY2iaWFp7twVqLcX4zR65/10MRWfgxwruJ2pdQTLvDE2ZU r0NaF9cw1Zsdu4/vvmKSnCr2XnAuRKLebg7KqZyChNjb9dUfKsSJpjNykiS7ZSyLFQFMTklab HRw+EKgM7uwjL61gk+656xbG1ZnJm3fpDTNriPfUxE8DzTy0OX2rGs2JdSG7eHbFzPV1Hql8t pQVTyOR/ppWFOmaJounXKySlAZihcd4SPbvshdncM3sadh5095X3X/xe8I3jXSHrQnWCIx7lE Dpps0FOXucmj8tZ4+2k1WRmu+7BaLiWlEzPpnnIClIiiN8uRxdTuQAc5IqCSMDHsWPqylmMrt mtMR2p2mTXsGml8We4yUBSVd39KamHnidzjMQniczyXc+kD3t9U42jEZobhjRds4HmINuDc6R Sxr84Semxitb9Id5umBTgc88gNmqgxQBQu0EoIEL1k0OKxqIsPkBgDFidxH6VnSkejXf7bWzg qES7wA17FQotHT5gv8HdUAI9+a9Bu8AYrhokGCpCmIiKF49LkTLy1BZCfuQwb7bz2SQXUucTY tleCEB5ZQ6PPP1raQX919bI94LWO6FwLu1Gt+l0hNJTnkR8MzeAGEkCpw3SHAOGLHbl9cGJyE RCKm5a6dqphl9Bzpe+BsterRmS2WjLsfa/H+zoZWuNP88i7RFiF+WH4ryltoU7Cyq66I= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org With "SPI_MASTER=y && I2C=m", we can build mcp23s08 as a built-in driver, which then results in a link failure: drivers/pinctrl/built-in.o: In function `mcp23s08_probe_one.isra.0': :(.text+0x7910): undefined reference to `__devm_regmap_init_i2c' drivers/pinctrl/built-in.o: In function `mcp23s08_init': :(.init.text+0x110): undefined reference to `i2c_register_driver' drivers/pinctrl/built-in.o: In function `mcp23s08_exit': :(.exit.text+0x3c): undefined reference to `i2c_del_driver' To avoid the problem, this adds another dependency on I2C that enforces mcp23s08 to be a loadable module whenever the I2C core is a module. Fixes: 64ac43e6fa28 ("gpio: mcp23s08: move to pinctrl") Signed-off-by: Arnd Bergmann --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Sebastian Reichel diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index becda8f47e9e..ab4630ea305c 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -149,6 +149,7 @@ config PINCTRL_FALCON config PINCTRL_MCP23S08 tristate "Microchip MCP23xxx I/O expander" depends on SPI_MASTER || I2C + depends on I2C || I2C=n select GPIOLIB_IRQCHIP select REGMAP_I2C if I2C select REGMAP_SPI if SPI_MASTER