From patchwork Tue Sep 19 19:04:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 113060 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp5278055qgf; Tue, 19 Sep 2017 12:07:07 -0700 (PDT) X-Received: by 10.99.3.9 with SMTP id 9mr2250987pgd.205.1505848027284; Tue, 19 Sep 2017 12:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505848027; cv=none; d=google.com; s=arc-20160816; b=1Kjd2pFIrS6A7OYzYg1LwUvRuN4j/kNwHRO9g3b5qmdEfJw2Voc4dZAEJGdO+tRVUD lRcuALGCDi627qbWKbqbJmXxvGfR1eIL8NRatOBXt4K9a6ONy42ZaPA/5jIoWz6ynlCV 24znM9Gf2pidf1/9QL74F2nG7HTDYUZyAir9TNPM1tYNchKlVM4lXjPOc7DF0bpcY3vC DbWLLDsfnLwBfu5+lmnysDlNORnOu+oJi5/srUnkGTs92ezUT7XuJM0h7YgPGBab86Jk KfSQoSCSKFjq4I7TvTr5JFiQ4p68XaZpOMqfnsM60U70r8Lobz4tp10cEXvnebuBA0nG /45A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=TT/J5u5gXjPXw91DivHg7tIvmf6CaJrLPxQ6wV2rZUw=; b=hWRZu9y0wbVL9tL0wt8tgPWnDIGVpY3ph2Fi3gBYiHbtZWTEN01bjX0F43lEoeHKm0 j/3fXBhaCMWztj3iXBy08zKOO0q5s8dc7aHwQtmFS1YO3NNBzSj8LSs1tPaeAICH2yZy bEv1ghKfKVc2hQr+ZG1h1ilRdcyhs+/qImuw1LP46CsJYy8Hmpszmkryd9+d9lMAllX3 RE5dzoIVeIvHwskr6PicilhYI/4KSQ7W2Ys3abmYZK0cDdRWHP6CjtIA70SpJV1I6oww 4X50vmEodHuawMHC2VpPqfm56Z5dBkJiPhIi9eU6BgdrEUEZ2h6nKTWomxm85VbWXgTw tknw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=YBHfEjcc; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u67si1874064pgc.747.2017.09.19.12.07.07; Tue, 19 Sep 2017 12:07:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=YBHfEjcc; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751000AbdISTHG (ORCPT + 5 others); Tue, 19 Sep 2017 15:07:06 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36743 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938AbdISTHF (ORCPT ); Tue, 19 Sep 2017 15:07:05 -0400 Received: by mail-wr0-f196.google.com with SMTP id g50so288191wra.3; Tue, 19 Sep 2017 12:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6AHbkOUP64/LW8PY4PfX/CpGS2ATDkUuq1rQFNvbWV0=; b=YBHfEjccdRfeGKtEXjSafqA53CON/X4Xh5AJRIQM8S78cVmzVTy5Ql/QzPqtdCSroz FpJRR8t8m8EOsgVdHoRcVnyVdsSmi/bfFJbmnQscSsq51wweSvBdv5wXhE6RAU/nNSvL Q9VJYihByD7/G1+aDNiOmYfj10ERFEPkt8DLBOtVdcsG413AA3B+4saVRirKn2Ja/w4C UTuvfl9JOS5A6NOA44kDaqVUDLxGxKDjqhrhr8RejQxy4Tx+A77Ne0b9cpqWStAQhu7d shDfL0Tf4Wol6OBA5swu8/E5OFu6Y5M3Eilyag2gElUM8jgpB/tj/upMSruL6FU5RsJz DVwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6AHbkOUP64/LW8PY4PfX/CpGS2ATDkUuq1rQFNvbWV0=; b=O3P/nAl4OMKAWGcINr7m9Sedgt5ja9AYOlr81IGs6945EtZjGjQX4kOcNyzQWJYQ+7 AME4k3yUWl5+d5t38BKCkP9QhCfhLdBkFvbh7qNzd4PXx7QGWrAzw/YY0TGTWfysvw8Y Uljy1ca2tPbGUsfz2IG7lRRqigcCtj0O+7zVz6rY9aQUkWtWzNJJ8YiATIWKTDtXdgpc HfKDuuaCRxCureSGeUYb2U21Gm0NpdNE2mLu4lzlC9tDLLcS89tprg9MYe/GhSLfk8Jq EGml4bGQxnnucyYkyQx818eSdIs3mYSKI/twRtlNWnJsEW33HPojTR+HEvh6ulKyUHES 0bxQ== X-Gm-Message-State: AHPjjUg9VlZI39lkhW36Jlk94kcbXW+rgjxFg+OgglX5ld0vO2RHckKJ 7pa2X/Bslzhp9TmqqPLHivQ= X-Google-Smtp-Source: AOwi7QCmSoVDFlg2JhjRlq3Pkh39AQZp51NYRdfACvLWliAhoNBR3RSDbnRye8RUl9olhEPOdUqn/Q== X-Received: by 10.223.151.54 with SMTP id r51mr2450286wrb.207.1505848024336; Tue, 19 Sep 2017 12:07:04 -0700 (PDT) Received: from Red.local (LFbn-MAR-1-580-96.w90-118.abo.wanadoo.fr. [90.118.159.96]) by smtp.googlemail.com with ESMTPSA id w5sm16463wrg.65.2017.09.19.12.07.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Sep 2017 12:07:03 -0700 (PDT) From: Corentin Labbe To: linus.walleij@linaro.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, eric@anholt.net, stefan.wahren@i2se.com Cc: linux-gpio@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Corentin Labbe Subject: [PATCH] pinctrl: bcm2835: fix build warning in bcm2835_gpio_irq_handle_bank Date: Tue, 19 Sep 2017 21:04:56 +0200 Message-Id: <20170919190456.26522-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.5 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This patch fix the following build warning: drivers/pinctrl/bcm/pinctrl-bcm2835.c:376:15: warning: variable 'type' set but not used [-Wunused-but-set-variable] Furthermore, it is unused for a long time, at least since commit 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP") where a "FIXME no clue why the code looks up the type here" was added. A year after, nobody answeered this question, so its time to remove it. Signed-off-by: Corentin Labbe --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.13.5 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Acked-by: Stefan Wahren diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index 0944310225db..ff782445dfb7 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -373,16 +373,12 @@ static void bcm2835_gpio_irq_handle_bank(struct bcm2835_pinctrl *pc, unsigned long events; unsigned offset; unsigned gpio; - unsigned int type; events = bcm2835_gpio_rd(pc, GPEDS0 + bank * 4); events &= mask; events &= pc->enabled_irq_map[bank]; for_each_set_bit(offset, &events, 32) { gpio = (32 * bank) + offset; - /* FIXME: no clue why the code looks up the type here */ - type = pc->irq_type[gpio]; - generic_handle_irq(irq_linear_revmap(pc->gpio_chip.irqdomain, gpio)); }