diff mbox series

[2/2] gpio: pca953x: Fix pca953x_gpio_set_config

Message ID 20200412013352.674506-2-aford173@gmail.com
State New
Headers show
Series None | expand

Commit Message

Adam Ford April 12, 2020, 1:33 a.m. UTC
pca953x_gpio_set_config is setup to support pull-up/down
bias.  Currently the driver uses a variable called 'config' to
determine which options to use.  Unfortunately, this is incorrect.

This patch uses function pinconf_to_config_param(config), which
converts this 'config' parameter back to pinconfig to determine
which option to use.

Fixes: 15add06841a3 ("gpio: pca953x: add ->set_config implementation")

Signed-off-by: Adam Ford <aford173@gmail.com>
diff mbox series


diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 5638b4e5355f..4269ea9a817e 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -531,7 +531,7 @@  static int pca953x_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
 	struct pca953x_chip *chip = gpiochip_get_data(gc);
-	switch (config) {
+	switch (pinconf_to_config_param(config)) {
 		return pca953x_gpio_set_pull_up_down(chip, offset, config);