From patchwork Thu Sep 10 02:56:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 254406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE5C6C43461 for ; Thu, 10 Sep 2020 02:58:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75CAA21D6C for ; Thu, 10 Sep 2020 02:58:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="WoIbRmFo"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="K68zuYHJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729865AbgIJC6I (ORCPT ); Wed, 9 Sep 2020 22:58:08 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53671 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729781AbgIJC5l (ORCPT ); Wed, 9 Sep 2020 22:57:41 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6AA4B5C018A; Wed, 9 Sep 2020 22:57:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 09 Sep 2020 22:57:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=dgZLZNVKsJXTQ b5CVCCPBkn89T6dD0JdMbFAfUWYzyY=; b=WoIbRmFoNgdsdl4Mx/dKhsrX8fQdS 5miTRILtAsDgU+86pbvuVn99pQa66NsX0cOeKEsP1CJ+TwmJ7qmp9i2h1TT2ajp1 /Xq1CyBoomewt68M0JJZCrGv/OyIVr3CI9dSK4KrVygyG00UhaBJkoo8eLOkRtZw EswdDTh1JPSIkDl//b3eCma02Fwm7mAwYfmKGZn/TyPfwPrTrzhylMCmPb2mDaQ4 2cARlPm9W93KSVdbzk2PUW+opLTiUQ+6VL0iWArwERwHONSui+R3covCnicAUulJ FV8pnTTTtG6NG8nfpyy+fv6L8xkK8jkJEUz8oS29AhSdf5+yGq/PBQeFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=dgZLZNVKsJXTQb5CVCCPBkn89T6dD0JdMbFAfUWYzyY=; b=K68zuYHJ 84yqXRLUJjdIMoeHPa4hAY1pR5D+a51AK892C0TVSh5AKL688xsT4KU8Zn5YZrad ybALuOPdY9nkKUFQSh+HgVF13UowfrftPkXlmHvqiNgyx+9pDi9n0J5XnVvQGYtp xwrOm3f2cVsH9RNbTFTKSbogwtd3OTeXasD0yqYhQS16iyX+bIyeJdwF8YS55v4x fOGRU9lODchc6iSHty+GJmYrhHdAiH48m8BiFUM1kcN4kdrI7kPQHd01zKt7jRjM +r8dY3RMlhiIpMwTRKNOTIJMWHHC2bQv1KGyb0Lhgcbt+9hp+cTT5nAiPkrQByC1 GEXKuWU2wYHmnQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudehiedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomheptehnughrvgifucflvghffhgvrhihuceorghnughrvgifsegr jhdrihgurdgruheqnecuggftrfgrthhtvghrnhepjefgvdevheetkeevgeegleelgfelte etjeffleffvdduudevieffgeetleevhfetnecukfhppedugedrvddruddtledrkeehnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvg ifsegrjhdrihgurdgruh X-ME-Proxy: Received: from mistburn.lan (ppp14-2-109-85.adl-apt-pir-bras32.tpg.internode.on.net [14.2.109.85]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A6643068C6A; Wed, 9 Sep 2020 22:57:22 -0400 (EDT) From: Andrew Jeffery To: linux-gpio@vger.kernel.org Cc: linus.walleij@linaro.org, joel@jms.id.au, johnny_huang@aspeedtech.com, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] pinctrl: aspeed: Format pinconf debug consistent with pinmux Date: Thu, 10 Sep 2020 12:26:29 +0930 Message-Id: <20200910025631.2996342-2-andrew@aj.id.au> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910025631.2996342-1-andrew@aj.id.au> References: <20200910025631.2996342-1-andrew@aj.id.au> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org When displaying which pinconf register and field is being touched, format the field mask so that it's consistent with the way the pinmux portion formats the mask. Signed-off-by: Andrew Jeffery --- In v2: Format val with %X as suggested by Joel --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index 53f3f8aec695..2e0260c1a57c 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -539,9 +539,9 @@ int aspeed_pin_config_set(struct pinctrl_dev *pctldev, unsigned int offset, if (rc < 0) return rc; - pr_debug("%s: Set SCU%02X[%lu]=%d for param %d(=%d) on pin %d\n", - __func__, pconf->reg, __ffs(pconf->mask), - pmap->val, param, arg, offset); + pr_debug("%s: Set SCU%02X[0x%08X]=0x%X for param %d(=%d) on pin %d\n", + __func__, pconf->reg, pconf->mask, + val, param, arg, offset); } return 0;