From patchwork Tue Nov 24 08:53:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 331384 Delivered-To: patch@linaro.org Received: by 2002:a17:907:2110:0:0:0:0 with SMTP id qn16csp4194004ejb; Tue, 24 Nov 2020 00:53:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJyq0OnepI9vtHnT3K+v/rSn6DHEi9Hox+Ub7nh8/C+S3px1G4V2nErOFSwduoHEM/iNIqoP X-Received: by 2002:a17:906:2e0f:: with SMTP id n15mr3176007eji.486.1606208030173; Tue, 24 Nov 2020 00:53:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606208030; cv=none; d=google.com; s=arc-20160816; b=Vh3iNeyKv1rbJAz5ZiNlzmJwOiQ3lMz58dlEjVjPIOWvy2QcXPUxdrulnV079Ado7x gKpy/AZVL2Xv9lFxIaDNXqBtVrXpwaAwN+hF1VMCd6f9DA4vnorJ93RIV5HATdKBGtgN O5A5RyhiEzIwXhUhq1p5EO7hQGu+DGrwv9pBv0Ogzhbbp61oKSQ/HuLAs+kdjNx4U0eL /x7fO+PC02IIuk1pqOhnqHncYSZgJehDVbg9SXduti2VX8PuxvKdX09kGqg6yxGW+GJd pbKVY/J5sO9D6FGgP0UZGP1KcBlj2NnfohI5LMhvQaCLGqKPecpXbUwb2ESfgGkEfXod /Cgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=I2EmMJdusVtGBiOPmuBxSa/yxYa7w9wcih2XFbyqoVY=; b=BD9ZiDHQAMTMmfQm8PPlp9x5RlvvkZBko7JeaC9/6WdwyEICRN028O501WssvD7XtQ +OwlMr9wECzOpHuc7KAq6cHCvp2XY/SUCPWDEB9xS1OkJfUG6IYa7CyrWd3etIzFcNzQ IrhdDcfAu9Hwad5khbWoHdmlvu8GOH7uKfvs8MjN8t2EIhkTZ7eJVf+IPkoocTiut8hU W0wuay/q6J9RfKf1qIH1bfpNuKoJFDXOEoScfvLMME/xJ2mttMYFf5rxHrZz8Nd2h1qq humFDhMtFPPb/dnd/oMErmIrFa5FwSohzth9Jejetbff/c2J2TQrMJ5g/n+zCTkgu0dM hN2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rOzJh8nP; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi10si8834171edb.483.2020.11.24.00.53.49; Tue, 24 Nov 2020 00:53:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rOzJh8nP; spf=pass (google.com: domain of linux-gpio-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730828AbgKXIxt (ORCPT + 3 others); Tue, 24 Nov 2020 03:53:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730519AbgKXIxt (ORCPT ); Tue, 24 Nov 2020 03:53:49 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0E8EC0613CF for ; Tue, 24 Nov 2020 00:53:48 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id a9so27779066lfh.2 for ; Tue, 24 Nov 2020 00:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I2EmMJdusVtGBiOPmuBxSa/yxYa7w9wcih2XFbyqoVY=; b=rOzJh8nPd2bJlYYIp0tDoZzNyjPr5hO/eDo/Gh+AvBKrZrzR+183SDLWaAk0dJ7hFo 1XXVL6v2oqETnYO5PN08RGGTgBuO62/uhT5dul1SzQyaLnhG5AsbPr39C0BFzdtZVjZU 9BlFgQnPDjog6o3bsOyDz1jCv7tVFXBo6rH1r8DCcQpJ/U3C21DApr5nFtb5b4M8Gc2b dpgkzBgud5+0VcsQGQet0gxaydahKPy8LaKi+2Xe8yagBokZZGv3RCBdHInvPxvF2z1b 62aWqiOofiyEpQ/mjm6RKZ4gjDe7KzVNLYKPOUAmSVp/v89TFY3z1M90E0s3+4Gymvyw SvUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I2EmMJdusVtGBiOPmuBxSa/yxYa7w9wcih2XFbyqoVY=; b=lL8CPD6Qs61u1XFprSbFrJrrGjSVoJbyE+eQKdNqECTrSn8+U50eI6hmmeg2trx/oM q4NtjQ1dsgt2+jCdEA7dGof89buSJxRtyXwq7avI8jujqzt39umNtIp0cUcghQm4oLeg QQ45QTB/oA6qhIxSnd4pT/WAcTizLFm3A7ac/dG+LdFvGNdknHvhQvS4zEWfyzzKD0lP x/VKicQZ2i7yE5DljCKawcyl9fcMFaHcyAiFENSOFB5H6REvKO6kkWAjQnA+l0G8W40E w7ZRUuHA5xQS7yo54yaOZzHMclTOkDikcdGMo0pKv0ZjJW4eTB49Y3MDA2B7OPCRnkX+ zMIg== X-Gm-Message-State: AOAM533VlvFk1+3x3AmrF4glLhr7tFzyfu4XmjvYwBtC0ILHQ8GEk0R3 mkvgxYj4yvoxY2JOghHWfLuaaA== X-Received: by 2002:a19:6914:: with SMTP id e20mr1171533lfc.506.1606208027340; Tue, 24 Nov 2020 00:53:47 -0800 (PST) Received: from genomnajs.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id u18sm746602lfq.145.2020.11.24.00.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 00:53:46 -0800 (PST) From: Linus Walleij To: Hans de Goede , Mark Gross Cc: platform-driver-x86@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, Andres Salomon , linux-geode@lists.infradead.org, Darren Hart , x86@kernel.org, Andy Shevchenko Subject: [PATCH 1/3 v4] x86/platform/geode: Convert net5501 LED to GPIO machine descriptor Date: Tue, 24 Nov 2020 09:53:37 +0100 Message-Id: <20201124085339.6181-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This makes the machine look up the LED from a GPIO machine descriptor table. The Geode LEDs should be on the CS5535 companion chip. Cc: linux-gpio@vger.kernel.org Cc: Andres Salomon Cc: linux-geode@lists.infradead.org Cc: Darren Hart Cc: platform-driver-x86@vger.kernel.org Cc: x86@kernel.org Reviewed-by: Hans de Goede Reviewed-by: Andy Shevchenko Signed-off-by: Linus Walleij --- ChangeLog v3->v4: - Cc x86@kernel.org - Collect Hans' Review tag. ChangeLog v2->v3: - Rebase on v5.10-rc1 - Resend ChangeLog v1->v2: - Drop excess comma after terminator { } - Collect Andy's Reviewed-by --- arch/x86/platform/geode/net5501.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 2.26.2 diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c index 163e1b545517..558384acd777 100644 --- a/arch/x86/platform/geode/net5501.c +++ b/arch/x86/platform/geode/net5501.c @@ -20,6 +20,7 @@ #include #include #include +#include #include @@ -55,9 +56,7 @@ static struct platform_device net5501_buttons_dev = { static struct gpio_led net5501_leds[] = { { .name = "net5501:1", - .gpio = 6, .default_trigger = "default-on", - .active_low = 0, }, }; @@ -66,6 +65,15 @@ static struct gpio_led_platform_data net5501_leds_data = { .leds = net5501_leds, }; +static struct gpiod_lookup_table net5501_leds_gpio_table = { + .dev_id = "leds-gpio", + .table = { + /* The Geode GPIOs should be on the CS5535 companion chip */ + GPIO_LOOKUP_IDX("cs5535-gpio", 6, NULL, 0, GPIO_ACTIVE_HIGH), + { } + }, +}; + static struct platform_device net5501_leds_dev = { .name = "leds-gpio", .id = -1, @@ -80,6 +88,7 @@ static struct platform_device *net5501_devs[] __initdata = { static void __init register_net5501(void) { /* Setup LED control through leds-gpio driver */ + gpiod_add_lookup_table(&net5501_leds_gpio_table); platform_add_devices(net5501_devs, ARRAY_SIZE(net5501_devs)); }