From patchwork Wed Jan 20 01:12:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 368224 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF2BC433DB for ; Wed, 20 Jan 2021 01:14:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C4D723109 for ; Wed, 20 Jan 2021 01:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726491AbhATBNw (ORCPT ); Tue, 19 Jan 2021 20:13:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728325AbhATBNn (ORCPT ); Tue, 19 Jan 2021 20:13:43 -0500 Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A711BC0613C1 for ; Tue, 19 Jan 2021 17:13:01 -0800 (PST) Received: by mail-qt1-x84a.google.com with SMTP id n22so4948638qtv.10 for ; Tue, 19 Jan 2021 17:13:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=x9UCdD5B7kcBZN9/OwzPs4/7bTWXL0nty31C4Zn/i+A=; b=ExVKjE+PPGi9fYEFDJKV4IzybjgvD2DOBEvY6dJ9DUWNNNbtUumJrujI39sEX23YWV /2ma5ai/mYPA6Pj9NUVUmWyq71dwST+IfQK4CbWtKj78I1BU9BxySYmDufEtmm752l2K /V/EExuNR+6XbPO3a2qV+rXp4xGrnS2FzKYYXkFJV45eVTELt0xUgcmsTi12X2YOazyF G1FAMRwdtthSe1HmaO9N5jOLaRlacvoryGdJbxQMCNLLXtXj8kct5Ybx43WlTC5T9Nu8 ajYxtVXC7bJPE+sY7FXm4Z1h2vBZUnknQKfZDqMMoDmNzHpyDSeQqvNfa/X+jUiBdbwK MvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=x9UCdD5B7kcBZN9/OwzPs4/7bTWXL0nty31C4Zn/i+A=; b=SoyojWdqPCfpDJqESayH6/0Nfq5vK8FoibBZZiTtd39LBlmz+zFy+/ZKoTqga8lJ21 UiGx67ZD3bzOYpnGICTssvk0f/SeY+CZ68TJht26vOP3CCNYi+X+D4FMwAiuDyh5QtCV 1vA1y8yvOr05MtDj/yRH9LIIFbKJJF0AJ9uaQHu5HY8SfbTin1p3sgkosNI2AFg9RSP/ JhRTDp5kuQiITqjZ0xM3oOXkU11rYXkskAA5fw/HoX6UQl9A0/7yRArpsqFaUzxq7ia7 OKsOQKPVuA20ZgCGYM1xXePqLBGpBABR2ci+NQarU8WDF46MLK7n6ywXOnXoAvUa0kbq mp7g== X-Gm-Message-State: AOAM533EuJQq9EUhk6lx9oiaIDWkjplKgiEsdBFT2vdMT2OCoechKBRs k0lrdMSSHm5N552HaWqebKJTfydbWm0mbwg= X-Google-Smtp-Source: ABdhPJzv4urYPOjpjXybZ6AhHrrXpU5tQIq2UR8DaohRFqjeAH9bQqQYlkhZFZsXZ8bdiOU4GeXr8khzFF4yzLg= Sender: "saravanak via sendgmr" X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:7220:84ff:fe09:fedc]) (user=saravanak job=sendgmr) by 2002:a0c:c30e:: with SMTP id f14mr278151qvi.48.1611105180877; Tue, 19 Jan 2021 17:13:00 -0800 (PST) Date: Tue, 19 Jan 2021 17:12:44 -0800 Message-Id: <20210120011244.335025-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog Subject: [PATCH v3] gpiolib: Bind gpio_device to a driver to enable fw_devlink=on by default From: Saravana Kannan To: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Saravana Kannan Cc: Marc Zyngier , Jisheng Zhang , Kever Yang , kernel-team@android.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org There are multiple instances of GPIO device tree nodes of the form: foo { compatible = "acme,foo"; ... gpio0: gpio0@xxxxxxxx { compatible = "acme,bar"; ... gpio-controller; }; gpio1: gpio1@xxxxxxxx { compatible = "acme,bar"; ... gpio-controller; }; ... } bazz { my-gpios = <&gpio0 ...>; } Case 1: The driver for "foo" populates struct device for these gpio* nodes and then probes them using a driver that binds with "acme,bar". This lines up with how DT nodes with the "compatible" property are generally converted to struct devices and then registered with driver core to probe them. This also allows the gpio* devices to hook into all the driver core capabilities like runtime PM, probe deferral, suspend/resume ordering, device links, etc. Case 2: The driver for "foo" doesn't populate its child device nodes with "compatible" property and instead just loops through its child nodes and directly registers the GPIOs with gpiolib without ever populating a struct device or binding a driver to it. Drivers that follow the case 2 cause problems with fw_devlink=on. This is because fw_devlink will prevent bazz from probing until there's a struct device that has gpio0 as its fwnode (because bazz lists gpio0 as a GPIO supplier). Once the struct device is available, fw_devlink will create a device link between with gpio0 as the supplier and bazz as the consumer. After this point, the device link will prevent bazz from probing until its supplier (the gpio0 device) has bound to a driver. Once the supplier is bound to a driver, the probe of bazz is triggered automatically. Finding and refactoring all the instances of drivers that follow case 2 will cause a lot of code churn and it is not something that can be done in one shot. Examples of such instances are [1] [2]. This patch works around this problem and avoids all the code churn by simply creating a stub driver to bind to the gpio_device. Since the gpio_device already points to the GPIO device tree node, this allows all the consumers to continue probing when the driver follows case 2. If/when all the old drivers are refactored, we can revert this patch. [1] - https://lore.kernel.org/lkml/20201014191235.7f71fcb4@xhacker.debian/ [2] - https://lore.kernel.org/lkml/e28e1f38d87c12a3c714a6573beba6e1@kernel.org/ Cc: Marc Zyngier Cc: Jisheng Zhang Cc: Kever Yang Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Saravana Kannan --- drivers/gpio/gpiolib.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index b02cc2abd3b6..2cb88b7ca42b 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -574,6 +574,9 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, unsigned i; int base = gc->base; struct gpio_device *gdev; + struct device_node *of_node; + struct fwnode_handle *fwnode; + struct device *fwnode_dev; /* * First: allocate and populate the internal stat container, and @@ -596,6 +599,22 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, gdev->dev.of_node = gc->of_node; else gc->of_node = gdev->dev.of_node; + + of_node = gdev->dev.of_node; + fwnode = of_fwnode_handle(of_node); + fwnode_dev = get_dev_from_fwnode(fwnode); + /* + * If your driver hits this warning, it's because you are directly + * parsing a device tree node with "compatible" property and + * initializing it instead of using the standard DT + device driver + * model of creating a struct device and then initializing it in the + * probe function. Please refactor your driver. + */ + if (!fwnode_dev && of_find_property(of_node, "compatible", NULL)) { + pr_warn("Create a real device for %pOF\n", of_node); + gdev->dev.fwnode = fwnode; + } + put_device(fwnode_dev); #endif gdev->id = ida_alloc(&gpio_ida, GFP_KERNEL); @@ -4202,6 +4221,17 @@ void gpiod_put_array(struct gpio_descs *descs) } EXPORT_SYMBOL_GPL(gpiod_put_array); +static int gpio_stub_drv_probe(struct device *dev) +{ + return 0; +} + +static struct device_driver gpio_stub_drv = { + .name = "gpio_stub_drv", + .bus = &gpio_bus_type, + .probe = gpio_stub_drv_probe, +}; + static int __init gpiolib_dev_init(void) { int ret; @@ -4213,9 +4243,16 @@ static int __init gpiolib_dev_init(void) return ret; } + if (driver_register(&gpio_stub_drv) < 0) { + pr_err("gpiolib: could not register GPIO stub driver\n"); + bus_unregister(&gpio_bus_type); + return ret; + } + ret = alloc_chrdev_region(&gpio_devt, 0, GPIO_DEV_MAX, GPIOCHIP_NAME); if (ret < 0) { pr_err("gpiolib: failed to allocate char dev region\n"); + driver_unregister(&gpio_stub_drv); bus_unregister(&gpio_bus_type); return ret; }